That way, your new branch has the testing code that it depends on, and we can easily merge the testing branch then bb-134 after GCI completes in 11 days
2016-01-16 01622, 2016
opatel99
LordSputnik: Is it fine if I post my review on facebook and take a picture of it?
2016-01-16 01626, 2016
LordSputnik
(I believe both of those are multi-instance tasks, which is why we can't do it now)
2016-01-16 01640, 2016
LordSputnik
opatel99: Yeah, upload the screenshot to the task page
2016-01-16 01611, 2016
LordSputnik
opatel99: I probably won't be reviewing that one (I emergency assigned myself to help out a few days ago), but that's definitely what others have been doing
2016-01-16 01625, 2016
opatel99
ok
2016-01-16 01627, 2016
Freso
gcilou stanislas, April was so last year.
2016-01-16 01605, 2016
stanislas
LordSputnik: And when i make a commit then to the base(tests) branch, what would happen to the bb-134 branch. Would this commit be in both branches ?
2016-01-16 01613, 2016
stanislas
Freso: Oh, I remember. It was a lot colder then at Easter than at Christmas :)
2016-01-16 01647, 2016
ruaok
meh. way overdue for bed now.
2016-01-16 01654, 2016
ruaok
bitmap: see email.
2016-01-16 01601, 2016
ruaok
hopefully things will be calm for now.
2016-01-16 01602, 2016
ruaok
nn
2016-01-16 01626, 2016
bitmap
night
2016-01-16 01650, 2016
opatel99
Freso: Submitted my first review task!
2016-01-16 01604, 2016
opatel99
I think I got at least 2 tasks in every section now... (Can I get 3) maybe...
2016-01-16 01600, 2016
Freso
opatel99: Yay for writing reviews! :D
2016-01-16 01659, 2016
Freso
opatel99: A link to the Facebook post is better than a screenshot and what most have been doing.
2016-01-16 01611, 2016
Freso
Some do screenshots, but I ask those to also provide the links.
2016-01-16 01624, 2016
opatel99
Freso: Do I make my profile public for this?
2016-01-16 01635, 2016
Freso
You can make individual posts public.
2016-01-16 01650, 2016
Freso
Or you can share the review with the MusicBrainz group instead.
2016-01-16 01641, 2016
opatel99
The options I see are Friends, Friends of Friends, Only Me, and Custom(Which doesn't have the musicbrainz selection)
2016-01-16 01659, 2016
opatel99
Oh found it. I had to go to privacy to enable it
2016-01-16 01629, 2016
opatel99
Freso: Updated task page
2016-01-16 01618, 2016
LordSputnik
stanislas: nope, but that's OK, because you only need the work you've done so far in the testing branch to add the bb-134 tests. Eventually when both branches are pulled, git will handle the merging of the two :)
2016-01-16 01639, 2016
stanislas
LordSputnik: Ok, great.
2016-01-16 01623, 2016
stanislas
LordSputnik: Should I include the license in each file ?
2016-01-16 01616, 2016
stanislas
LordSputnik: I am doing it currently in all files longer than 100 lines (as far as I know).
2016-01-16 01633, 2016
D4RK-PH0ENiX has quit
2016-01-16 01600, 2016
D4RK-PH0ENiX joined the channel
2016-01-16 01601, 2016
LordSputnik
stanislas: Do it anywhere you've had creative input please :)
2016-01-16 01606, 2016
LordSputnik
Whether you do it or not, your code is copyrighted to you, but adding your name up the top with the correct license implies you're licensing it for use in the project
2016-01-16 01643, 2016
stanislas
LordSputnik: Ok, I will leave only constants.py, __init__.py and ws_bugs only without license. Just as it is now.
2016-01-16 01644, 2016
D4RK-PH0ENiX has quit
2016-01-16 01641, 2016
Freso
opatel99: To share with the MB group, you go to the MB group and copy the URL of the CB review into the post text area, and write whatever you want. :p
2016-01-16 01643, 2016
LordSputnik
stanislas: I'd put one in __init__.py too
2016-01-16 01630, 2016
stanislas
And what about test.py ?
2016-01-16 01606, 2016
stanislas
It has risen a little, after adding the args and logging stuff there.
2016-01-16 01638, 2016
opatel99
Freso: Submitted there as well
2016-01-16 01620, 2016
stanislas
LordSputnik: I've said it like 2 weeks ago :), but I will hopefully try to finalize the tests tomorrow. Wish me luck. I've got 7 TODOs and I've got to end tests for display_alias, add docstrings and refractor and review the whole code :)
2016-01-16 01600, 2016
opatel99
reosarevok: urls.0.url doesn't seem to work for events?
i'll have to stop all DomUs on it, well, those running, luna,perry,teto
2016-01-16 01643, 2016
zas
to restart dom0 properly
2016-01-16 01600, 2016
zas
half of VMs didn't start
2016-01-16 01655, 2016
opatel99
I still need to fill in the GITHUB_URL to complete the Edit Note and figure out the proper urls.0.url selector to add the external link. Anything else?
2016-01-16 01600, 2016
opatel99
Oh and style
2016-01-16 01601, 2016
Leo__Verto has quit
2016-01-16 01643, 2016
opatel99
Really close to a final. Freso: Where would the code be stored? MB's userscript repo?
2016-01-16 01649, 2016
typhoe has quit
2016-01-16 01603, 2016
typhoe joined the channel
2016-01-16 01646, 2016
navap has quit
2016-01-16 01640, 2016
navap joined the channel
2016-01-16 01630, 2016
zas
ruaok: i fixed hoser, it was lacking enough loop devices to start remaining VMs, i added max_loop=64 to kernel cmdline in grub
2016-01-16 01607, 2016
zas
but there are more issues: xend isn't started automatically at boot, though it is supposed to
2016-01-16 01625, 2016
zas
and luna,perry,teto are automatically restored (and saved on shutdown), but not newer VMs, i tried to autostart taz, but it doesnt work. I'll have a closer look later (4 am ... i need to sleep)
2016-01-16 01605, 2016
zas
i didnt restart cosgrove nor pinoprime, i think those are to be removed anyway, to be confirmed
2016-01-16 01617, 2016
zas
hoser raid is rebuilding, the initial issue was sudden, perhaps a power supply issue
2016-01-16 01638, 2016
zas
my bad, cosgrove is running
2016-01-16 01623, 2016
zas
since hoser needed to be rebooted, i upgraded packages on it
2016-01-16 01645, 2016
opatel99 has quit
2016-01-16 01635, 2016
JesseW has quit
2016-01-16 01644, 2016
JesseW joined the channel
2016-01-16 01608, 2016
JesseW has quit
2016-01-16 01646, 2016
typhoe- joined the channel
2016-01-16 01654, 2016
typhoe has quit
2016-01-16 01654, 2016
typhoe- is now known as typhoe
2016-01-16 01656, 2016
JesseW joined the channel
2016-01-16 01654, 2016
yeeeargh joined the channel
2016-01-16 01608, 2016
JesseW has quit
2016-01-16 01614, 2016
yeeeargh has quit
2016-01-16 01639, 2016
ruaok
zas: moin.
2016-01-16 01655, 2016
ruaok
thanks for taking care of that, that sounds about like the right list of things to do.
2016-01-16 01608, 2016
yeeeargh joined the channel
2016-01-16 01657, 2016
reosarevok
bitmap: do you know how to seed URLs for events? opatel99 can't find it and I don't really know either
zas: Redis on teto is used by MBS, at least. For access, it should be indeed enough to change the configuration in DBDefs.pm; but it would be good if the existing data could be moved, too.
2016-01-16 01629, 2016
zas
existing data was prolly cleared recently (hoser crashed badly this night)
2016-01-16 01652, 2016
chirlu`
My login session is still there, at least.
2016-01-16 01659, 2016
yeeeargh has quit
2016-01-16 01601, 2016
chirlu`
CAA indexer seems to be affected, but that’s probably way down on the priorities list. ;-)
2016-01-16 01659, 2016
D4RK-PH0ENiX joined the channel
2016-01-16 01638, 2016
zas
i will add a dns name for this redis, and we'll use it instead the hardcoded IP used in role attributes atm