That way, your new branch has the testing code that it depends on, and we can easily merge the testing branch then bb-134 after GCI completes in 11 days
opatel99
LordSputnik: Is it fine if I post my review on facebook and take a picture of it?
LordSputnik
(I believe both of those are multi-instance tasks, which is why we can't do it now)
opatel99: Yeah, upload the screenshot to the task page
opatel99: I probably won't be reviewing that one (I emergency assigned myself to help out a few days ago), but that's definitely what others have been doing
opatel99
ok
Freso
gcilou stanislas, April was so last year.
stanislas
LordSputnik: And when i make a commit then to the base(tests) branch, what would happen to the bb-134 branch. Would this commit be in both branches ?
Freso: Oh, I remember. It was a lot colder then at Easter than at Christmas :)
ruaok
meh. way overdue for bed now.
bitmap: see email.
hopefully things will be calm for now.
nn
bitmap
night
opatel99
Freso: Submitted my first review task!
I think I got at least 2 tasks in every section now... (Can I get 3) maybe...
Freso
opatel99: Yay for writing reviews! :D
opatel99: A link to the Facebook post is better than a screenshot and what most have been doing.
Some do screenshots, but I ask those to also provide the links.
opatel99
Freso: Do I make my profile public for this?
Freso
You can make individual posts public.
Or you can share the review with the MusicBrainz group instead.
opatel99
The options I see are Friends, Friends of Friends, Only Me, and Custom(Which doesn't have the musicbrainz selection)
Oh found it. I had to go to privacy to enable it
Freso: Updated task page
LordSputnik
stanislas: nope, but that's OK, because you only need the work you've done so far in the testing branch to add the bb-134 tests. Eventually when both branches are pulled, git will handle the merging of the two :)
stanislas
LordSputnik: Ok, great.
LordSputnik: Should I include the license in each file ?
LordSputnik: I am doing it currently in all files longer than 100 lines (as far as I know).
D4RK-PH0ENiX has quit
D4RK-PH0ENiX joined the channel
LordSputnik
stanislas: Do it anywhere you've had creative input please :)
Whether you do it or not, your code is copyrighted to you, but adding your name up the top with the correct license implies you're licensing it for use in the project
stanislas
LordSputnik: Ok, I will leave only constants.py, __init__.py and ws_bugs only without license. Just as it is now.
D4RK-PH0ENiX has quit
Freso
opatel99: To share with the MB group, you go to the MB group and copy the URL of the CB review into the post text area, and write whatever you want. :p
LordSputnik
stanislas: I'd put one in __init__.py too
stanislas
And what about test.py ?
It has risen a little, after adding the args and logging stuff there.
opatel99
Freso: Submitted there as well
stanislas
LordSputnik: I've said it like 2 weeks ago :), but I will hopefully try to finalize the tests tomorrow. Wish me luck. I've got 7 TODOs and I've got to end tests for display_alias, add docstrings and refractor and review the whole code :)
opatel99
reosarevok: urls.0.url doesn't seem to work for events?
i'll have to stop all DomUs on it, well, those running, luna,perry,teto
to restart dom0 properly
half of VMs didn't start
opatel99
I still need to fill in the GITHUB_URL to complete the Edit Note and figure out the proper urls.0.url selector to add the external link. Anything else?
Oh and style
Leo__Verto has quit
Really close to a final. Freso: Where would the code be stored? MB's userscript repo?
typhoe has quit
typhoe joined the channel
navap has quit
navap joined the channel
zas
ruaok: i fixed hoser, it was lacking enough loop devices to start remaining VMs, i added max_loop=64 to kernel cmdline in grub
but there are more issues: xend isn't started automatically at boot, though it is supposed to
and luna,perry,teto are automatically restored (and saved on shutdown), but not newer VMs, i tried to autostart taz, but it doesnt work. I'll have a closer look later (4 am ... i need to sleep)
i didnt restart cosgrove nor pinoprime, i think those are to be removed anyway, to be confirmed
hoser raid is rebuilding, the initial issue was sudden, perhaps a power supply issue
my bad, cosgrove is running
since hoser needed to be rebooted, i upgraded packages on it
opatel99 has quit
JesseW has quit
JesseW joined the channel
JesseW has quit
typhoe- joined the channel
typhoe has quit
typhoe- is now known as typhoe
JesseW joined the channel
yeeeargh joined the channel
JesseW has quit
yeeeargh has quit
ruaok
zas: moin.
thanks for taking care of that, that sounds about like the right list of things to do.
yeeeargh joined the channel
reosarevok
bitmap: do you know how to seed URLs for events? opatel99 can't find it and I don't really know either
zas: Redis on teto is used by MBS, at least. For access, it should be indeed enough to change the configuration in DBDefs.pm; but it would be good if the existing data could be moved, too.
zas
existing data was prolly cleared recently (hoser crashed badly this night)
chirlu`
My login session is still there, at least.
yeeeargh has quit
CAA indexer seems to be affected, but that’s probably way down on the priorities list. ;-)
D4RK-PH0ENiX joined the channel
zas
i will add a dns name for this redis, and we'll use it instead the hardcoded IP used in role attributes atm