LordSputnik: I hope you haven't read my recent code. I am making some serious changes including a rebase of bb-134. I will tell you when I am done with that.
LordSputnik: I will be adding some more docstrings in a while.
2016-01-22 02212, 2016
stanislas
LordSputnik: I want to reach 4000 lines added :)
2016-01-22 02253, 2016
stanislas
LordSputnik: But that won't be some critical changes like those I've just done.
2016-01-22 02250, 2016
gcilou
Freso, reosarevok needs extra class that's why ;D
2016-01-22 02209, 2016
Freso
I thought it might be. :)
2016-01-22 02238, 2016
gcilou
Nah, I gave a better desc. as a line note :)
2016-01-22 02227, 2016
Bookzombie has quit
2016-01-22 02242, 2016
Bookzombie joined the channel
2016-01-22 02211, 2016
Freso
Yeah, so I mostly have whitespace comments.
2016-01-22 02255, 2016
Freso
The Python looks fine AFAICT. I don't know how OCD Gentlecat is about the HTML stuff. If he's as OCD as me, there's a bunch of small things that need fixing. If he's not, probably a bunch less. ;)
2016-01-22 02240, 2016
Freso guesses opatel99 is not around right now
2016-01-22 02240, 2016
gcilou
Freso, I've been editing the whitespace :) I'll push it soon
2016-01-22 02246, 2016
Freso
gcilou: 👍
2016-01-22 02258, 2016
gcilou
Freso, what's up with this "If you do <br/><br/>, you probably actually want </p><p>"?
2016-01-22 02221, 2016
Freso
gcilou: Two line breaks usually denote a new paragraph.
2016-01-22 02244, 2016
Freso
In a HTML a new paragraph is made by ending one (</p>) and creating a new one (<p>).
2016-01-22 02248, 2016
Freso
*In HTML
2016-01-22 02259, 2016
gcilou
Oh so instead of just breaking up the paragraph, just do several <p>s?
2016-01-22 02202, 2016
Freso
(If we're on HTML 5, the </p> isn't needed, I think.)
2016-01-22 02204, 2016
Freso
Yeah.
2016-01-22 02213, 2016
gcilou
Ok I gotcha
2016-01-22 02242, 2016
Freso is old-fashioned and likes the XHTML of closing elements and believes in semantic markup
2016-01-22 02246, 2016
kepstin
Freso: as far as html5 is concerned, the parser is required to deal with <p> with missing end, but it's still preferred to close them.
2016-01-22 02230, 2016
Freso
kepstin: Cheers :)
2016-01-22 02248, 2016
kepstin
(the <p> with no end actually dates back to pre-standardization html, the fact that it's still in the parser is for legacy compatibility)
2016-01-22 02237, 2016
Freso
Yeah.
2016-01-22 02232, 2016
gcilou listens to her cat growling in her dream :)
2016-01-22 02217, 2016
kepstin
the parser also has to deal with things like people using xml-style self-closing elements <foo/> inside an html document; iirc it explicitly ignores any / before a closing bracket.
2016-01-22 02220, 2016
flamingspinach has quit
2016-01-22 02226, 2016
gcilou
Freso, better?
2016-01-22 02242, 2016
flamingspinach joined the channel
2016-01-22 02259, 2016
Freso
God I really don't like how Facebook slows everything down.
2016-01-22 02207, 2016
Freso
gcilou: I'll check it out in a sec.
2016-01-22 02221, 2016
gcilou
ok
2016-01-22 02202, 2016
stanislas
LordSputnik: I've just added you as a collaborator in my CaliBBre repo.
2016-01-22 02207, 2016
stanislas
LordSputnik: You've said something like that you want to move it under bookbrainz-ws, so I just thought that this might be a start.
2016-01-22 02228, 2016
stanislas
* under bookbrainz
2016-01-22 02211, 2016
opatel99
Sorry for delay
2016-01-22 02208, 2016
JesseW joined the channel
2016-01-22 02254, 2016
opatel99
JesseW: !
2016-01-22 02235, 2016
JesseW has quit
2016-01-22 02249, 2016
Freso
opatel99: I'll live. :)
2016-01-22 02205, 2016
Freso
gcilou: Sending an e-mail, then I'll look.
2016-01-22 02222, 2016
gcilou
okey!
2016-01-22 02254, 2016
stanislas
LordSputnik: I've just seen my CaliBBre plugin from 2 months ago, it's so shit I can't believe It has ever been accepted. I've had like 35 commits with no valid commit messages and the code is so ugly. I am now sorting out that mess.
2016-01-22 02231, 2016
Freso
gcilou: At a glance, the HTML looks much nicer with all that stray whitespace removed. ;)
2016-01-22 02248, 2016
gcilou
Yup! I think so too :)
2016-01-22 02235, 2016
opatel99
stanislas: I had no idea what PEP8 was until zas destroyed by pull request with it. If I didn't learn anything else from GCi, I at least learned PEP8.
2016-01-22 02250, 2016
opatel99
Like 2nd day of GCi I think ^
2016-01-22 02254, 2016
Freso
PEP8 is a good thing to have learned if you're ever going to collaborate on anything using Python. :)
2016-01-22 02209, 2016
Freso
gcilou: No new comments, but I have two unaddressed comments. :) (One of them I think I wrote in the last batch, but maybe I didn't?)
2016-01-22 02229, 2016
gcilou
About the style?
2016-01-22 02201, 2016
gcilou
oh I see now
2016-01-22 02241, 2016
Freso
opatel99: Not very. :)
2016-01-22 02211, 2016
Freso
I frequently re-realise how "chirlu" works.
2016-01-22 02225, 2016
opatel99
I got that one pretty early. Reversed.
2016-01-22 02257, 2016
stanislas
Freso: 'Freso' stands for something other than your name ?
2016-01-22 02201, 2016
opatel99
LordSputnik probably turns into "I am Lord Voldemort" after some manipulation.
2016-01-22 02202, 2016
Freso
No.
2016-01-22 02207, 2016
gcilou
I got how Freso worked early but just figured "chirlu" out like yesterday
2016-01-22 02215, 2016
Freso
:)
2016-01-22 02201, 2016
opatel99
gcilou: I have no idea what gcilou is. GC makes sense or it could be GCi but what is ilou/lou?
2016-01-22 02247, 2016
gcilou
lou is a nickname of mine. Caroline->line->lina->linalou->lou/louie lol
2016-01-22 02202, 2016
bitmap
gcilou: sorry, not sure I'll have a proper bio til next week. what you have works for now :)
