Then the instance of the React class has access to it at this.props.revision
2016-01-24 02424, 2016
CatQuest
woa i let the archive.org and even the error message is now gone
2016-01-24 02424, 2016
CatQuest
<-- idiot
2016-01-24 02449, 2016
LordSputnik
stanislas: then you can access the properties of this.props.revision inside the React element, and pull out whatever you need
2016-01-24 02406, 2016
stanislas
Yeah, I understand that, thanks. What about the question regrarding if ?
2016-01-24 02419, 2016
Freso
gcilou: "AcousticBrainz is a joint effort between Music Technology Group at Universitat Pompeu Fabra in Barcelona and the MusicBrainz project." → "AB is a joint effort with MTG at UPF in Barcelona." (with "MTG" and "UPF" being links)
2016-01-24 02456, 2016
gcilou
same with IA?
2016-01-24 02407, 2016
Freso
"Cover Art Archive is a joint project with the Internet Archive." (with t... yes. Same thing. :))
2016-01-24 02413, 2016
LordSputnik
stanislas: Ahhh I see what you mean now
2016-01-24 02415, 2016
gcilou
:P
2016-01-24 02444, 2016
Freso
gcilou: The page is already specifying that they're MetaBrainz projects, so there's no reason to re-state that.
2016-01-24 02453, 2016
gcilou
okay
2016-01-24 02419, 2016
gcilou
where?
2016-01-24 02454, 2016
LordSputnik
stanislas: define a variable to hold the content, then assign it with different content in different branches of the if statement. Then put the variable inside the returned react element in the class
("MusicBrainz" is used on those pages because 1) MB is a far more well-known "brand" than MeB is, and 2) CAA and AB relate directly to MB data, not to data from other MeB projects (though I guess AB is also using MsB now/soon).)
2016-01-24 02413, 2016
LordSputnik
(here, loadingSpinner is using the conditional operator, but same concept)
2016-01-24 02418, 2016
Freso
gcilou: "The MetaBrainz Foundation Projects"?
2016-01-24 02423, 2016
gcilou
oh
2016-01-24 02440, 2016
LordSputnik
stanislas: that OK?
2016-01-24 02451, 2016
gcilou
so just "The Projects"?
2016-01-24 02452, 2016
stanislas
Yeah, I got it.
2016-01-24 02410, 2016
stanislas
LordSputnik: I thought that maybe there is some way like in jijna2
2016-01-24 02412, 2016
Freso
gcilou: No, I think the header is fine.
2016-01-24 02425, 2016
stanislas
LordSputnik: thanks :)
2016-01-24 02427, 2016
gcilou
oh okay I was confused but now I got it
2016-01-24 02435, 2016
Freso
gcilou: But there's no reason to report for project that they're MetaBrainz projects, as that's the whole premise of that page.
2016-01-24 02447, 2016
Freso
*repeat
2016-01-24 02452, 2016
gcilou
ok
2016-01-24 02410, 2016
Freso
If it wasn't a MetaBrainz project, it shouldn't be listed on that page to begin with. :)
2016-01-24 02424, 2016
ariscop joined the channel
2016-01-24 02450, 2016
LordSputnik
stanislas: no, because React focuses on using HTML within code, rather than code within HTML. It's more about building up/composing the HTML and defining new elements than templating stuff
2016-01-24 02428, 2016
LordSputnik
stanislas: That's one of the key differences between React and templating languages, and something which I hope will benefit us in the long run
2016-01-24 02403, 2016
stanislas
LordSputnik: Seems clear to me. Thanks for explaining the difference.
2016-01-24 02453, 2016
stanislas
I am curious how come this task is easier than 'create one entity on MB' task :)
2016-01-24 02432, 2016
Freso
gcilou: Does my reasoning make sense to you? :)
2016-01-24 02444, 2016
Freso
(It doesn't always to me, so it'd be fair.)
2016-01-24 02454, 2016
gcilou
Yes yes it does.
2016-01-24 02409, 2016
LordSputnik
stanislas: it's not easier, but it's beginner because it introduces the student to the bookbrainz-site codebase in a fairly non-scary way :)
2016-01-24 02426, 2016
gcilou
Freso, should be better now
2016-01-24 02447, 2016
LordSputnik
eg. you don't have to worry about setting up WS interaction, showing error messages or configuring the build system :D
2016-01-24 02419, 2016
stanislas
The file you've linked in is great. I love to learn by examples if it possible and this one include nearly all of the stuff I want.
2016-01-24 02413, 2016
Freso
gcilou: Looks better, yep. :)
2016-01-24 02419, 2016
gcilou
yay
2016-01-24 02434, 2016
Freso
I think when Gentlecat is happy, I'm happy.
2016-01-24 02453, 2016
gcilou
Good. Is Gentlecat happy?
2016-01-24 02400, 2016
Freso
Oh, no!
2016-01-24 02402, 2016
Freso
D:
2016-01-24 02407, 2016
gcilou
??
2016-01-24 02420, 2016
Freso
You've HTTPS'd the AB logo link.
2016-01-24 02430, 2016
Freso
AB doesn't work over HTTPS at this point.
2016-01-24 02446, 2016
Freso
So fix that, and *then* I'm happy. ;)
2016-01-24 02454, 2016
gcilou
urg. that weird why did I do that.
2016-01-24 02422, 2016
Freso
Also not sure whether to link MsB as HTTPS or HTTP.
2016-01-24 02432, 2016
Freso
HTTPS *does* work, but the cert. is broken.
2016-01-24 02445, 2016
gcilou
so take it out for now?
2016-01-24 02446, 2016
Freso
And I'm not sure if it's going to be fixed up.
2016-01-24 02448, 2016
Freso
zas: ^
2016-01-24 02451, 2016
Freso
Yeah.
2016-01-24 02411, 2016
Freso
It can be added in whenever we set up HTTPS for MsB properly.
2016-01-24 02435, 2016
Freso
(Automatically regenerating Let's Encrypt certificates or however.)
2016-01-24 02413, 2016
Freso goes to make a MsB PR...
2016-01-24 02454, 2016
gcilou
Freso, fixed
2016-01-24 02427, 2016
reosarevok
Freso: is there any link to the MeB YT channel on the site? if not, where should we put it?
2016-01-24 02457, 2016
Freso
No clue. :p
2016-01-24 02457, 2016
reosarevok
Also, any idea when you'll publish that relationship editor video? I was going to link a new user to it but I see it's not out yet :)
Re: "for some projects you say "<project> is a...", for others "<project> <is trying to do something>"" - I think it's fine to both leave as is, but it'd also be fine to rewrite so they all sound similar.
