#metabrainz

Then the instance of the React class has access to it at this.props.revision

woa i let the archive.org and even the error message is now gone

<-- idiot

stanislas: then you can access the properties of this.props.revision inside the React element, and pull out whatever you need

Yeah, I understand that, thanks. What about the question regrarding if ?

gcilou: "AcousticBrainz is a joint effort between Music Technology Group at Universitat Pompeu Fabra in Barcelona and the MusicBrainz project." → "AB is a joint effort with MTG at UPF in Barcelona." (with "MTG" and "UPF" being links)

same with IA?

"Cover Art Archive is a joint project with the Internet Archive." (with t... yes. Same thing. :))

stanislas: Ahhh I see what you mean now

:P

gcilou: The page is already specifying that they're MetaBrainz projects, so there's no reason to re-state that.

okay

where?

stanislas: define a variable to hold the content, then assign it with different content in different branches of the if statement. Then put the variable inside the returned react element in the class

stanislas: eg. https://github.com/bookbrainz/bookbrainz-site/b...

("MusicBrainz" is used on those pages because 1) MB is a far more well-known "brand" than MeB is, and 2) CAA and AB relate directly to MB data, not to data from other MeB projects (though I guess AB is also using MsB now/soon).)

(here, loadingSpinner is using the conditional operator, but same concept)

gcilou: "The MetaBrainz Foundation Projects"?

oh

stanislas: that OK?

so just "The Projects"?

Yeah, I got it.

LordSputnik: I thought that maybe there is some way like in jijna2

gcilou: No, I think the header is fine.

LordSputnik: thanks :)

oh okay I was confused but now I got it

gcilou: But there's no reason to report for project that they're MetaBrainz projects, as that's the whole premise of that page.

*repeat

ok

If it wasn't a MetaBrainz project, it shouldn't be listed on that page to begin with. :)

stanislas: no, because React focuses on using HTML within code, rather than code within HTML. It's more about building up/composing the HTML and defining new elements than templating stuff

stanislas: That's one of the key differences between React and templating languages, and something which I hope will benefit us in the long run

LordSputnik: Seems clear to me. Thanks for explaining the difference.

I am curious how come this task is easier than 'create one entity on MB' task :)

gcilou: Does my reasoning make sense to you? :)

(It doesn't always to me, so it'd be fair.)

Yes yes it does.

stanislas: it's not easier, but it's beginner because it introduces the student to the bookbrainz-site codebase in a fairly non-scary way :)

Freso, should be better now

eg. you don't have to worry about setting up WS interaction, showing error messages or configuring the build system :D

The file you've linked in is great. I love to learn by examples if it possible and this one include nearly all of the stuff I want.

gcilou: Looks better, yep. :)

yay

I think when Gentlecat is happy, I'm happy.

Good. Is Gentlecat happy?

Oh, no!

D:

??

You've HTTPS'd the AB logo link.

AB doesn't work over HTTPS at this point.

So fix that, and *then* I'm happy. ;)

urg. that weird why did I do that.

Also not sure whether to link MsB as HTTPS or HTTP.

HTTPS *does* work, but the cert. is broken.

so take it out for now?

And I'm not sure if it's going to be fixed up.

zas: ^

Yeah.

It can be added in whenever we set up HTTPS for MsB properly.

(Automatically regenerating Let's Encrypt certificates or however.)

Freso, fixed

Freso: is there any link to the MeB YT channel on the site? if not, where should we put it?

No clue. :p

Also, any idea when you'll publish that relationship editor video? I was going to link a new user to it but I see it's not out yet :)

To all? :p

Don't know when I will publish it. You can still refer to https://www.youtube.com/watch?v=Koaa7vsTCFo though and it should work.

But I won't publish until I've added description and tags and annotations.

Oh, nice :)

gcilou: no :(

I don't see logos in chrome

Soo what do you think is wrong? ( I can't see them either )

probably has something to do with that media thing

never used it

[messybrainz-server] Freso opened pull request #13: Remove ETA for first data dump. (master...master) https://github.com/metabrainz/messybrainz-serve...

hm

Gentlecat, what should I try?

“master...master”

gcilou: can try to implement whatever you are doing without using boostrap

so take out media objects?

Gentlecat^

sure

chirlu`: I didn't bother to make a branch. I fully expect to delete Freso:msb once the PR has gone through.

I try not to use boostrap components when I don't have to

Gentlecat

I have a question for you

Are you intentionally calling Bootstrap "Boostrap"?

because you've made that typo in the repo too, the bootstrap folder and file are both called "boostrap" :P

LordSputnik: How am I doing https://gist.github.com/stasszczesniak/15c3a32e... ?

I don't know what you are talking about

this https://github.com/metabrainz/metabrainz.org/tr...

and this https://getbootstrap.com/

Man. Clothes in Spanish is hard.

yes, boostrap

there is an extra t in bootstrap

or am I not getting some kind of joke hereß

(which is always possible)

Leo_Verto, I understand you

Boo!

Gentlecat, do you like how this looks? https://usercontent.irccloud-cdn.com/file/Y8hua...

Too much whitespace, IMHO.

I think logos are a bit too big and are a bit unaligned with titles

And that too.

they are also closer to each other than to their projects

Ok

so it feels like that's a row of random logos

what if you have two columns?

small logo on top, then title, and description below

don't know how much better it will look, need to try

you can use boostrap's grid system for that

so like from right to left "logo - logo" down "title - title" down "description - description" ?

though this might not align horizontally well

yeah, that will be a problem

so..

I'm also not sure about inconsistency in descriptions

Gentlecat, you like how MB looks? https://usercontent.irccloud-cdn.com/file/4mlmf...

with logo moved down

for some projects you say "<project> is a...", for others "<project> <is trying to do something>"

Freso: ^ what do you think?

all little .. https://usercontent.irccloud-cdn.com/file/BVBOK...

Leftmost: ?

I would also look at how other organizations describe their projects

how they display them

How did you do that?

almost all the text is taken straight from the projects

I mean the presentation

how the page looks

LordSputnik: ping

oh. What changes did you make? It looks good

adjusted widths, margins

care to share?

Re: "for some projects you say "<project> is a...", for others "<project> <is trying to do something>"" - I think it's fine to both leave as is, but it'd also be fine to rewrite so they all sound similar.

don't remember if that's all of it

try to play with it

experiment

^

ok

ok, this is my last task

Freso: thanks for info