#metabrainz

/

      • alastairp
        and then benchmark it over a db query and a cache system

        • 2016-04-04 09534, 2016

      • alastairp
        can jira have subcomponents?

        • 2016-04-04 09505, 2016

      • ruaok
        a beefier DB system should be able to handle such queries...

        • 2016-04-04 09518, 2016

      • ruaok
        but, I'm not 100% certain.

        • 2016-04-04 09553, 2016

      • ruaok
        what is your timeline for getting this done?

        • 2016-04-04 09516, 2016

      • ruaok
        it would be nice to try it with the new setup and if it isn't up to snuff, then build this.

        • 2016-04-04 09506, 2016

      • alastairp
        it'll be a requirement for the next stages of our dataset editor/model generation

        • 2016-04-04 09510, 2016

      • alastairp
        starting ~now

        • 2016-04-04 09514, 2016

      • alastairp
        finishing ~then

        • 2016-04-04 09538, 2016

      • alastairp
        as Gentlecat pointed out, we have a db on spike anyway. So I'll definitely consider doing queries first and see how that works out

        • 2016-04-04 09554, 2016

      • alastairp
        but if it's not fast enough, I'll need to do something else, let's say within 4-6 weeks

        • 2016-04-04 09502, 2016

      • alastairp
        2:19 PM <ruaok> it would be nice to try it with the new setup

        • 2016-04-04 09512, 2016

      • alastairp
        what do you mean new setup?, and what is "this"

        • 2016-04-04 09503, 2016

      • Freso
        new setup = ruaok | one master and two read-only beasts.

        • 2016-04-04 09520, 2016

      • Freso
        And I'm guessing "this" = whatever you're doing with AB

        • 2016-04-04 09515, 2016

      • alastairp
        Gentlecat: https://github.com/metabrainz/acousticbrainz-serv… this doesn't have if isMounted() guards

        • 2016-04-04 09525, 2016

      • alastairp
        like you added in https://github.com/metabrainz/acousticbrainz-serv…

        • 2016-04-04 09527, 2016

      • alastairp
        oversight?

        • 2016-04-04 09548, 2016

      • Gentlecat
        probably. I updated the place where the error was happening

        • 2016-04-04 09530, 2016

      • Gentlecat
        might be useful to look into some way to track JS exceptions in the browser

        • 2016-04-04 09549, 2016

      • alastairp
        you know sentry can do it?

        • 2016-04-04 09511, 2016

      • alastairp
        though I don't really want to see 3000 error messages from react each time someone edits a dataset :)

        • 2016-04-04 09519, 2016

      • alastairp
        ok. I'll add the guards in

        • 2016-04-04 09511, 2016

      • Gentlecat
        if there are errors, they need to be fixed

        • 2016-04-04 09506, 2016

      • alastairp
        that's true too

        • 2016-04-04 09514, 2016

      • maShisma has quit

        • 2016-04-04 09552, 2016

      • maShisma joined the channel

        • 2016-04-04 09529, 2016

      • ruaok
        4-6 weeks is not likely going to happen for the "new setup" at hetzner.

        • 2016-04-04 09513, 2016

      • reosarevok
        ruaok: Jonathan Humphreys is all yours (we really should build a UI for others to be able to do this... maybe I can give that a go once I'm done with school)

        • 2016-04-04 09519, 2016

      • reosarevok biffs out

        • 2016-04-04 09523, 2016

      • alastairp
        ruaok: OK. no problem. I'll try database and redis, and see which is faster

        • 2016-04-04 09554, 2016

      • gcilou joined the channel

        • 2016-04-04 09504, 2016

      • bitmap
        Freso: yes, the link worksforme

        • 2016-04-04 09513, 2016

      • gcilou has quit

        • 2016-04-04 09513, 2016

      • gcilou joined the channel

        • 2016-04-04 09553, 2016

      • alastairp
        Gentlecat: what do you know about sharing react code? specifically that metadata get query - it's the same in both the viewer and the editor

        • 2016-04-04 09557, 2016

      • Gentlecat
        they are not shared because I was just embedding react on a page before

        • 2016-04-04 09555, 2016

      • alastairp
        ah. if you made the view and edit the same app it would be easier to share it?

        • 2016-04-04 09557, 2016

      • Gentlecat
        now that we have a build system, we might be able to extract common parts

        • 2016-04-04 09514, 2016

      • alastairp
        ah, right. that's what I was thinking

        • 2016-04-04 09523, 2016

      • Gentlecat
        they are not really the same

        • 2016-04-04 09533, 2016

      • alastairp
        yeah. I see there is different code

        • 2016-04-04 09535, 2016

      • Gentlecat
        I wanted to do it like that, but then realized that it would be a mess

        • 2016-04-04 09540, 2016

      • alastairp
        but the entire ajax query is the same

        • 2016-04-04 09540, 2016

      • alastairp
        kartikgupta0909: hi. are you around?

        • 2016-04-04 09556, 2016

      • alastairp
        oh. everyone in here will be pleased to know that the MBID deprecation story worried a number of people at MTG

        • 2016-04-04 09505, 2016

      • maShisma has quit

        • 2016-04-04 09533, 2016

      • maShisma joined the channel

        • 2016-04-04 09558, 2016

      • Leo_Verto
        :D

        • 2016-04-04 09524, 2016

      • ruaok
        alastairp: yay. glad to hear that the some people fell for the story. :)

        • 2016-04-04 09527, 2016

      • ruaok
        !m freso

        • 2016-04-04 09527, 2016

      • BrainzBot
        You're doing good work, freso!

        • 2016-04-04 09501, 2016

      • The_Catman joined the channel

        • 2016-04-04 09516, 2016

      • reosarevok
        Hah

        • 2016-04-04 09530, 2016

      • alastairp
        Gentlecat: https://github.com/metabrainz/acousticbrainz-serv…

        • 2016-04-04 09536, 2016

      • alastairp
        what's the story with debug messages

        • 2016-04-04 09551, 2016

      • alastairp
        1) delete them, 2) comment them, 3) remove them at compile time?

        • 2016-04-04 09557, 2016

      • kartikgupta0909
        alastairp: Yes

        • 2016-04-04 09514, 2016

      • alastairp kartikgupta0909: cool. I'm just taking a 5 minute break. Talk soon

        • 2016-04-04 09525, 2016

      • kartikgupta0909
        sure

        • 2016-04-04 09526, 2016

      • MBJenkins
        Project musicbrainz-server_beta build #832: ABORTED in 48 sec: http://ci.musicbrainz.org/job/musicbrainz-server_…

        • 2016-04-04 09527, 2016

      • MBJenkins
        * Michael Wiencek: Update translations from transifex.

        • 2016-04-04 09527, 2016

      • MBJenkins
        * Michael Wiencek: Update pot files using current code and production database.

        • 2016-04-04 09557, 2016

      • alastairp
        kartikgupta0909: We have 3 tickets which you could work on

        • 2016-04-04 09517, 2016

      • alastairp
        http://tickets.musicbrainz.org/browse/AB-63 (https://github.com/metabrainz/acousticbrainz-serv…)

        • 2016-04-04 09537, 2016

      • alastairp
        http://tickets.musicbrainz.org/browse/AB-87 and http://tickets.musicbrainz.org/browse/AB-96 (https://github.com/metabrainz/acousticbrainz-serv…)

        • 2016-04-04 09553, 2016

      • alastairp
        http://tickets.musicbrainz.org/browse/AB-66 (https://github.com/metabrainz/acousticbrainz-serv…)

        • 2016-04-04 09509, 2016

      • kartikgupta0909
        i wanted to work on #63, but seeing the pull request i backed off

        • 2016-04-04 09525, 2016

      • alastairp
        great. feel free to continue working on that pull request!

        • 2016-04-04 09535, 2016

      • kartikgupta0909
        sure

        • 2016-04-04 09546, 2016

      • alastairp
        it ties into #66 a bit too. We should also have a list of jobs in the admin interface

        • 2016-04-04 09558, 2016

      • alastairp
        but also give the admin users the ability to change the status of a job

        • 2016-04-04 09503, 2016

      • alastairp
        or delete jobs, or datasets

        • 2016-04-04 09555, 2016

      • alastairp
        does anyone have suggestions on how to let kartikgupta0909 keep working on an existing pull request, as it's on a branch on the ab repo

        • 2016-04-04 09514, 2016

      • kartikgupta0909
        for #63, we need the list of only running/pending right?

        • 2016-04-04 09552, 2016

      • alastairp
        we either merge what's there and let him make a new one, close what's there and make a new one, or add him as a collaborator to the project so he can commit directly

        • 2016-04-04 09508, 2016

      • alastairp
        ruaok: any thoughts? I'm not sure about collaborators

        • 2016-04-04 09525, 2016

      • kartikgupta0909
        alastairp: I would be comfortable by closing and making a new one.

        • 2016-04-04 09526, 2016

      • alastairp
        kartikgupta0909: one of the reasons I left it open was because I wanted to think about that

        • 2016-04-04 09543, 2016

      • alastairp
        the problem with closing it, is we lose the existing comments on the PR

        • 2016-04-04 09558, 2016

      • alastairp
        (although in this case there are not many)

        • 2016-04-04 09518, 2016

      • kartikgupta0909
        I can try and incorporating them directly in my work.

        • 2016-04-04 09520, 2016

      • ruaok
        my last boss had a good thought on this topic: Why are people so paranoid about adding contributors to version control systems?

        • 2016-04-04 09535, 2016

      • ruaok
        they are designed to have a digital trail and to be able to undo actions.

        • 2016-04-04 09546, 2016

      • alastairp
        kartikgupta0909: I think it would be nice to show all public datasets

        • 2016-04-04 09554, 2016

      • alastairp
        ruaok: right :)

        • 2016-04-04 09501, 2016

      • ruaok
        so, if someone screws up, you can undo it. but people tend to not screw up when you bestow trust on them.

        • 2016-04-04 09508, 2016

      • alastairp
        ok

        • 2016-04-04 09517, 2016

      • alastairp
        ruaok: please add kartikgupta0909 as a collaborator on the ab project

        • 2016-04-04 09542, 2016

      • alastairp
        (you shouldn't have spoken up. now you're making more work for yourself)

        • 2016-04-04 09504, 2016

      • kartikgupta0909
        alastairp: should they be ranked on the basis of the timestamp they were added to the evaluation cue?

        • 2016-04-04 09507, 2016

      • alastairp
        kartikgupta0909: I'm going to start adding some comments to the ticket

        • 2016-04-04 09512, 2016

      • alastairp
        let's have a discussion there

        • 2016-04-04 09515, 2016

      • kartikgupta0909
        like the latest ones on the top

        • 2016-04-04 09526, 2016

      • alastairp
        yeah, that's a good idea

        • 2016-04-04 09532, 2016

      • kartikgupta0909
        alastairp: sure

        • 2016-04-04 09521, 2016

      • ruaok
        invited.

        • 2016-04-04 09536, 2016

      • ruaok
        as a member. are collaborators part of the new team structure?

        • 2016-04-04 09540, 2016

      • alastairp
        I'd like to start leaving more of a papertrail in jira. we talk about a lot of AB stuff here in IRC, which means that it is easier to lose it

        • 2016-04-04 09502, 2016

      • alastairp
        yeah, with new team structure collaborators are attached directly to a repo, not to a team

        • 2016-04-04 09509, 2016

      • Leo_Verto
        you could link to chatlogs.meb.org on ticket comments

        • 2016-04-04 09520, 2016

      • Leo_Verto
        *in

        • 2016-04-04 09530, 2016

      • alastairp
        we use it now in MTG to add people from external companies/groups to a repository

        • 2016-04-04 09537, 2016

      • kartikgupta0909
        ruaok: I just had to click on join right?

        • 2016-04-04 09543, 2016

      • ruaok
        yep

        • 2016-04-04 09547, 2016

      • alastairp
        and we say that only people who are actively part of the MTG are part of the org

        • 2016-04-04 09548, 2016

      • kartikgupta0909
        done

        • 2016-04-04 09521, 2016

      • alastairp
        so I guess it becomes a question of policy to decide what "membership" means

        • 2016-04-04 09537, 2016

      • ruaok
        ok, kartikgupta0909 is now an outside collaborator.

        • 2016-04-04 09542, 2016

      • alastairp
        kartikgupta0909: so now you should be able to just continue pushing to that branch

        • 2016-04-04 09506, 2016

      • kartikgupta0909
        ruaok: can you explain me the workflow of contributing as a collaborator

        • 2016-04-04 09510, 2016

      • alastairp
        Leo_Verto: yes, of course. the current problem is that we don't comment on jira

        • 2016-04-04 09512, 2016

      • alastairp
        I want to change that

        • 2016-04-04 09516, 2016

      • ruaok
        I guess we need to make a policy about who is contributor and who is a member.

        • 2016-04-04 09530, 2016

      • kartikgupta0909
        can i merge using my current fork or do i need to do something else?

        • 2016-04-04 09538, 2016

      • ruaok
        kartikgupta0909: I doubt it is any different from what you're already doing with alastairp

        • 2016-04-04 09542, 2016

      • alastairp
        a good start may be to add chatlog links, although chat discuissions tend to be messy

        • 2016-04-04 09552, 2016

      • ruaok
        you need to keep alastairp happy, kartikgupta0909. :)

        • 2016-04-04 09501, 2016

      • alastairp
        kartikgupta0909: do you have outstanding branches in your fork?

        • 2016-04-04 09506, 2016

      • alastairp
        if no, I would just delete it

        • 2016-04-04 09521, 2016

      • kartikgupta0909
        ruaok: That I ll try my best

        • 2016-04-04 09539, 2016

      • alastairp
        and clone directly from the https or git url on the metabrainz version

        • 2016-04-04 09543, 2016

      • kartikgupta0909
        alastairp: Things werent working on my machine so I had to change a few files to make things work

        • 2016-04-04 09553, 2016

      • alastairp
        but did you commit those changes?

        • 2016-04-04 09504, 2016

      • kartikgupta0909
        no

        • 2016-04-04 09511, 2016

      • kartikgupta0909
        and they are not to be pushed

        • 2016-04-04 09511, 2016

      • alastairp
        you now have full write permission to the main acousticbrainz repository

        • 2016-04-04 09513, 2016

      • Gentlecat
        alastairp: https://github.com/metabrainz/acousticbrainz-serv… is done

        • 2016-04-04 09516, 2016

      • alastairp
        so you should just work in a branch

        • 2016-04-04 09528, 2016

      • alastairp
        Gentlecat: right. it's not reviewed yet, so not quite :)

        • 2016-04-04 09531, 2016

      • alastairp
        I'm on it right now

        • 2016-04-04 09546, 2016

      • alastairp
        kartikgupta0909: in fact, this should work then:

        • 2016-04-04 09550, 2016

      • Gentlecat
        I'm saying that was working on it

        • 2016-04-04 09505, 2016

      • alastairp
        git remote set-url origin git@github.com:metabrainz/acousticbrainz-server.git

        • 2016-04-04 09524, 2016

      • alastairp
        which means that when you push and pull, you use the metabrainz repository, not yours

        • 2016-04-04 09541, 2016

      • kartikgupta0909
        should I just do this in my current repo?

        • 2016-04-04 09543, 2016

      • alastairp
        Gentlecat: is it finished, ready for review?

        • 2016-04-04 09545, 2016

      • kartikgupta0909
        i dont need to clone again?

        • 2016-04-04 09552, 2016

      • alastairp
        kartikgupta0909: yes, no problem to use your current repo

        • 2016-04-04 09559, 2016

      • kartikgupta0909
        cool then

        • 2016-04-04 09503, 2016

      • alastairp
        git is cool

        • 2016-04-04 09507, 2016

      • Gentlecat
        yes, it's been ready for a month

        • 2016-04-04 09525, 2016

      • alastairp
        Gentlecat: great. which is why I'm reviewing it now

        • 2016-04-04 09559, 2016

      • kartikgupta0909
        alastairp: cool, so lets continue the discussion about the ticket #63 on github

        • 2016-04-04 09521, 2016

      • Gentlecat
        reosarevok: remember how you added me to some list in jira that sends me updates about all tickets?

        • 2016-04-04 09534, 2016

      • reosarevok
        You want out? :p

        • 2016-04-04 09507, 2016

      • Gentlecat
        yeah, it got hard to track ones that I'm interested in

        • 2016-04-04 09521, 2016

      • Gentlecat
        and "watching" doesn't do anything

        • 2016-04-04 09538, 2016

      • reosarevok
        Ok, on it

        • 2016-04-04 09520, 2016

      • reosarevok
        Should be done I think