#metabrainz

/

      • LordSputnik
        OK, so I think it would be good if for next week you aim to get the server set up (if it isn't already), update the schema for your new tables, document that, create the dummy code and put together a Gantt chart with as much detail as you can from what we've discussed today
      • 2016-05-21 14259, 2016

      • QuoraUK
        How would you like my work "submitted" so to speak?
      • 2016-05-21 14215, 2016

      • LordSputnik
        Then if you have any free time left over for GSoC work on badges :)
      • 2016-05-21 14217, 2016

      • LordSputnik
        Hmm
      • 2016-05-21 14223, 2016

      • QuoraUK
        yeah, will do :)
      • 2016-05-21 14240, 2016

      • LordSputnik
        So GitHub, definitely, I'm just wondering what sort of structure we should have
      • 2016-05-21 14254, 2016

      • QuoraUK
        yeah
      • 2016-05-21 14215, 2016

      • QuoraUK
        would a PR a day work or would you like them more/less regularly
      • 2016-05-21 14252, 2016

      • Leo_Verto
        Hmm, why not push directly to a branch?
      • 2016-05-21 14211, 2016

      • QuoraUK
        thats good too :)
      • 2016-05-21 14219, 2016

      • LordSputnik
        Leo_Verto: the problem is that then we're likely to get a lot of code to review at the end
      • 2016-05-21 14223, 2016

      • Leo_Verto
        a commit log with good commit names should work quite well for documentation
      • 2016-05-21 14247, 2016

      • QuoraUK
        im not incredibly familiar with contibuting to formal projects so im not sure what the procedure is :)
      • 2016-05-21 14256, 2016

      • Leo_Verto
        "formal" :P
      • 2016-05-21 14207, 2016

      • LordSputnik
        So here's what I'm thinking: we set up a branch in the site, data and SQL repositories for gamification. Then for each stage of the project, you create a new branch for the particular features you're working on
      • 2016-05-21 14225, 2016

      • LordSputnik
        Then at the end of the stage, we merge that branch into the gamification branch
      • 2016-05-21 14232, 2016

      • LordSputnik
        With a PR
      • 2016-05-21 14207, 2016

      • QuoraUK
        so where would my feature branches be? in my fork?
      • 2016-05-21 14216, 2016

      • LordSputnik
        That way we review the code for each stage as it goes in, and we'll only have to do a small amount of integration testing right at the end when we merge gamification into the master branch
      • 2016-05-21 14220, 2016

      • QuoraUK
        but thats good yeah
      • 2016-05-21 14232, 2016

      • LordSputnik
        QuoraUK: might as well have you working on the main repositories :)
      • 2016-05-21 14239, 2016

      • LordSputnik
        I'll add you to the team on GitHub
      • 2016-05-21 14242, 2016

      • QuoraUK
        ok cool :D
      • 2016-05-21 14250, 2016

      • Leo_Verto
        so basically a feature branch workflow https://www.atlassian.com/git/images/tutorials/co…
      • 2016-05-21 14231, 2016

      • QuoraUK
        yeah, that makes sense
      • 2016-05-21 14234, 2016

      • LordSputnik
        Yeah, kinda like that
      • 2016-05-21 14258, 2016

      • Leo_Verto
        maybe call the dev branch "gsoc-gamification"?
      • 2016-05-21 14259, 2016

      • LordSputnik
        As for commit messages and size of commits, aim to start with a short (80-120 characters), descriptive overview of what's in the commit, then if you need to, write a longer note on a new line
      • 2016-05-21 14248, 2016

      • QuoraUK
        yeah, can do
      • 2016-05-21 14250, 2016

      • LordSputnik
        For the size of commits, not too big - aim to make a small unit of related changes in one commit - you'll be able to get a better idea by looking at some of the recent stuff we've done on -site, I think
      • 2016-05-21 14218, 2016

      • LordSputnik
        A few small commits with clear purposes is better than one big commit with everything you've done it :D
      • 2016-05-21 14226, 2016

      • LordSputnik
        *in
      • 2016-05-21 14200, 2016

      • QuoraUK
        yeah, Im taking a look at them now, seems like a good way of doing it
      • 2016-05-21 14213, 2016

      • Leo_Verto
        And that's actually one of the few things we have as written documentation! https://github.com/bookbrainz/bookbrainz-site/blo… :D
      • 2016-05-21 14223, 2016

      • LordSputnik
        Hmm
      • 2016-05-21 14212, 2016

      • LordSputnik
        Well, I only loosely follow that :P
      • 2016-05-21 14252, 2016

      • LordSputnik
        OK, I've invited you to the GitHub organisation for BB
      • 2016-05-21 14205, 2016

      • LordSputnik
        I need to re-arrange the teams because they're outdated
      • 2016-05-21 14231, 2016

      • QuoraUK
        alright, done
      • 2016-05-21 14235, 2016

      • Leo_Verto
        By the way, since it's still meeting-oh-clock
      • 2016-05-21 14235, 2016

      • LordSputnik
        Anything else to discuss today? :)
      • 2016-05-21 14251, 2016

      • QuoraUK
        no, i think thats all. that was a good meeting :D
      • 2016-05-21 14258, 2016

      • Leo_Verto
        I've suddenly got lots of free time on my hands so I'm planning to get back into BB
      • 2016-05-21 14221, 2016

      • QuoraUK
        I'll try and be at the monday meeting, but my exam is the next day so i may be deep in the books
      • 2016-05-21 14232, 2016

      • Leo_Verto
        started by looking at my trello board and saw "Write initscripts and logrotate configs for all BB services" so I think I'll work on that first
      • 2016-05-21 14208, 2016

      • LordSputnik
        Leo_Verto: I did write scripts, but they need to be installed - I'll send them to you if you want to take over championing those
      • 2016-05-21 14218, 2016

      • LordSputnik
        QuoraUK: OK, if you're not, good luck :D
      • 2016-05-21 14226, 2016

      • Leo_Verto
        Sure
      • 2016-05-21 14227, 2016

      • QuoraUK
        cheers :D
      • 2016-05-21 14248, 2016

      • LordSputnik
        Leo_Verto: I think it's what's in the /services directory on sakura
      • 2016-05-21 14256, 2016

      • LordSputnik
        (err ~/services)
      • 2016-05-21 14257, 2016

      • Leo_Verto
        Okay
      • 2016-05-21 14244, 2016

      • Leo_Verto
        Yep, there's one for -site
      • 2016-05-21 14254, 2016

      • LordSputnik
        Leo_Verto: I'm not sure we need any others
      • 2016-05-21 14204, 2016

      • LordSputnik
        maybe elasticsearch
      • 2016-05-21 14211, 2016

      • LordSputnik
        PG and Redis should come up automatically
      • 2016-05-21 14236, 2016

      • Leo_Verto
        how's the ws started?
      • 2016-05-21 14245, 2016

      • LordSputnik
        ws is out of action until we rewrite it in Node
      • 2016-05-21 14255, 2016

      • Leo_Verto
        okay
      • 2016-05-21 14208, 2016

      • LordSputnik
        And then it'll likely be very similar to the site script
      • 2016-05-21 14215, 2016

      • Leo_Verto
        yeah
      • 2016-05-21 14245, 2016

      • LordSputnik
        If you want something else to do as well you could work on the new WS design or convert some Jade template to React (although, you're probably the person who least wants to do that!)
      • 2016-05-21 14255, 2016

      • Leo_Verto
        :P
      • 2016-05-21 14212, 2016

      • LordSputnik
        Or perhaps have a go at implementing the new entity editing mockup
      • 2016-05-21 14255, 2016

      • Leo_Verto
      • 2016-05-21 14234, 2016

      • LordSputnik
        Yup
      • 2016-05-21 14232, 2016

      • LordSputnik
        You'll probably want two react components and to toggle between them when the "preview/submit" button gets pushed, I'd think
      • 2016-05-21 14245, 2016

      • LordSputnik
        Have you done React stuff before?
      • 2016-05-21 14224, 2016

      • Leo_Verto
        Nope, but I think I can figure it out
      • 2016-05-21 14239, 2016

      • Leo_Verto
      • 2016-05-21 14247, 2016

      • LordSputnik
        </BANG>
      • 2016-05-21 14249, 2016

      • LordSputnik
        I think
      • 2016-05-21 14205, 2016

      • LordSputnik goes off to do revision
      • 2016-05-21 14234, 2016

      • mihaitish has quit
      • 2016-05-21 14212, 2016

      • rahulr
        bitmap: ping.
      • 2016-05-21 14224, 2016

      • bitmap
        pong. hi
      • 2016-05-21 14243, 2016

      • bitmap
        was just reading through your proposal again
      • 2016-05-21 14207, 2016

      • mihaitish joined the channel
      • 2016-05-21 14241, 2016

      • rahulr
        Hi :). Okay, and..?
      • 2016-05-21 14215, 2016

      • bitmap
        have you started implementing any of the new dialogs, or are you still at the 'learn more about pyqt' part?
      • 2016-05-21 14223, 2016

      • bitmap
        I was wondering something about the implementation
      • 2016-05-21 14235, 2016

      • rahulr
        I've started work on the "more tracks" dialog.
      • 2016-05-21 14252, 2016

      • rahulr
        I'm leaving the search box for now.
      • 2016-05-21 14256, 2016

      • rahulr
        A dialog box for after someone has performed a lookup, and then if want to see more tracks than the one automatically tagged.
      • 2016-05-21 14202, 2016

      • rahulr
        This is the "Track Search Dialog" that I've mentioned in the proposal. But without search for now. :)
      • 2016-05-21 14244, 2016

      • bitmap
        okay
      • 2016-05-21 14230, 2016

      • bitmap
        I was actually wondering if it'd make sense to embed the MBS search results in the dialog
      • 2016-05-21 14250, 2016

      • bitmap
        so you wouldn't need a 'lookup in browser' button, they'd be consistent with what's on the website
      • 2016-05-21 14213, 2016

      • rahulr
        Yes, I agree. We can remove browser dependency completely if these dialogs are good enough.
      • 2016-05-21 14244, 2016

      • bitmap
        I also meant embedding the existing HTML rather than writing a native UI
      • 2016-05-21 14206, 2016

      • bitmap
        it just seems a lot less complex to me
      • 2016-05-21 14258, 2016

      • bitmap
        would that be bad?
      • 2016-05-21 14230, 2016

      • rahulr
        Oh. I haven't thought of that. (Well, I don't even know if that's possible :D).
      • 2016-05-21 14209, 2016

      • bitmap
        well, I know you can have embedded HTML in Qt at least
      • 2016-05-21 14235, 2016

      • bitmap
        the existing results don't display things like cover art, but that can always be changed
      • 2016-05-21 14235, 2016

      • JesseW joined the channel
      • 2016-05-21 14245, 2016

      • bitmap
        you'd have to figure out how the tagger buttons would work, but maybe there's a way to listen to events from the outside
      • 2016-05-21 14214, 2016

      • bitmap
        might solve those buttons not working in some browsers, and mixed-content warnings
      • 2016-05-21 14255, 2016

      • rahulr
        Well, I need to look more into that before making any comments. Do you know of any application that does embed web like this?
      • 2016-05-21 14250, 2016

      • bitmap
        http://doc.qt.io/qt-4.8/examples-webkit.html are relevant examples, I think
      • 2016-05-21 14212, 2016

      • bitmap
        and sure, let me know what you think of this
      • 2016-05-21 14255, 2016

      • bitmap
        reusing what we have and not writing a bunch of new UI code just seems somewhat ideal
      • 2016-05-21 14237, 2016

      • kanha has quit
      • 2016-05-21 14239, 2016

      • rahulr
        Okay (it's making sense, slowly). I'll check more into this, make sure that it works accordingly before diving in.
      • 2016-05-21 14209, 2016

      • rahulr
        Maybe discuss more tomorrow?
      • 2016-05-21 14240, 2016

      • bitmap
        sure, I should be around tomorrow
      • 2016-05-21 14235, 2016

      • rahulr
        Cool. Apart from that, I was wondering do we use ui files for creating dialogs in Picard, or directly write qt code for them?
      • 2016-05-21 14254, 2016

      • bitmap
        if it works out, I guess you can have some of your schedule focus on making the MBS results look nicer and adding a parameter so that it only returns the table + pager buttons
      • 2016-05-21 14223, 2016

      • bitmap
        pretty sure we use .ui files for most things
      • 2016-05-21 14206, 2016

      • JesseW has quit
      • 2016-05-21 14221, 2016

      • bitmap
        there's some hand-written qt code, but only where the qt designer is too cumbersome or limited, I think
      • 2016-05-21 14227, 2016

      • opatel99 has quit
      • 2016-05-21 14214, 2016

      • rahulr
        Yeah. If it's not much difficult to implement, there will be quite some spare time left.
      • 2016-05-21 14245, 2016

      • Mineo has quit
      • 2016-05-21 14235, 2016

      • bitmap
        I do worry how big the webkit portion of qt is. doesn't really matter on linux, but not sure we include that on mac/windows
      • 2016-05-21 14202, 2016

      • rahulr
        bitmap: I'm not sure I understand. How big, in which context?
      • 2016-05-21 14251, 2016

      • rahulr
        Umm, and what's different with mac/windows?
      • 2016-05-21 14226, 2016

      • bitmap
        the size of the QtWebKit module, I mean
      • 2016-05-21 14203, 2016

      • bitmap
        picard on linux is going to be using shared libs in most cases
      • 2016-05-21 14233, 2016

      • bitmap
        so it might already be installed if there's another qt app on the system
      • 2016-05-21 14207, 2016

      • bitmap
        the mac/windows distributions have to bundle all these dependencies into a single package
      • 2016-05-21 14259, 2016

      • yeeeargh has quit
      • 2016-05-21 14239, 2016

      • mihaitish has quit
      • 2016-05-21 14230, 2016

      • kanha joined the channel
      • 2016-05-21 14204, 2016

      • JesseW joined the channel
      • 2016-05-21 14225, 2016

      • Mineo joined the channel
      • 2016-05-21 14251, 2016

      • mihaitish joined the channel
      • 2016-05-21 14233, 2016

      • JesseW has quit
      • 2016-05-21 14206, 2016

      • diana_olhovyk_ joined the channel
      • 2016-05-21 14210, 2016

      • CatQuest
        nice to see so much gsoc talk in here :D
      • 2016-05-21 14248, 2016

      • Leo_Verto has quit
      • 2016-05-21 14233, 2016

      • Slurpee has quit
      • 2016-05-21 14240, 2016

      • diana_olhovyk_ has quit
      • 2016-05-21 14224, 2016

      • Lotheric has quit
      • 2016-05-21 14221, 2016

      • Leo_Verto joined the channel
      • 2016-05-21 14229, 2016

      • kanha has quit
      • 2016-05-21 14219, 2016

      • ariscop joined the channel
      • 2016-05-21 14211, 2016

      • opatel99 joined the channel
      • 2016-05-21 14233, 2016

      • mihaitish has quit
      • 2016-05-21 14238, 2016

      • yeeeargh joined the channel
      • 2016-05-21 14202, 2016

      • Lotheric joined the channel
      • 2016-05-21 14203, 2016

      • regagain has quit
      • 2016-05-21 14220, 2016

      • JesseW joined the channel
      • 2016-05-21 14228, 2016

      • The_Freso joined the channel
      • 2016-05-21 14240, 2016

      • Freso has quit
      • 2016-05-21 14240, 2016

      • The_Freso is now known as Freso
      • 2016-05-21 14232, 2016

      • mildused joined the channel
      • 2016-05-21 14219, 2016

      • yeeeargh has quit
      • 2016-05-21 14235, 2016

      • The_Freso joined the channel
      • 2016-05-21 14229, 2016

      • Freso has quit