#metabrainz

Got a container running https://github.com/metabrainz/coverart_redirect successfully

where are the events on the timeline stored in the source code of MBS?

Mineo: Nowhere, they are data (rows in statistics.statistic_event).

Huh. No ruaok.

Freso[koume]: net-splitted at 8AM

Ah.

7 am our time.

so the process to get new events on the timeline is basically "write some sql and send it to barcelona with a bag of chocolate"?:)

“Make a PR adding a one-time script to admin/sql/updates”, I’d say. But they won’t refuse chocolate either, I guess.

Leftmost: QuoraUK: I'll be 15 minutes late for the meeting today

LordSputnik, alright.

LordSputnik: no problem

Leftmost: QuoraUK: ping

LordSputnik: Pong

Pong.

How are you both?

Not too bad, overall. Tired, though. Work is taking up all of my energy of late.

Alright, internet still busted >.<

cant move til tuesday now, I think i did jinx myself

Eek.

LordSputnik, how's it with you?

Pretty good, but busy. I finished of OAuth and then closes PRs pretty much

*closed

Including one of the gamification ones and a lot of dependency upgrades

\o/

Very nice.

rad :D

I'd like to close the OAuth PR by Monday evening - Leftmost, will you have had time to look at that point?

Yeah, I spaced it this week but I can get to it today.

Sorry about the delay on that.

OK that's fine :)

I'm going to close more PRs and then start implementing Selenium browser tests over the next few days

LordSputnik: Finally got events firing :D. it was the silly thing :P

Ahhh OK good

oh, I also pushed the migrations up

The missing client JS stuff?

the sql ones?

oh, yeah. that was it :P

Hmm. I'm not sure we should include the achievement type data in the migration

ok, I can move that somewhere else

However, we've never really done anything like this before (adding new types), so I don't really know the best way to do it

what do you recommend? A different migration file?

I think either way you'll end up reading SQL to load the data in, so I guess it might as well be included in the migration

But that raises the question - should the types also be included in the schema SQL? Or a similar SQL file used when setting up the database for the first time

It seems strange to include something in a migration but not in the initial setup

QuoraUK: also, you'll probably want to add lines to drop all the foreign keys to your down.sql script, I think

Ahh, ok. I did look into that, I assumed those were dropped as well

ill get on that shortly

I'm not 100% sure but I don't think deleting the tables will work for that

It seems like something that'd belong in initial setup, since it's data that could be present in a clean import.

OK, so perhaps we could make a new "create_type_data.sql" file in scripts/, and then add the achievement/title types to that along with all the other types in BB

or "create_initial_data.sql"

ok, would that script be called from anywhere in particular?

Nope, don't think so - it'd be up to users to call it manually if they need the initial data set up in the database

The alternative would be to import our official dump

alright, fair enough

(when it's publically available)

Once there's a docker script, we'll probably do something similar to what musicbrainz-docker does, and allow the user to specify whether to use dumps when setting up the container

if not, the initial data will get loaded in

that shounds like a good idea

On another note, my OAuth stuff introduces the "co" package to -site - I'm hoping eventually to convert more of our promise logic to use this

I'll start with the most complex stuff, because that's where we'll get the most benefit for readability and clarity of code

oh! I can probably make a move over to that as well

(https://github.com/tj/co)

That's the generator spawner?

since I actually understand promises now :)

Leftmost: Yeah, it wraps generators and results in a new function returning a promise

(Or executes the wrapped generator function immediately, returning a promise)

QuoraUK: will definitely help if you have any long .then/.catch chains

yeah, Ill give it a shot next week perhaps, I think my aim to get better with git worked :P

the --patch thing is great :D

alright, do we want to get onto the controvesial achievements?

Yeah, one thing I've noticed though is that your branches do seem to still sometimes combine unrelated features - try to avoid that

LordSputnik, nice. I'd looked at that briefly, but never tried it out.

yeah, Im working on multiple branches now

eg. the title hover thing and creation time achievements