where are the events on the timeline stored in the source code of MBS?
2016-07-02 18420, 2016
JonnyJD joined the channel
2016-07-02 18435, 2016
chirlu
Mineo: Nowhere, they are data (rows in statistics.statistic_event).
2016-07-02 18407, 2016
Freso[koume] joined the channel
2016-07-02 18425, 2016
Freso[koume]
Huh. No ruaok.
2016-07-02 18432, 2016
reosarevok
Freso[koume]: net-splitted at 8AM
2016-07-02 18403, 2016
Freso[koume]
Ah.
2016-07-02 18415, 2016
chirlu
7 am our time.
2016-07-02 18437, 2016
Freso[koume] has quit
2016-07-02 18427, 2016
FergusL joined the channel
2016-07-02 18434, 2016
chrisskye_ joined the channel
2016-07-02 18411, 2016
chrisskye_ has quit
2016-07-02 18429, 2016
kwikadi has quit
2016-07-02 18411, 2016
diana_olhovyk_ joined the channel
2016-07-02 18451, 2016
diana_olhovyk_ has quit
2016-07-02 18412, 2016
Mineo
so the process to get new events on the timeline is basically "write some sql and send it to barcelona with a bag of chocolate"?:)
2016-07-02 18446, 2016
chirlu
“Make a PR adding a one-time script to admin/sql/updates”, I’d say. But they won’t refuse chocolate either, I guess.
2016-07-02 18420, 2016
Hobbyboy joined the channel
2016-07-02 18448, 2016
Freso|koume joined the channel
2016-07-02 18400, 2016
colbydray joined the channel
2016-07-02 18405, 2016
chirlu joined the channel
2016-07-02 18400, 2016
JonnyJD has quit
2016-07-02 18418, 2016
djwhitey has quit
2016-07-02 18421, 2016
LordSputnik
Leftmost: QuoraUK: I'll be 15 minutes late for the meeting today
2016-07-02 18440, 2016
Leftmost
LordSputnik, alright.
2016-07-02 18400, 2016
QuoraUK
LordSputnik: no problem
2016-07-02 18445, 2016
LordSputnik
Leftmost: QuoraUK: ping
2016-07-02 18430, 2016
QuoraUK
LordSputnik: Pong
2016-07-02 18429, 2016
Leftmost
Pong.
2016-07-02 18417, 2016
LordSputnik
How are you both?
2016-07-02 18452, 2016
Leftmost
Not too bad, overall. Tired, though. Work is taking up all of my energy of late.
2016-07-02 18406, 2016
QuoraUK
Alright, internet still busted >.<
2016-07-02 18418, 2016
QuoraUK
cant move til tuesday now, I think i did jinx myself
2016-07-02 18435, 2016
Leftmost
Eek.
2016-07-02 18439, 2016
Leftmost
LordSputnik, how's it with you?
2016-07-02 18420, 2016
LordSputnik
Pretty good, but busy. I finished of OAuth and then closes PRs pretty much
2016-07-02 18424, 2016
LordSputnik
*closed
2016-07-02 18455, 2016
LordSputnik
Including one of the gamification ones and a lot of dependency upgrades
2016-07-02 18404, 2016
Freso|koume is here, too! :D
2016-07-02 18409, 2016
LordSputnik
\o/
2016-07-02 18411, 2016
Leftmost
Very nice.
2016-07-02 18416, 2016
QuoraUK
rad :D
2016-07-02 18451, 2016
LordSputnik
I'd like to close the OAuth PR by Monday evening - Leftmost, will you have had time to look at that point?
2016-07-02 18425, 2016
Leftmost
Yeah, I spaced it this week but I can get to it today.
2016-07-02 18459, 2016
Leftmost
Sorry about the delay on that.
2016-07-02 18437, 2016
LordSputnik
OK that's fine :)
2016-07-02 18410, 2016
LordSputnik
I'm going to close more PRs and then start implementing Selenium browser tests over the next few days
2016-07-02 18454, 2016
QuoraUK
LordSputnik: Finally got events firing :D. it was the silly thing :P
2016-07-02 18405, 2016
LordSputnik
Ahhh OK good
2016-07-02 18409, 2016
QuoraUK
oh, I also pushed the migrations up
2016-07-02 18414, 2016
LordSputnik
The missing client JS stuff?
2016-07-02 18437, 2016
Slurpee joined the channel
2016-07-02 18438, 2016
QuoraUK
the sql ones?
2016-07-02 18454, 2016
QuoraUK
oh, yeah. that was it :P
2016-07-02 18420, 2016
LordSputnik
Hmm. I'm not sure we should include the achievement type data in the migration
2016-07-02 18437, 2016
QuoraUK
ok, I can move that somewhere else
2016-07-02 18447, 2016
LordSputnik
However, we've never really done anything like this before (adding new types), so I don't really know the best way to do it
2016-07-02 18448, 2016
QuoraUK
what do you recommend? A different migration file?
2016-07-02 18454, 2016
CallerNo6 joined the channel
2016-07-02 18451, 2016
LordSputnik
I think either way you'll end up reading SQL to load the data in, so I guess it might as well be included in the migration
2016-07-02 18445, 2016
LordSputnik
But that raises the question - should the types also be included in the schema SQL? Or a similar SQL file used when setting up the database for the first time
2016-07-02 18459, 2016
LordSputnik
It seems strange to include something in a migration but not in the initial setup
2016-07-02 18428, 2016
LordSputnik
QuoraUK: also, you'll probably want to add lines to drop all the foreign keys to your down.sql script, I think
2016-07-02 18447, 2016
QuoraUK
Ahh, ok. I did look into that, I assumed those were dropped as well
2016-07-02 18453, 2016
QuoraUK
ill get on that shortly
2016-07-02 18454, 2016
LordSputnik
I'm not 100% sure but I don't think deleting the tables will work for that
2016-07-02 18458, 2016
Leftmost
It seems like something that'd belong in initial setup, since it's data that could be present in a clean import.
2016-07-02 18421, 2016
chirlu has quit
2016-07-02 18443, 2016
LordSputnik
OK, so perhaps we could make a new "create_type_data.sql" file in scripts/, and then add the achievement/title types to that along with all the other types in BB
2016-07-02 18453, 2016
LordSputnik
or "create_initial_data.sql"
2016-07-02 18430, 2016
QuoraUK
ok, would that script be called from anywhere in particular?
2016-07-02 18443, 2016
chirlu joined the channel
2016-07-02 18406, 2016
LordSputnik
Nope, don't think so - it'd be up to users to call it manually if they need the initial data set up in the database
2016-07-02 18414, 2016
LordSputnik
The alternative would be to import our official dump
2016-07-02 18419, 2016
QuoraUK
alright, fair enough
2016-07-02 18424, 2016
LordSputnik
(when it's publically available)
2016-07-02 18404, 2016
LordSputnik
Once there's a docker script, we'll probably do something similar to what musicbrainz-docker does, and allow the user to specify whether to use dumps when setting up the container
2016-07-02 18418, 2016
LordSputnik
if not, the initial data will get loaded in
2016-07-02 18429, 2016
QuoraUK
that shounds like a good idea
2016-07-02 18404, 2016
JesseW joined the channel
2016-07-02 18440, 2016
LordSputnik
On another note, my OAuth stuff introduces the "co" package to -site - I'm hoping eventually to convert more of our promise logic to use this
2016-07-02 18458, 2016
LordSputnik
I'll start with the most complex stuff, because that's where we'll get the most benefit for readability and clarity of code
2016-07-02 18411, 2016
QuoraUK
oh! I can probably make a move over to that as well
