#metabrainz

it's easy to create a fake output with these

right

sure.

we worried about that a little

It'd be interesting to actually take a look and see if we can find any obviously fake data

I can put anything inside `lowlevel`, let's say

in the end, we decided to be pretty trusting of what we accepted

anyway, I'll create a ticket

AB-137

Freso: Copyleft Games

is it normal that "Display Credits at Bottom" is forcibly enabled when switching the display language to French?

definitely not

it's what I'm seeing on my dev server

so could easily be an issue on my end

(it also results in " (nothing) : <artist>" for a performance AR without subtype/attribute)

works on beta (but that empty label is there though)

for 'recording of'?

no for a performer AR on a recording

" : Florence Wlelch (piste 3)"

seems to match with a "vocals: Florence Welch (track 3)" line in english

in Dutch it's also fine; could just be that there's no "vocals" msgid in the french PO file

yeah, I don't see one. should fall back to english though

looks like there's no "vocals" msgid anywhere

i do see them for "alto vocals" etc, but not for plain "vocals"

so maybe that's derived from somthing else?

or maybe it's from "{additional} {guest} {solo} {vocal} {vocal:|vocals}"

aha french has

msgstr "{vocal:chant} {vocal} {additional:supplémentairel} {guest:invité} {solo}"

the lacking | will be the culprit

that's the downside of using PO files but not "normal" substitutions - msgfmt doesn't know to complain about mismatches for those

also looks like that should be ...entaire} (no trailing l)

yeah, making it {vocal:|chant} fixes it

the other thing (no "display at bottom" clicky) is probably the same issue that prevents the language dropdown from showing when the language isn't set to english; might just be a plackup vs real server thing maybe

hmm, any errors in the JS console?

I also though {vocal} {vocal:|vocals} was equivalent to {vocal:%|vocals}

thought*

chirlu: I did get the UI item once I set up multiple langs in DBDefs and restarted plackup

js console has a few errors: Cannot find module 'jed-data', Cannot find module '16226aa',

ReferenceError: MB is not defined; TypeError: document.getElementById(...) is null

Did you (re-)run compile_resources?

probably not

doing so now

that did it :)

is there a coding style guideline for the terms used between {} in i18n strings? have set things up the way chirlu suggested (with the : again, but since it's translatable (and so are the comma-lists on either side) that can easily be made to look better in any given language)

currently have l('{attributes}: {instruments-and-vocals}', ...)

but if that needs to be underscored/shorter/whatever, that's fine by me

Using hyphens breaks the => notation, so I wouldn’t do that unless necessary.

nah, works fine when you quote the hash key

I call that breaking the notation. :-)

underscores it is

I’d probably just use “instruments”.

In the long run, the vocals are going to become instruments anyway.

if there's ever a pass on the db to split/normalize old ARs that still have multiple instruments/vocals, it would be {instrument} singular too :)

Depends on whether I get to finish MBS-7678 first.

only thing I still haven't quite figured out is how to access $MusicBrainz::Server::Constants::XXX from a template (or where to add code to export them)

You need to put them into the stash, from the controller.

zas: It seems OSUOSL’s FTP server has stopped synchronizing with data.mb.o.

so specifically for the artist controller? there's no easy way to just set it up so that every template can access mb_constants.MY_CONSTANT?

I spy an artist

In theory, you could probably put it into MB::S::View::Default. But generally, it’s the individual controller’s task to decide what to hand on to the view.

Maybe the right place to separate the attributes would be in MB::S::Entity::Role::Linkable::appearances?

Then the template wouldn’t need the constants at all.

hmm. i suppose that would also be the place to change the axis of the table so that the template would get relationships grouped by target entity type

so instead of [mix] followed by <recording> | additional, you'd have [recordings] followed by <recording> | additionally mixed, which would allow reusing the full i18n form

doesn't strictly require the axis change of course, but without it you're duplicating the section text in each line

have the constants exported now; diff is quite small this way, and low-impact so will add this change to the PR. If needed I can look at changing that appearances() method instead (I suppose it would just require adding another level of indirection to the returned hash)

I‘m not sure what you mean by “grouped by target entity type”, actually.

well, now the appearances are grouped by relationship type name (mix, performance, etc)

to then have the full textified relationship text where we currently have attributes would duplicate a lot of that

so instead, perhaps it would make sense to group them by source entity instead, so a section for works, releases etc; then the full localized relationship text duplicates nothing

but of course, it becomes harder to see all mix credits together, for example

and I have no real idea what specific uses people have for that page that relies on the current grouping

nor do i know whether that repetition (having "mixed" in the colum for all lines under the "mix" heading) is really a bad thing per se

But they already are sorted by target type.

Then relationship type, then time.

You can see that in http://tickets.musicbrainz.org/browse/MBS-7132

that link has just one section, "recorded at"

with my suggestion, it would have a "recordings" section and a "releases" section, for example. with the recorded at in the "description" column which would replace "attributes"

Yes, that’s the bug, that the separate sections aren’t actually visible.

well any ordering below phrase is not currently explicit in the code; that appearances() method just puts rels from an array into a hash by phrase

nor does the template explicitly group the lines

and what I meant was that that grouping by phrase would be _replaced_ by that per-entity grouping

for that ticket, it would have made the distinction clearer; on the other hand, it would not provide an easy chronological overview of "recorded at" relationships (they'd be interspersed with "mixed at" and the like), which may or may not be an issue

I'm not home this weekend, but I'll look at doing some reshuffling there in a separate branch next week to make it clearer what I mean

Project musicbrainz-server_master build #501: SUCCESS in 19 min: https://ci.metabrainz.org/job/musicbrainz-serve...

on a completely different note, with a significant number of dvd's already in the db, and a growing number of blurays (with companies like Square Enix releasing some game soundtracks exclusively on bluray), would it make sense to look at creating a discid variant for them?

I'd have to look at what SCSI READ STRUCTURE commands return, but I imagine that title/chapter/length information (plus possibly a count/type-list of audio channels) could be used similarly to the current toc addresses

would be for lookups only initially (which the average Picard user would probably appreciate); a given disc structure doesn't necessary have a fixed mapping to track count etc (e.g. when an album's 17 tracks contain stereo, instrumental and 5.1 mixes in 3 different channels) the way a cd toc does

Zastai: I would personally love to have something like that. If you try your hand at it, you may want to talk with the people from TheTVDb, TheMovieDb, the open movie db (or whatever it's called), etc. as they may want to use it too, and it'd be preferable if we all agreed on something. :)

Releasing soundtracks exclusively on Bluray? That seems like a good way to not sell it. Many laptops don't even have a disc drive much less Bluray.

o_O

Many laptops technically have no disk drive either, since SSDs technically contain no disk.

game soundtrack makes it slightly less bizarre, since gamers are more likely to have a PC with a bluray drive or a gaming console that can read blurays, but still

I didn't even know there was a standard for music on blurays