reosarevok sighs at an unexpected ISE http://tickets.musicbrainz.org/browse/MBS-9063 - I thought the dates would get dropped automatically here :/ I guess I can remove them with one edit then enter the other change, but I guess I'll leave it be for testing for now
Nyanko-sensei joined the channel
D4RK-PH0ENiX has quit
Mineo has quit
reosarevok
Also I wonder why suddenly almost 20 people decided to like our FB page, we normally get like one per day
(however, all of these are public, so that's back to the first point)
kartikgupta0909
but for private, only authors would know the job id right?
in case we allow public datasets to have jobs?
*private
alastairp
yeah. With UUIDs it's a bit less of a problem
since the probability of generating the same uuid is almost 0
kartikgupta0909
yes
so should I change something and add somekind of error handling or is it fine this way?
alastairp
for example, if we had integer ids for our job ids, we would want protection to make sure that no one iterated through the all ids
the reason that I was thinking about private datasets is this:
kartikgupta0909
yes that would have been a problem
alastairp
for now it's not a problem, but if we ever change this decision, we have to remember all the parts of the code which access datasets, and add this check
I can imagine that we perhaps forget all the places where this could happen, and so we end up with a bug
however, if we do it now, it doesn't matter if we make the change in the future
the downside is that we have additional complexity here, which will stay forever
hmm.
Gentlecat: got any thoughts on that?
Gentlecat
huh?
Gentlecat reads
ruaok
alastairp: got a sec?
kartikgupta0909
I dont see a problem even someone tries to access a job of a private dataset
since this API end point doesnt demand the dataset to be private
its simple retrieving the job from the dataset_eval_jobs table
Nyanko-sensei has quit
alastairp
right. I'm not talking about the case as it is at the moment
ruaok: what's up?
kartikgupta0909
ah
alastairp
because in this case we know that all jobs are for public datasets
D4RK-PH0ENiX joined the channel
Gentlecat
alastairp: I think I made a change to allow submission of private datasets because of challenges
ruaok
I'm not ready to put up a PR for the big-query stuff yet, but I wanted to catch you up.
Gentlecat
that might be in my own branch though
ruaok
its been an interesting set of challenges.
alastairp
Gentlecat: ah, interesting!
that makes my crazy ranting valid!
Gentlecat
so yeah, need to make sure that user owns the dataset before retrieving it
