16:13 PM
sampsyo has quit
2016-12-19 35449, 2016
16:14 PM
otringal joined the channel
2016-12-19 35455, 2016
16:14 PM
dpmittal joined the channel
2016-12-19 35419, 2016
16:18 PM
sampsyo joined the channel
2016-12-19 35402, 2016
16:23 PM
Freso|laptop
gcilou, you could go look and find out. :)
2016-12-19 35414, 2016
16:23 PM
samj1912
Leo_Verto: no idea what firehose is
2016-12-19 35402, 2016
16:24 PM
Leo_Verto
me neither, shouldn't matter either, that seems to be specific to that plugin
2016-12-19 35428, 2016
16:26 PM
gcilou
I can't find many. there are tons in memphis so Mr. Missing Mentor is better off :p
2016-12-19 35413, 2016
16:28 PM
samj1912
Leo_Verto: I dont think so
2016-12-19 35415, 2016
16:28 PM
samj1912
2016-12-19 35422, 2016
16:28 PM
samj1912
this is the base.py of botbot plugins
2016-12-19 35433, 2016
16:28 PM
Leo_Verto
hmm
2016-12-19 35400, 2016
16:29 PM
samj1912
what should I do to init it?
2016-12-19 35443, 2016
16:29 PM
Leo_Verto
why do you have to do that though?
2016-12-19 35459, 2016
16:29 PM
Leo_Verto
shouldn't running update_projects suffice?
2016-12-19 35420, 2016
16:36 PM
kyan has quit
2016-12-19 35431, 2016
16:36 PM
dpmittal
Hello everyone :D
2016-12-19 35438, 2016
16:36 PM
Leo_Verto
hey
2016-12-19 35423, 2016
16:37 PM
samj1912
Leo_Verto: yeah it will
2016-12-19 35447, 2016
16:37 PM
samj1912
but you will have to call it once
2016-12-19 35409, 2016
16:38 PM
lazka has quit
2016-12-19 35419, 2016
16:38 PM
lazka joined the channel
2016-12-19 35419, 2016
16:50 PM
Freso|laptop has quit
2016-12-19 35440, 2016
16:55 PM
Leo_Verto
samj1912, I mean, just call it somewhere in the class, why shouldn't that work?
2016-12-19 35454, 2016
16:56 PM
samj1912
hmm let me try
2016-12-19 35401, 2016
16:57 PM
samj1912
writing tests for now
2016-12-19 35415, 2016
16:58 PM
samj1912
Leo_Verto: can you try now once if the plugin goes into infinite recursion?
2016-12-19 35431, 2016
16:58 PM
Leo_Verto
sure
2016-12-19 35457, 2016
16:58 PM
samj1912
added a config field
2016-12-19 35413, 2016
17:01 PM
Leo_Verto
"MissingSchema: Invalid URL u'rest/api/2/issue/MEB-68': No schema supplied"
2016-12-19 35442, 2016
17:01 PM
Leo_Verto
it apparently correctly looked up the projects though
2016-12-19 35403, 2016
17:06 PM
samj1912
2016-12-19 35408, 2016
17:06 PM
samj1912
working for me?
2016-12-19 35424, 2016
17:06 PM
samj1912
you have correctly setup the config fields?
2016-12-19 35406, 2016
17:07 PM
samj1912
using the last commit right?
2016-12-19 35418, 2016
17:07 PM
Leo_Verto
ah, forgot the bot name
2016-12-19 35430, 2016
17:07 PM
Leo_Verto
you should be able to get that automatically somehow
2016-12-19 35438, 2016
17:07 PM
samj1912
I know
2016-12-19 35442, 2016
17:07 PM
samj1912
couldnt find it in the documentation
2016-12-19 35446, 2016
17:07 PM
Leo_Verto
heh
2016-12-19 35445, 2016
17:08 PM
Leo_Verto
yeah, it isn't the best
2016-12-19 35408, 2016
17:09 PM
anshuman73
Gentlecat: I tried again to do the oauth for the API and this time I got an internal server error, but no error message
2016-12-19 35455, 2016
17:09 PM
Leo_Verto
still getting the error
2016-12-19 35419, 2016
17:10 PM
Leo_Verto
ah
2016-12-19 35429, 2016
17:10 PM
Leo_Verto
my bad
2016-12-19 35446, 2016
17:10 PM
samj1912
You haven't set the jira URL?
2016-12-19 35456, 2016
17:10 PM
Leo_Verto
I was still setting jira_link instead of jira_url :P
2016-12-19 35456, 2016
17:11 PM
samj1912
Aah :p
2016-12-19 35457, 2016
17:11 PM
Leo_Verto
yep, no loop anymore :D
2016-12-19 35425, 2016
17:12 PM
samj1912
Cool :p
2016-12-19 35420, 2016
17:13 PM
anshuman73
Gentlecat: made it work, but another error came up - "'CritiqueBrainzAuthorizationProvider' object has no attribute 'token_length'"
2016-12-19 35430, 2016
17:13 PM
samj1912
The Botbot guys should have made it so that the bot doesn't parse itself
2016-12-19 35445, 2016
17:13 PM
Leo_Verto
mhm, that's a pretty big oversight
2016-12-19 35403, 2016
17:14 PM
Leo_Verto
they might solve it if you open an issue
2016-12-19 35423, 2016
17:14 PM
Leo_Verto
but their plugin API is pretty limited
2016-12-19 35432, 2016
17:15 PM
dpmittal has quit
2016-12-19 35451, 2016
17:15 PM
Leo_Verto
the plugin doesn't automatically pull the project list, does it?
2016-12-19 35427, 2016
17:16 PM
Leo_Verto
apparently that persists over restarts
2016-12-19 35407, 2016
17:24 PM
Leo_Verto
so we could probably get away with not refreshing it every time the bot restarts :D
2016-12-19 35405, 2016
17:26 PM
Leo_Verto
samj1912, other than the tests that's it, isn't it?
2016-12-19 35415, 2016
17:26 PM
Gentlecat
ruaok: login should work now
2016-12-19 35429, 2016
17:27 PM
ruaok
thanks. what happened?
2016-12-19 35457, 2016
17:34 PM
Gentlecat
there's one issue with OAuth that was missed
2016-12-19 35429, 2016
17:35 PM
Gentlecat
I'll fix it today and push an update
2016-12-19 35444, 2016
17:35 PM
otringal
why can you only see the "system dashboard" on the bug tracker if you're logged in?
2016-12-19 35441, 2016
17:36 PM
Gentlecat
anshuman73: I'll look at it later
2016-12-19 35421, 2016
17:37 PM
anshuman73
alright. I have the documentation ready for all the endpoints that do not require oauth. Should I open a PR ?
2016-12-19 35408, 2016
17:38 PM
Gentlecat
reosarevok: move review to another RG? no.
2016-12-19 35437, 2016
17:38 PM
Gentlecat
will probably be useful to have an option for moderators
2016-12-19 35437, 2016
17:38 PM
anshuman73
2016-12-19 35405, 2016
17:39 PM
samj1912
Leo_Verto: yes :D
2016-12-19 35421, 2016
17:39 PM
samj1912
Travelling, so intermittent Internet
2016-12-19 35437, 2016
17:40 PM
Leo_Verto
okay
2016-12-19 35417, 2016
17:41 PM
Leo_Verto
otringal, well, what do you expect to see? :P you can find individual issues via the projects or issues tabs
2016-12-19 35456, 2016
17:41 PM
samj1912
Will you be deploying it now or after I write the tests?
2016-12-19 35455, 2016
17:42 PM
Leo_Verto
yep
2016-12-19 35418, 2016
17:43 PM
Leo_Verto
after it's merged
2016-12-19 35441, 2016
17:43 PM
otringal
You could see the list of recent changes on the old bug tracker even if you were not logged in.
2016-12-19 35407, 2016
17:44 PM
Leo_Verto
ah
2016-12-19 35457, 2016
17:44 PM
Leo_Verto
samj1912, just fund another problem, it should probably stay silent if it can't find the issue but returns the error message instead
2016-12-19 35458, 2016
17:44 PM
reosarevok
Gentlecat: yeah - those are mis-assigned BBC ones from the time we tried and failed to assign classical reviews automatically
2016-12-19 35436, 2016
17:45 PM
Gentlecat
there are also some with removed RGs
2016-12-19 35423, 2016
17:46 PM
Gentlecat
and there's no way for an author or moderator to move those too
2016-12-19 35426, 2016
17:46 PM
Leo_Verto
otringal, that's true
2016-12-19 35443, 2016
17:47 PM
chirlu
Yeah, it got noticed, but since most people are logged in, it didn’t get any priority.
2016-12-19 35425, 2016
17:52 PM
Gentlecat
anshuman73: sure, open a pull request
2016-12-19 35450, 2016
17:52 PM
anshuman73
alright :)
2016-12-19 35426, 2016
17:55 PM
chirlu
Freso or Gentlecat: “go to Administration > System > User Interface > System Dashboard. From here you can customize the system dashboard which is shown to users before they log in.”
2016-12-19 35413, 2016
17:56 PM
chirlu
BTW, it seems there is a global setting “Use gzip compression” that is off by default. Should be turned on in that case; JIRA pages are huuuuuge.
2016-12-19 35429, 2016
17:59 PM
github joined the channel
2016-12-19 35429, 2016
17:59 PM
github
2016-12-19 35429, 2016
17:59 PM
github has left the channel
2016-12-19 35405, 2016
18:01 PM
samj1912
Leo_Verto: added it on purpose :p
2016-12-19 35413, 2016
18:01 PM
samj1912
Wait I'll remove it
2016-12-19 35425, 2016
18:09 PM
samj1912
removed :)
2016-12-19 35436, 2016
18:09 PM
Gentlecat
2016-12-19 35450, 2016
18:09 PM
Gentlecat
(for nginx config)
2016-12-19 35415, 2016
18:11 PM
github joined the channel
2016-12-19 35415, 2016
18:11 PM
github
[critiquebrainz] gentlecat closed pull request #69: Frontend footer API link fix (master...frontend_footer_fix)
https://git.io/v157V
2016-12-19 35415, 2016
18:11 PM
github has left the channel
2016-12-19 35405, 2016
18:24 PM
chirlu
Gentlecat: Yes, should be fine. In that case (i.e. when nginx does the gzipping), JIRA can of course have it deactivated.
2016-12-19 35406, 2016
18:25 PM
Gentlecat
yeah, I think it's deactivated by default
2016-12-19 35413, 2016
18:25 PM
Leo_Verto
gzip twice for double the compression! :D
2016-12-19 35435, 2016
18:28 PM
Gentlecat
chirlu: see if it works as expected now
2016-12-19 35413, 2016
18:29 PM
chirlu has quit
2016-12-19 35446, 2016
18:29 PM
chirlu joined the channel
2016-12-19 35436, 2016
18:38 PM
chirlu
Gentlecat: It seems JIRA sends JS as “application/javascript”. So that type would need adding to the list.
2016-12-19 35445, 2016
18:38 PM
chirlu
HTML is compressed, as far as I can see.
2016-12-19 35416, 2016
18:39 PM
Gentlecat
added
2016-12-19 35419, 2016
18:40 PM
samj1912
Leo_Verto: Added tests too :)
2016-12-19 35428, 2016
18:40 PM
chirlu
Wow, loading the JIRA homepage requires around 250 requests …
2016-12-19 35437, 2016
18:40 PM
Leo_Verto
:D
2016-12-19 35438, 2016
18:42 PM
samj1912
Leo_Verto: is it working fine now?
2016-12-19 35453, 2016
18:42 PM
chirlu
But most of them seem to be compressed now.
2016-12-19 35415, 2016
18:43 PM
chirlu
Gentlecat: Regarding the activity stream on the start page for logged-out users?
2016-12-19 35416, 2016
18:43 PM
Leo_Verto
samj1912, nice job, even dummying the web stuff!
2016-12-19 35431, 2016
18:43 PM
samj1912
hehe :D
2016-12-19 35453, 2016
18:43 PM
Gentlecat
yeah, I've been looking at it
2016-12-19 35418, 2016
18:44 PM
samj1912
there was no retrieve method in dummy app otherwise a better assert would have been to check the stored projects list :P
2016-12-19 35427, 2016
18:46 PM
Gentlecat
2016-12-19 35452, 2016
18:46 PM
Leo_Verto
samj1912, merged, thank you!
2016-12-19 35408, 2016
18:48 PM
samj1912
Leo_Verto: yo B), was a fun little experiment :D
2016-12-19 35404, 2016
18:49 PM
samj1912
so is it online in here?
2016-12-19 35429, 2016
18:49 PM
samj1912
BrainzBot: UPDATE:JIRA
2016-12-19 35440, 2016
18:49 PM
Leo_Verto
will be in a minute
2016-12-19 35457, 2016
18:49 PM
samj1912
cool :D
2016-12-19 35415, 2016
18:53 PM
samj1912
BrainzBot: seen Mineo?
2016-12-19 35438, 2016
18:53 PM
Leo_Verto
that's not enabled for this channel :P
2016-12-19 35443, 2016
18:53 PM
samj1912
aah :P
2016-12-19 35448, 2016
18:53 PM
samj1912
which all plugins are?
2016-12-19 35413, 2016
18:54 PM
samj1912
!m Leo_Verto
2016-12-19 35413, 2016
18:54 PM
BrainzBot
You're doing good work, Leo_Verto!
2016-12-19 35446, 2016
18:55 PM
Leo_Verto
zas, cam you create an account on nomo for me? for some reason I've always had to log in as botbotme
2016-12-19 35439, 2016
19:00 PM
samj1912
meeting in an hour right? can anyone participate? :P
2016-12-19 35439, 2016
19:03 PM
chirlu
Gentlecat: Is the system dashboard marked public? (Under “manage dashboards”.)
2016-12-19 35425, 2016
19:04 PM
chirlu
Hmm, it seems it is.
2016-12-19 35428, 2016
19:04 PM
chirlu
So that wasn’t it.
2016-12-19 35446, 2016
19:09 PM
chirlu
Gentlecat: Does the group “Anyone” have permission “Browse Project”?
2016-12-19 35410, 2016
19:13 PM
demonimin has quit
2016-12-19 35402, 2016
19:14 PM
demonimin joined the channel
2016-12-19 35402, 2016
19:14 PM
demonimin has quit
2016-12-19 35402, 2016
19:14 PM
demonimin joined the channel
2016-12-19 35412, 2016
19:25 PM
lazka has quit
2016-12-19 35412, 2016
19:27 PM
samj1912
BrainzBot: UPDATE:JIRA
2016-12-19 35446, 2016
19:30 PM
Leo_Verto
samj1912, unfortunately I
2016-12-19 35454, 2016
19:30 PM
Leo_Verto
can't restart the bot :/
2016-12-19 35456, 2016
19:30 PM
bitmap
2016-12-19 35432, 2016
19:31 PM
Freso|laptop joined the channel
2016-12-19 35427, 2016
19:32 PM
samj1912
ah, who can? :P
2016-12-19 35432, 2016
19:34 PM
bitmap
maybe it just hides stuff that have been 0 for a while, but that's a bit confusing if so
