16:13 PM
sampsyo has quit
16:14 PM
otringal joined the channel
16:14 PM
dpmittal joined the channel
16:18 PM
sampsyo joined the channel
16:23 PM
Freso|laptop
gcilou, you could go look and find out. :)
16:23 PM
samj1912
Leo_Verto: no idea what firehose is
16:24 PM
Leo_Verto
me neither, shouldn't matter either, that seems to be specific to that plugin
16:26 PM
gcilou
I can't find many. there are tons in memphis so Mr. Missing Mentor is better off :p
16:28 PM
samj1912
Leo_Verto: I dont think so
16:28 PM
16:28 PM
this is the base.py of botbot plugins
16:28 PM
Leo_Verto
hmm
16:29 PM
samj1912
what should I do to init it?
16:29 PM
Leo_Verto
why do you have to do that though?
16:29 PM
shouldn't running update_projects suffice?
16:36 PM
kyan has quit
16:36 PM
dpmittal
Hello everyone :D
16:36 PM
Leo_Verto
hey
16:37 PM
samj1912
Leo_Verto: yeah it will
16:37 PM
but you will have to call it once
16:38 PM
lazka has quit
16:38 PM
lazka joined the channel
16:50 PM
Freso|laptop has quit
16:55 PM
Leo_Verto
samj1912, I mean, just call it somewhere in the class, why shouldn't that work?
16:56 PM
samj1912
hmm let me try
16:57 PM
writing tests for now
16:58 PM
Leo_Verto: can you try now once if the plugin goes into infinite recursion?
16:58 PM
Leo_Verto
sure
16:58 PM
samj1912
added a config field
17:01 PM
Leo_Verto
"MissingSchema: Invalid URL u'rest/api/2/issue/MEB-68': No schema supplied"
17:01 PM
it apparently correctly looked up the projects though
17:06 PM
samj1912
17:06 PM
working for me?
17:06 PM
you have correctly setup the config fields?
17:07 PM
using the last commit right?
17:07 PM
Leo_Verto
ah, forgot the bot name
17:07 PM
you should be able to get that automatically somehow
17:07 PM
samj1912
I know
17:07 PM
couldnt find it in the documentation
17:07 PM
Leo_Verto
heh
17:08 PM
yeah, it isn't the best
17:09 PM
anshuman73
Gentlecat: I tried again to do the oauth for the API and this time I got an internal server error, but no error message
17:09 PM
Leo_Verto
still getting the error
17:10 PM
ah
17:10 PM
my bad
17:10 PM
samj1912
You haven't set the jira URL?
17:10 PM
Leo_Verto
I was still setting jira_link instead of jira_url :P
17:11 PM
samj1912
Aah :p
17:11 PM
Leo_Verto
yep, no loop anymore :D
17:12 PM
samj1912
Cool :p
17:13 PM
anshuman73
Gentlecat: made it work, but another error came up - "'CritiqueBrainzAuthorizationProvider' object has no attribute 'token_length'"
17:13 PM
samj1912
The Botbot guys should have made it so that the bot doesn't parse itself
17:13 PM
Leo_Verto
mhm, that's a pretty big oversight
17:14 PM
they might solve it if you open an issue
17:14 PM
but their plugin API is pretty limited
17:15 PM
dpmittal has quit
17:15 PM
the plugin doesn't automatically pull the project list, does it?
17:16 PM
apparently that persists over restarts
17:24 PM
so we could probably get away with not refreshing it every time the bot restarts :D
17:26 PM
samj1912, other than the tests that's it, isn't it?
17:26 PM
Gentlecat
ruaok: login should work now
17:27 PM
ruaok
thanks. what happened?
17:34 PM
Gentlecat
there's one issue with OAuth that was missed
17:35 PM
I'll fix it today and push an update
17:35 PM
otringal
why can you only see the "system dashboard" on the bug tracker if you're logged in?
17:36 PM
Gentlecat
anshuman73: I'll look at it later
17:37 PM
anshuman73
alright. I have the documentation ready for all the endpoints that do not require oauth. Should I open a PR ?
17:38 PM
Gentlecat
reosarevok: move review to another RG? no.
17:38 PM
will probably be useful to have an option for moderators
17:38 PM
anshuman73
17:39 PM
samj1912
Leo_Verto: yes :D
17:39 PM
Travelling, so intermittent Internet
17:40 PM
Leo_Verto
okay
17:41 PM
otringal, well, what do you expect to see? :P you can find individual issues via the projects or issues tabs
17:41 PM
samj1912
Will you be deploying it now or after I write the tests?
17:42 PM
Leo_Verto
yep
17:43 PM
after it's merged
17:43 PM
otringal
You could see the list of recent changes on the old bug tracker even if you were not logged in.
17:44 PM
Leo_Verto
ah
17:44 PM
samj1912, just fund another problem, it should probably stay silent if it can't find the issue but returns the error message instead
17:44 PM
reosarevok
Gentlecat: yeah - those are mis-assigned BBC ones from the time we tried and failed to assign classical reviews automatically
17:45 PM
Gentlecat
there are also some with removed RGs
17:46 PM
and there's no way for an author or moderator to move those too
17:46 PM
Leo_Verto
otringal, that's true
17:47 PM
chirlu
Yeah, it got noticed, but since most people are logged in, it didn’t get any priority.
17:52 PM
Gentlecat
anshuman73: sure, open a pull request
17:52 PM
anshuman73
alright :)
17:55 PM
chirlu
Freso or Gentlecat: “go to Administration > System > User Interface > System Dashboard. From here you can customize the system dashboard which is shown to users before they log in.”
17:56 PM
BTW, it seems there is a global setting “Use gzip compression” that is off by default. Should be turned on in that case; JIRA pages are huuuuuge.
17:59 PM
github joined the channel
17:59 PM
github
17:59 PM
github has left the channel
18:01 PM
samj1912
Leo_Verto: added it on purpose :p
18:01 PM
Wait I'll remove it
18:09 PM
removed :)
18:09 PM
Gentlecat
18:09 PM
(for nginx config)
18:11 PM
github joined the channel
18:11 PM
github
[critiquebrainz] gentlecat closed pull request #69: Frontend footer API link fix (master...frontend_footer_fix)
https://git.io/v157V
18:11 PM
github has left the channel
18:24 PM
chirlu
Gentlecat: Yes, should be fine. In that case (i.e. when nginx does the gzipping), JIRA can of course have it deactivated.
18:25 PM
Gentlecat
yeah, I think it's deactivated by default
18:25 PM
Leo_Verto
gzip twice for double the compression! :D
18:28 PM
Gentlecat
chirlu: see if it works as expected now
18:29 PM
chirlu has quit
18:29 PM
chirlu joined the channel
18:38 PM
chirlu
Gentlecat: It seems JIRA sends JS as “application/javascript”. So that type would need adding to the list.
18:38 PM
HTML is compressed, as far as I can see.
18:39 PM
Gentlecat
added
18:40 PM
samj1912
Leo_Verto: Added tests too :)
18:40 PM
chirlu
Wow, loading the JIRA homepage requires around 250 requests …
18:40 PM
Leo_Verto
:D
18:42 PM
samj1912
Leo_Verto: is it working fine now?
18:42 PM
chirlu
But most of them seem to be compressed now.
18:43 PM
Gentlecat: Regarding the activity stream on the start page for logged-out users?
18:43 PM
Leo_Verto
samj1912, nice job, even dummying the web stuff!
18:43 PM
samj1912
hehe :D
18:43 PM
Gentlecat
yeah, I've been looking at it
18:44 PM
samj1912
there was no retrieve method in dummy app otherwise a better assert would have been to check the stored projects list :P
18:46 PM
Gentlecat
18:46 PM
Leo_Verto
samj1912, merged, thank you!
18:48 PM
samj1912
Leo_Verto: yo B), was a fun little experiment :D
18:49 PM
so is it online in here?
18:49 PM
BrainzBot: UPDATE:JIRA
18:49 PM
Leo_Verto
will be in a minute
18:49 PM
samj1912
cool :D
18:53 PM
BrainzBot: seen Mineo?
18:53 PM
Leo_Verto
that's not enabled for this channel :P
18:53 PM
samj1912
aah :P
18:53 PM
which all plugins are?
18:54 PM
!m Leo_Verto
18:54 PM
BrainzBot
You're doing good work, Leo_Verto!
18:55 PM
Leo_Verto
zas, cam you create an account on nomo for me? for some reason I've always had to log in as botbotme
19:00 PM
samj1912
meeting in an hour right? can anyone participate? :P
19:03 PM
chirlu
Gentlecat: Is the system dashboard marked public? (Under “manage dashboards”.)
19:04 PM
Hmm, it seems it is.
19:04 PM
So that wasn’t it.
19:09 PM
Gentlecat: Does the group “Anyone” have permission “Browse Project”?
19:13 PM
demonimin has quit
19:14 PM
demonimin joined the channel
19:14 PM
demonimin has quit
19:14 PM
demonimin joined the channel
19:25 PM
lazka has quit
19:27 PM
samj1912
BrainzBot: UPDATE:JIRA
19:30 PM
Leo_Verto
samj1912, unfortunately I
19:30 PM
can't restart the bot :/
19:30 PM
bitmap
19:31 PM
Freso|laptop joined the channel
19:32 PM
samj1912
ah, who can? :P
19:34 PM
bitmap
maybe it just hides stuff that have been 0 for a while, but that's a bit confusing if so