21:41 PM
tigranl
Hi!
2017-01-10 01003, 2017
21:42 PM
samj1912
we can set some documentation standards for picard
2017-01-10 01015, 2017
21:42 PM
zas
yes, we'll do, but for 2.0
2017-01-10 01044, 2017
21:42 PM
zas
for now, let's focus on releasing ... ;)
2017-01-10 01006, 2017
21:43 PM
samj1912
hehe yes :P
2017-01-10 01001, 2017
21:44 PM
samj1912
I personally like the google python style guide above PEP-257 for doc strings
2017-01-10 01009, 2017
21:44 PM
tigranl
Gentlecat: please, have a look at my explanation on your comment about missing_users.
2017-01-10 01024, 2017
21:44 PM
samj1912
produces much more readable code than rst
2017-01-10 01031, 2017
21:45 PM
Gentlecat
tigranl: I will when I have time
2017-01-10 01059, 2017
21:45 PM
Gentlecat
already spending on reviewing much more than I should
2017-01-10 01017, 2017
21:48 PM
colbydray joined the channel
2017-01-10 01014, 2017
21:50 PM
samj1912
2017-01-10 01027, 2017
21:50 PM
github joined the channel
2017-01-10 01027, 2017
21:50 PM
github
[picard] zas closed pull request #533: PICARD-226: Add option for auto-clustering new files (master...picard226)
https://git.io/vMCul
2017-01-10 01027, 2017
21:50 PM
github has left the channel
2017-01-10 01047, 2017
21:50 PM
agentsim joined the channel
2017-01-10 01034, 2017
21:51 PM
samj1912
zas wasnt done with PICARD-226 yet :P
2017-01-10 01034, 2017
21:51 PM
github joined the channel
2017-01-10 01034, 2017
21:51 PM
BrainzBot
2017-01-10 01035, 2017
21:51 PM
github
[picard] zas closed pull request #541: Remove unsupported totaltracks metadata code (master...patch-3)
https://git.io/vMRJr
2017-01-10 01035, 2017
21:51 PM
github has left the channel
2017-01-10 01000, 2017
21:52 PM
samj1912
it has a few bugs
2017-01-10 01011, 2017
21:53 PM
94KAADFJS joined the channel
2017-01-10 01012, 2017
21:53 PM
94KAADFJS
metabrainz/picard#1711 (master - a8204fc : Laurent Monin): The build passed.
2017-01-10 01012, 2017
21:53 PM
94KAADFJS
2017-01-10 01012, 2017
21:53 PM
94KAADFJS
2017-01-10 01012, 2017
21:53 PM
94KAADFJS has left the channel
2017-01-10 01028, 2017
21:53 PM
samj1912
and I am not sure if my implementation is the best one
2017-01-10 01041, 2017
21:53 PM
zas
want me to revert ?
2017-01-10 01043, 2017
21:53 PM
bitmap
hm, it's wrong that jira considers 'in code review' as resolved, but 'in beta testing' as unresolved
2017-01-10 01056, 2017
21:53 PM
bitmap
idk how to fix that
2017-01-10 01019, 2017
21:54 PM
samj1912
zas Yes, I think I would like some opinion on my latest code :P
2017-01-10 01024, 2017
21:54 PM
samj1912
I am not satisfied with that one
2017-01-10 01041, 2017
21:54 PM
zas
samj1912: i tested it, and it seems to work, even though the UI is blinking a bit (because it moves files to Unmatched quickly)
2017-01-10 01051, 2017
21:54 PM
mihaitish joined the channel
2017-01-10 01031, 2017
21:55 PM
zas
samj1912: if you think you can improve it in next days no need to revert for now, it is off by default
2017-01-10 01045, 2017
21:55 PM
samj1912
okay :)
2017-01-10 01059, 2017
21:55 PM
chirlu
Yippee, build fixed!
2017-01-10 01017, 2017
21:56 PM
bitmap
2017-01-10 01036, 2017
21:56 PM
samj1912
2017-01-10 01000, 2017
21:57 PM
bitmap
review submitted is done, but in beta testing is in progress
2017-01-10 01027, 2017
21:57 PM
zas
samj1912: i'll merge them once Mineo will approve changes
2017-01-10 01059, 2017
21:57 PM
samj1912
okay :)
2017-01-10 01048, 2017
21:58 PM
samj1912
I have PICARD-860 left to code from scratch again and PICARD-880
2017-01-10 01049, 2017
21:58 PM
BrainzBot
2017-01-10 01049, 2017
21:58 PM
BrainzBot
2017-01-10 01046, 2017
21:59 PM
samj1912
zas I pinged rahulr about PR-474, no reply from his side
2017-01-10 01026, 2017
22:13 PM
zas
samj1912: for 2.0, one target is scalable UI, this is the main reason to switch to QT5, so i think we'll target port of last 1.4 version to py3/qt5, and release including only what it is needed to make the UI scalable, then start to add new features (it is fixed size of image in PR-474 that reminds me that), we'll discuss this in details after 1.4 release
2017-01-10 01026, 2017
22:13 PM
zas
anyway
2017-01-10 01007, 2017
22:14 PM
samj1912
okay :)
2017-01-10 01015, 2017
22:14 PM
samj1912
I am excited about this! :D
2017-01-10 01017, 2017
22:14 PM
dpmittal joined the channel
2017-01-10 01052, 2017
22:25 PM
kyan has quit
2017-01-10 01002, 2017
22:28 PM
samj1912 bids everyone bonne nuit, its 4 am and he should prolly sleep
2017-01-10 01051, 2017
22:37 PM
demonimin has quit
2017-01-10 01037, 2017
22:50 PM
Mineo has quit
2017-01-10 01002, 2017
22:51 PM
JonnyJD has quit
2017-01-10 01038, 2017
23:17 PM
D4RK-PH0ENiX has quit
2017-01-10 01053, 2017
23:22 PM
samj1912 has quit
2017-01-10 01040, 2017
23:23 PM
gcilou has quit
2017-01-10 01007, 2017
23:24 PM
gcilou joined the channel
2017-01-10 01054, 2017
23:24 PM
CatQuest
natta samj1912_riot[m] !
2017-01-10 01023, 2017
23:32 PM
Lotheric has quit
2017-01-10 01038, 2017
23:43 PM
samj1912 joined the channel
2017-01-10 01018, 2017
23:44 PM
D4RK-PH0ENiX joined the channel
2017-01-10 01019, 2017
23:44 PM
colbydray has quit
2017-01-10 01034, 2017
23:44 PM
D4RK-PH0ENiX has quit
2017-01-10 01040, 2017
23:44 PM
D4RK-PH0ENiX joined the channel
2017-01-10 01043, 2017
23:44 PM
D4RK-PH0ENiX has quit
2017-01-10 01009, 2017
23:45 PM
D4RK-PH0ENiX joined the channel
2017-01-10 01053, 2017
23:45 PM
tigranl has quit
2017-01-10 01054, 2017
23:49 PM
mihaitish has quit
2017-01-10 01039, 2017
23:52 PM
dpmittal
LordSputnik: I have made that change in the PR :)
2017-01-10 01040, 2017
23:52 PM
tigranl joined the channel
2017-01-10 01020, 2017
23:53 PM
tigranl has quit
2017-01-10 01003, 2017
23:56 PM
LordSputnik
dpmittal: thank you, good work!
2017-01-10 01024, 2017
23:56 PM
LordSputnik
merged and approved
