#metabrainz

Hi!

we can set some documentation standards for picard

yes, we'll do, but for 2.0

for now, let's focus on releasing ... ;)

hehe yes :P

I personally like the google python style guide above PEP-257 for doc strings

Gentlecat: please, have a look at my explanation on your comment about missing_users.

produces much more readable code than rst

tigranl: I will when I have time

already spending on reviewing much more than I should

zas: https://github.com/metabrainz/picard/pull/541 I think this can be merged, all the totaltrack changes were introduced by me

[picard] zas closed pull request #533: PICARD-226: Add option for auto-clustering new files (master...picard226) https://git.io/vMCul

zas wasnt done with PICARD-226 yet :P

PICARD-226: Cluster automatically https://tickets.metabrainz.org/browse/PICARD-226

[picard] zas closed pull request #541: Remove unsupported totaltracks metadata code (master...patch-3) https://git.io/vMRJr

it has a few bugs

metabrainz/picard#1711 (master - a8204fc : Laurent Monin): The build passed.

Change view : https://github.com/metabrainz/picard/compare/9c...

Build details : https://travis-ci.org/metabrainz/picard/builds/...

and I am not sure if my implementation is the best one

want me to revert ?

hm, it's wrong that jira considers 'in code review' as resolved, but 'in beta testing' as unresolved

idk how to fix that

zas Yes, I think I would like some opinion on my latest code :P

I am not satisfied with that one

samj1912: i tested it, and it seems to work, even though the UI is blinking a bit (because it moves files to Unmatched quickly)

samj1912: if you think you can improve it in next days no need to revert for now, it is off by default

okay :)

Yippee, build fixed!

I misspoke, I meant done vs. in-progress https://tickets.metabrainz.org/projects/MBS/ver...

also I think I am done with https://github.com/metabrainz/picard/pull/538 and https://github.com/metabrainz/picard/pull/537

review submitted is done, but in beta testing is in progress

samj1912: i'll merge them once Mineo will approve changes

okay :)

I have PICARD-860 left to code from scratch again and PICARD-880

PICARD-860: Cover art images filtering https://tickets.metabrainz.org/browse/PICARD-860

PICARD-880: Allow picard to correct wrong file extensions https://tickets.metabrainz.org/browse/PICARD-880

zas I pinged rahulr about PR-474, no reply from his side

samj1912: for 2.0, one target is scalable UI, this is the main reason to switch to QT5, so i think we'll target port of last 1.4 version to py3/qt5, and release including only what it is needed to make the UI scalable, then start to add new features (it is fixed size of image in PR-474 that reminds me that), we'll discuss this in details after 1.4 release

anyway

okay :)

I am excited about this! :D

natta samj1912_riot[m] !

LordSputnik: I have made that change in the PR :)

dpmittal: thank you, good work!

merged and approved