#metabrainz

Gentlecat: have a look at PR 252 for metabrainz.org It fixes the extra colon problem for translation strings and is rebased upon mayhem's new commit. I've also generated the string template file and added it in the PR.

s/have a look/ have a look whenever you can

[picard] zas closed pull request #589: PICARD-944: Wait for save thread pool to be finished before exit (master...picard933) https://git.io/vM5Xw

metabrainz/picard#1906 (master - e4a04d3 : Laurent Monin): The build passed.

Change view : https://github.com/metabrainz/picard/compare/b7...

Build details : https://travis-ci.org/metabrainz/picard/builds/...

samj1912: ping

pong

Hi :)

There is a bug related to https://github.com/metabrainz/picard/pull/519

Yeah?

Tested, and confirmed

i found where is the issue

Can you make a fix PR ?

Ah just saw the logic

But how is it different from the previous implementation?

Oh nvm

New file is taking old file as a parameter

1 sec, let me fix it :)

[picard] samj1912 opened pull request #594: Fix wrong new_file variable assignement due to modified old_file (master...fix519) https://git.io/vMA9u

tested, workign fine now :)

samj1912: thanks, tested & working, i will create a matching ticket and merge the fix

can you have a look at https://tickets.metabrainz.org/browse/PICARD-945 ?

yeah I saw

umm, we are going to bundle the plugins in the release right?

for other platforms as well?

s/release/packaged releases

[picard] zas closed pull request #594: PICARD-946: Fix wrong new_file variable assignement due to modified old_file (master...fix519) https://git.io/vMA9u

metabrainz/picard#1908 (master - 6a316ee : Laurent Monin): The build passed.

Change view : https://github.com/metabrainz/picard/compare/e4...

Build details : https://travis-ci.org/metabrainz/picard/builds/...

samj1912: yes

alastairp, reosarevok: I did not know it was such an affair of state. I was just amused to read this unusual name and teased Lotheric a bit with it, hence the language choice. :)

so then that shouldn't be a problem?

its just a warning?

we can check the picard ver and if its not a release ver. we can skip checking for plugins at that dir?

not worth the hassle, just a warning

then what to do about the issue?

ill close it?

zas https://tickets.metabrainz.org/browse/PICARD-947

PICARD-947: Search window error message does not appear translated

hmm it is marked for translation, and it is in transifex, so i closed it as invalid

hmm :) and what to do about 945?

Hmmm, testing for platforms... isn't the same issue with macosx ? Since this dir is optionnal we could simply transform the warning for this dir to a debug msg.

yeah

[picard] Freso opened pull request #595: PICARD-945: Demote non-existent plugin warning to info message. (master...PICARD-945-remove-contrib-warning) https://git.io/vMxfB

[picard] zas closed pull request #595: PICARD-945: Demote non-existent plugin warning to info message. (master...PICARD-945-remove-contrib-warning) https://git.io/vMxfB

metabrainz/picard#1910 (master - 9cc69ac : Laurent Monin): The build passed.

Change view : https://github.com/metabrainz/picard/compare/6a...

Build details : https://travis-ci.org/metabrainz/picard/builds/...

I like how mayhem is forwarding support@ e-mails to support@ :)

Ah, modbot emails go to support by default?

Yep. ModBot's e-mail is support@ :) Hence why it also gets all the edit notes from ModBot edits.

Are you coming to the office today, or was today the day you left for the 1½ day conference?

For another 10minutes anyway.

I guess you won't come to the office today then. :)

group hug! \o/

🙌

any thoughts on this verbiage change for our supporter page:

Non-commercial use includes but is not limited to; personal use, non-profit use and educational use of our data sets. If you are a pre-revenue start-up and expect to have revenue in the future, please sign up with a commercial account — see below for more details. Please consider making a donation to support our efforts!

(replacing the $500 rule)

Quesito: Where do you see that?

Ah, https://metabrainz.org/supporters/account-type

Sounds good to me.

si!

awesome! thanks Freso!

Quesito: May want to get an ACK from mayhem as well.

Once he's in reach.

yeah--thinking of holding of on the ticket write up till then. always better to have more eyes...