TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | MeB meeting agenda: reviews, gsoc ideas (mayhem), dev priorities (mayhem), mail (zas)
2017-02-06 03706, 2017
mayhem
contacting them is one options, yes.
2017-02-06 03724, 2017
Quesito
what started this was the digital 1/2. (which is us based)...
2017-02-06 03734, 2017
mayhem
but unless we have a clear idea that our data is in fact being used, it is nothing but a fishing expedition.
2017-02-06 03740, 2017
Quesito
yeah
2017-02-06 03703, 2017
Quesito
since the email is invalid. should I clean it out?
2017-02-06 03706, 2017
mayhem
I would leave this be and just sort of be aware of that name
2017-02-06 03710, 2017
mayhem
yeah
2017-02-06 03711, 2017
Freso
Is the next expedition after IKEA?
2017-02-06 03714, 2017
Freso
+that
2017-02-06 03717, 2017
Quesito
ok
2017-02-06 03704, 2017
dseomn has quit
2017-02-06 03751, 2017
Slurpee joined the channel
2017-02-06 03725, 2017
mayhem tries to pick up where we left off with LB.
2017-02-06 03741, 2017
dseomn joined the channel
2017-02-06 03701, 2017
Freso
LordSputnik: Ping?
2017-02-06 03754, 2017
mayhem
alastairp: IIRC you were going to make more tweaks to the test.py script, right?
2017-02-06 03700, 2017
mayhem
sorry, test.sh
2017-02-06 03708, 2017
alastairp
yep
2017-02-06 03710, 2017
alastairp
about 70% done
2017-02-06 03714, 2017
alastairp
going home shortly
2017-02-06 03714, 2017
mayhem
got ETA?
2017-02-06 03720, 2017
alastairp
hopefully tonight
2017-02-06 03727, 2017
alastairp
maybe tomorrow afternoon
2017-02-06 03747, 2017
mayhem
ok, I'll put some effort towards the integration tests.
2017-02-06 03755, 2017
sampsyo
Freso: Sadly, GitHub Pages doesn't let you SSL your custom domain. :(
2017-02-06 03703, 2017
sampsyo
Maybe we should move off of GH pages…
2017-02-06 03709, 2017
UmkaDK joined the channel
2017-02-06 03721, 2017
iliekcomputers
i have started with test_api.py too, I'll probably send a PR tomorrow or the day after
2017-02-06 03730, 2017
Freso
sampsyo: Or maybe they could start doing that with LE now.
alastairp, Gentlecat: for pytest I want to have a set of unit tests and a set of integration tests for LB. I want the unit tests to run separately from the integration tests. Any thoughts on how test files should be laid out to facilitate this?
2017-02-06 03749, 2017
alastairp
with py.test you can specifify a directory that you want to run
2017-02-06 03711, 2017
alastairp
so I'd just have a directory somewhere - perhaps tests/integration ?
2017-02-06 03723, 2017
CatQuest
[16:30] <Quesito> as idea for decor--world wall map that we can pin where our supporters/users are around the world.
2017-02-06 03723, 2017
CatQuest
[16:30] <Freso> And community members. And staff/office users.
2017-02-06 03723, 2017
CatQuest
+1§
2017-02-06 03727, 2017
CatQuest
+1!
2017-02-06 03733, 2017
Freso
+1@
2017-02-06 03737, 2017
Freso
+1$
2017-02-06 03743, 2017
Freso
+1*
2017-02-06 03709, 2017
mayhem
tests/integration seems a bit too conflated still.
2017-02-06 03724, 2017
alastairp
why? because currently our normal tests are inline in the code?
2017-02-06 03745, 2017
mayhem
normal tests just test from the top level dir, e.g. test everything.
2017-02-06 03707, 2017
mayhem
that would mean that we need to specify a subset for testing.
2017-02-06 03707, 2017
alastairp
kind of - pytest.ini specifies specific directories to test
2017-02-06 03737, 2017
github joined the channel
2017-02-06 03737, 2017
github
[acousticbrainz-server] alastair opened pull request #219: Dataset api clean (master...dataset-api-clean) https://git.io/vDWb5
unfortunately I think that moving existing tests is one of those things that we'd have to have a discussion about
2017-02-06 03700, 2017
alastairp
simply because we have the current format in CB/MeB/AB/LB
2017-02-06 03708, 2017
Gentlecat
I'd vote for not having tests in a separate directory tree
2017-02-06 03741, 2017
Gentlecat
that is I'd prefer to have them either in the same directory as the module they are testing or in ./test
2017-02-06 03748, 2017
alastairp
FYI, I develop locally with pycharm + uniitest2 test runner
2017-02-06 03710, 2017
alastairp
so I'd want to see a very good argument to use pytest specific hooks
2017-02-06 03725, 2017
alastairp
I'd like to try and make the argument that integration tests are specific and special enough that they can live in their own tree, even if we leave unit tests inline with the code
2017-02-06 03735, 2017
hibiscuskazeneko has quit
2017-02-06 03726, 2017
Gentlecat
would be useful to see some examples
2017-02-06 03728, 2017
shivamt joined the channel
2017-02-06 03749, 2017
Slurpee has quit
2017-02-06 03700, 2017
icode has quit
2017-02-06 03702, 2017
UmkaDK has quit
2017-02-06 03746, 2017
Mineo joined the channel
2017-02-06 03754, 2017
alastairp
-> home, errands, gym, food. I should be back around meeting time, and will try and put something together
2017-02-06 03702, 2017
alastairp
I need to have a bit of a think about it
2017-02-06 03741, 2017
UmkaDK joined the channel
2017-02-06 03727, 2017
Slurpee joined the channel
2017-02-06 03705, 2017
anshuman73
Freso: I won't be there for meeting today. Didn't do much this week :(
2017-02-06 03749, 2017
CallerNo6
oh, anshuman73, I didn't respond the other day. sorry. yes, when we have the dates then let's talk about meeting up during the GCI summit.
samj1912 is writing a boring lex tokenizer for sql for a college project :\
2017-02-06 03737, 2017
iliekcomputers
Found a small bug in get_listens leading to NameError because current_app was not imported :D
2017-02-06 03740, 2017
iliekcomputers
testing ftw!
2017-02-06 03716, 2017
Gentlecat
zas: looks like it's dropping, no?
2017-02-06 03729, 2017
Gentlecat
if so, it was the indexer for solr
2017-02-06 03741, 2017
github joined the channel
2017-02-06 03741, 2017
github
[listenbrainz-server] paramsingh opened pull request #116: Import current_app to api.py so that get_listens doesn't throw error (master...get-listen-fix) https://git.io/vDlkq
2017-02-06 03741, 2017
github has left the channel
2017-02-06 03734, 2017
SothoTalKer
alastairp: heh, what I always wondered: how does acousticbrainz deal with deleted entities. for example if one merges some recordings which have AB data.
2017-02-06 03735, 2017
Gentlecat
it doesn't
2017-02-06 03740, 2017
SothoTalKer
zas: your link requires a login. :D
2017-02-06 03702, 2017
ARChak is now known as Apra
2017-02-06 03739, 2017
CatQuest
I made a generic login on grafana... maybe it can become a "guest" type user
2017-02-06 03747, 2017
thresh has left the channel
2017-02-06 03741, 2017
github joined the channel
2017-02-06 03741, 2017
github
[listenbrainz-server] mayhem closed pull request #116: Import current_app to api.py so that get_listens doesn't throw error (master...get-listen-fix) https://git.io/vDlkq
2017-02-06 03741, 2017
github has left the channel
2017-02-06 03741, 2017
mayhem
thanks iliekcomputers :)
2017-02-06 03700, 2017
mayhem
iliekcomputers: are you planning on participating in GSoC?
2017-02-06 03705, 2017
iliekcomputers
mayhem: yea, the stats idea of yours is pretty interesting to me.
2017-02-06 03736, 2017
mayhem
I had that sneaky suspicion.. :)
2017-02-06 03739, 2017
iliekcomputers
i was gonna talk about GSoC in today's meeting lol :)
2017-02-06 03717, 2017
mayhem
given what things are hot today, I suspect that a lot of people will want do that one.
2017-02-06 03717, 2017
samj1912
when is the gsoc deadline for orgs?
2017-02-06 03730, 2017
mayhem
9th
2017-02-06 03709, 2017
iliekcomputers
mayhem: i was also thinking of simpler stuff like pages for artists, release-groups and more stats for users ala last.fm
2017-02-06 03736, 2017
dboys_ joined the channel
2017-02-06 03700, 2017
mayhem
stats for users is exactly what I am talking about on the ideas page.
2017-02-06 03719, 2017
iliekcomputers
mayhem: but the stuff like generic queries was not in my mind :)
2017-02-06 03726, 2017
iliekcomputers
it'd be pretty cool
2017-02-06 03741, 2017
mayhem
I'll say this as general guidance to our GSoC applicants who are already part of our community: Your chances for getting accepted are higher than new people.
2017-02-06 03756, 2017
iliekcomputers
mayhem: how do you plan to show visualizations? d3.js?
2017-02-06 03712, 2017
iliekcomputers
mayhem: that is very nice to hear :D
2017-02-06 03718, 2017
mayhem
that said, if you design something for yourself that is outside of the given ideas pages, you'll cut down the amount of competition you get.
2017-02-06 03739, 2017
mayhem
I hadn't decided anything,but I am fond of d3, yes.
2017-02-06 03705, 2017
mayhem
and don't get me wrong, I don't want to make a generic reporting system. I just want to make it easy to add more graphs/reports, etc.
2017-02-06 03734, 2017
mayhem
building a truly extensible system is beyond what we need
2017-02-06 03703, 2017
mayhem
also, I don't really want to wait until summer to work on these graphs.
2017-02-06 03733, 2017
mayhem
if you're thinking of doing this project, we may just want to change the idea page to be a 2 part project.
2017-02-06 03758, 2017
mayhem
part 1: iliekcomputers builds. part 2: continue iliekcomputers' work, ideally by iliekcomputers. :)
2017-02-06 03720, 2017
mayhem
s/builds/builds graphs/
2017-02-06 03750, 2017
iliekcomputers
mayhem: I was actually hoping to get started as soon as the beta was deployed :D
