yes, moving the validate outside of insert_payload sounds like an OK step
2017-02-08 03930, 2017
alastairp
I'm a little busy right now so can't confirm that
2017-02-08 03948, 2017
alastairp
(e.g., are there any other places in the code that call insert_payload? from a different codepath)
2017-02-08 03957, 2017
alastairp
make the change, and I'll verify it in the PR :)
2017-02-08 03939, 2017
iliekcomputers
alastairp: from a cursory look at git blame, I think it got added twice in some merge conflict resolution.
2017-02-08 03949, 2017
iliekcomputers
I'll see if insert_payload is called anywhere else and if validate needs to be in there, and if it doesn't I'll send a PR moving it out
2017-02-08 03939, 2017
iliekcomputers
should probably fix the tabs and spaces in manage.py first though
2017-02-08 03932, 2017
alastairp
:hooray:
2017-02-08 03951, 2017
mayhem
Quesito: MB is a product of MeB. MeB is a non-profit.
2017-02-08 03909, 2017
mayhem
we have only one legal entity, but multiple projects/products.
2017-02-08 03903, 2017
ferbncode
Gentlecat: Hi :), I was trying to migrate users code off the ORM. But wasn't sure how it should be done. I tried making a user class so the flask-login stuff gets easy to migrate. Here is a sample > https://github.com/ferbncode/critiquebrainz/blob/…. Is there a better or more preferred way of doing this?
2017-02-08 03926, 2017
CatQuest
...
2017-02-08 03916, 2017
mayhem
Quesito: if you have a metabrainz account (you should sign up for non commercial use) then you can use the officebrainz site to open the door downstairs
2017-02-08 03951, 2017
hibiscuskazeneko has quit
2017-02-08 03916, 2017
zas
CatQuest: run Picard from source, or wait for new packages to be build for your platform
2017-02-08 03934, 2017
CatQuest has no idea how to run from souce on mac os :/
2017-02-08 03928, 2017
CatQuest
..but if you've got norwegian picard.mo files. I can put these *inside* the picard.app
can you make a branch an alt branch in picard-plugins?
2017-02-08 03957, 2017
Quesito
Mayhem I donno, but I should come up with a list...as an important part of the PR world...and not the pull request world...
2017-02-08 03901, 2017
samj1912
or are we gonna keep it in a diff repo?
2017-02-08 03955, 2017
github joined the channel
2017-02-08 03955, 2017
github
[listenbrainz-server] mayhem opened pull request #120: Integration tests (master...integration-tests) https://git.io/vD0yW
2017-02-08 03955, 2017
github has left the channel
2017-02-08 03915, 2017
mayhem
alastairp: ^^
2017-02-08 03906, 2017
mayhem
iliekcomputers: once we get this merged, you should be clear to write integration tests. we still need to think about how to seperate the integration tests from the unit tests. I *think* we have a way forward on that, but I am not sure yet.
2017-02-08 03914, 2017
ferbncode
Gentlecat: okay, thanks :)
2017-02-08 03929, 2017
Freso has quit
2017-02-08 03929, 2017
jwheare has quit
2017-02-08 03929, 2017
MightyJay has quit
2017-02-08 03929, 2017
gcilou has quit
2017-02-08 03929, 2017
samj1912 has quit
2017-02-08 03943, 2017
beqn has quit
2017-02-08 03943, 2017
suhas2go has quit
2017-02-08 03943, 2017
mayhem has quit
2017-02-08 03943, 2017
belak has quit
2017-02-08 03943, 2017
kepstin has quit
2017-02-08 03943, 2017
zas has quit
2017-02-08 03943, 2017
reosarevok has quit
2017-02-08 03944, 2017
Quesito has quit
2017-02-08 03945, 2017
alastairp has quit
2017-02-08 03921, 2017
laurie_ has quit
2017-02-08 03923, 2017
LordSputnik has quit
2017-02-08 03919, 2017
iliekcomputers
netsplit?
2017-02-08 03958, 2017
SothoTalKer
no
2017-02-08 03907, 2017
ocharles has quit
2017-02-08 03916, 2017
SothoTalKer
irccloud
2017-02-08 03939, 2017
alastairp_ joined the channel
2017-02-08 03945, 2017
alastairp_
huh
2017-02-08 03952, 2017
alastairp_
irccloud is unhappy
2017-02-08 03913, 2017
SothoTalKer
i am happy
2017-02-08 03931, 2017
alastairp_
well, that's one of us
2017-02-08 03931, 2017
iliekcomputers
oh
2017-02-08 03943, 2017
iliekcomputers
irccloud always seemed a bit too heavy to me
2017-02-08 03951, 2017
jwheare joined the channel
2017-02-08 03906, 2017
alastairp_
ah, looks like irccloud is coming back
2017-02-08 03945, 2017
alastairp_
iliekcomputers: it's nice having it stay around all the time
2017-02-08 03907, 2017
samj1912_riot[m]
this is weird
2017-02-08 03931, 2017
samj1912_riot[m]
well anywho this matrix bridge works when irccloud gives up one me
