#metabrainz

ruaok, but no longer causing mayhem!

BrainzBot going down for an update!

OTHER-283

OTHER-283: JIRA plugin responds to invalid tickets in [off] messages https://tickets.metabrainz.org/browse/OTHER-283

nice

[musicbrainz-server] mwiencek opened pull request #469: MBS-8931: Invalid ISRC causes an ISE (master...mbs-8931) https://git.io/vD9g3

Anyone have a musicbrainz mirror I can leach off?

[picard] zas closed pull request #621: PICARD-980: Fix various cover drop issues (master...master) https://git.io/vDuqD

metabrainz/picard#2030 (master - 4e7d49a : Laurent Monin): The build passed.

Change view : https://github.com/metabrainz/picard/compare/21...

Build details : https://travis-ci.org/metabrainz/picard/builds/...

can someone on mac test drag'n'drop ? See https://tickets.metabrainz.org/browse/PICARD-988

PICARD-988: Drag & Drop not working

samj1912: ^^ this one has to be fixed for 1.4.1 if confirmed

Okay :)

zas: probably the user is drag&dropping https urls

which is fixed by my PR which was postponed for 1.4.1

ah, sorry, files/folders ...

I'm too focused on cover art lately...

:p

samj1912: btw, what's the right way to make a track/album change its state to "modified" ? I saw your commit in File.update() that checks if orig_metadata.images has changed

should I call update() after changing the images of a file?

depends on your call stack

if update is being called somewhere afterwards then no need

when dropping an image on the CoverArtBox, the state isn't changed

hmm, it should be

the drag and drop is hidden anyways

I mean the little icon next to the album/track/file

that doesn't change for me

yeah, I mean, the drag and drop functionality is hidden

ah

and the coverart changes updating the file status was just recently added

it was ignored earlier since there was no diff to show

(now there is)

antlarr: while you are implementing album/cluster level coverarts

can you take a look at album/cluster level diffs?

metadata diffs?

currently they are calculated on every selection change

yes

we could maybe store the data

it was suggested by sophist, will help speed up the UI

since we now have a orig_metadata and metadata attribute associated with albums/clusters we can maybe calculate the metadata diffs and store them there as well

maybe, yes

I'll think about how to do it (and how to keep track of changes in sub-elements)

about this issue... I saw https://github.com/metabrainz/picard/pull/586/c...

but who calls File.update() after CoverArtBox.load_remote_image is run ?

hmm, yes, completely overlooked the fact that no updates are being called on CA change due to drag and drops

the CA drag and drop func. is mostly overlooked

I'm fixing it

just call an item.update after load_remote_image

yep

antlarr: no need for all of that

ill add the fix with my PR :)

a simple self.item.update at the end of all the if/elif suffices :)

nope

I tried that before

what happens?

nothing, File.update() isn't called

I guess Track.update doesn't call the files' update function

it does

samj1912: I tried again. it's not called here

samj1912: the self.item object in CoverArtBox is the Track object, not the TrackItem object

hmmm

file.update then :P

hehe, ok

wait

hmm it should still be called

what is self.item for a Track ?

the TrackItem ?

yup

I see, I added some debug output, and indeed, TrackItem.update is called, but it doesn't call File.update

hmm

when track.num_linked_files == 1, there's no codepath that calls File.update

and even when track.num_linked_files != 1, item.update is only called when the number of linked files changed

(AFAICS, at least)

antlarr: nope when >1 file.update does get called

ah, sorry, I missed the update inside the first for loop

ok, I see how that works...

that TrackItem.update updates the child FileItem objects, but that is supposed to be called from the Track/File update() function, so we can't call the File.update() method from *Item.update

otherwise, there's an infinite recursion

hmmm

I am leaving that out of my PR for now

exactly this: https://github.com/antlarr/picard/commit/6a9415...

that fixes the problem

cool then :)

btw, I did a pull --rebase from your branch and now I have tons of co-authored commits that will give problems when doing the pull request :(

antlarr: I am making a few more changes

I'll cherry-pick my commits to another branch in order to re-create the branch correctly :(

ok, I'll do it after your changes then

but I wonder... do you also use git pull --rebase?

or what am I doing wrong to get that?

I also use rebase

(have a look at the commit list in https://github.com/metabrainz/picard/compare/ma... to see what I mean)

reosarevok & other wikifarian: Where can I add a wiki page that isn't necessarily linked to anything, but has in GIANT FUCKING BOLD PRINT: WE DO NOT HAVE ANY OF THE MUSIC YOU ACCUSE US OF HAVING, MOFO! ?

people keep watering down my statements on https://musicbrainz.org/doc/About . :)

ouch

antlarr: I always rebase against master though

I can't rebase against master, because I started from your branch, so I rebased against it

ruaok: what do you mean with watering down there?

My lovely bold print about not having any of the music on our site.

Bold. ALL CAPS. The proper way to talk to a lawyer.

A FalseCopyrightAccusationLandingPage. :)

antlarr: you had some indentation errors in PR-621L192-198 and an import error

fixed them :)

ruaok: We_Don't_Have_Your_Shit :p

samj1912: ah, thanks

btw, I created https://github.com/antlarr/picard/tree/samj1912...

that's supposed to be working now

reosarevok: lol