I'm noticing when matching looking up recordings by acoustic fingerprint that there are many times where the recording that is returned doesn't exist in musicbrainz
2017-03-07 06610, 2017
agentsim
any idea why this is?
2017-03-07 06611, 2017
bitmap
got an example?
2017-03-07 06635, 2017
bitmap
it's possible for recordings to be removed, but I wouldn't expect that to happen often
2017-03-07 06612, 2017
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC Getting Started: https://goo.gl/JTNkn0 | MeB meeting agenda: BrainzBot brain plugin (Leo), DR: CB-244 (Gentlecat), DR: MBS-9271 (bitmap)
2017-03-07 06622, 2017
ZarkBit_ joined the channel
2017-03-07 06623, 2017
ZarkBit has quit
2017-03-07 06624, 2017
ZarkBit_ is now known as ZarkBit
2017-03-07 06633, 2017
samj1912
What does DR mean?
2017-03-07 06640, 2017
bitmap
Decision Required
2017-03-07 06648, 2017
rKansal joined the channel
2017-03-07 06624, 2017
rKansal_ joined the channel
2017-03-07 06639, 2017
rKansal has quit
2017-03-07 06636, 2017
amanmehta joined the channel
2017-03-07 06641, 2017
Nyanko-sensei joined the channel
2017-03-07 06627, 2017
D4RK-PH0ENiX has quit
2017-03-07 06639, 2017
Slurpee has quit
2017-03-07 06622, 2017
Nyanko-sensei has quit
2017-03-07 06649, 2017
D4RK-PH0ENiX joined the channel
2017-03-07 06606, 2017
agentsim
bitmap: there are plenty, but I realized that it isn't as bad as I thought. I was thinking some acoustIDs weren't associated to existing recordings anymore, but in each case it was just one, usually obviously bad recording that was missing.
2017-03-07 06659, 2017
rKansal_ has quit
2017-03-07 06621, 2017
hibiscuskazeneko has quit
2017-03-07 06648, 2017
suhas2go joined the channel
2017-03-07 06600, 2017
JonnyJD has quit
2017-03-07 06648, 2017
nitinprakash96_ joined the channel
2017-03-07 06637, 2017
Mineo has quit
2017-03-07 06658, 2017
moufl has quit
2017-03-07 06636, 2017
saifulbkhan_ has quit
2017-03-07 06630, 2017
moufl joined the channel
2017-03-07 06657, 2017
antlarr
samj1912: I know you're probably travelling now, but just so that you answer when you have some time: you said: "IHMO we can move the if clause below to the top and move the above block to an else.", would it be ok for you if I move the if clause to the top and make it return so there's no need for "else" and there's less indentation on that method?
2017-03-07 06643, 2017
jesus2099 joined the channel
2017-03-07 06640, 2017
7GHAAHZZ3 joined the channel
2017-03-07 06617, 2017
hibiscuskazeneko joined the channel
2017-03-07 06604, 2017
nawcom has quit
2017-03-07 06658, 2017
adhawkins has quit
2017-03-07 06658, 2017
nawcom joined the channel
2017-03-07 06629, 2017
samj1912
antlarr okay with me
2017-03-07 06639, 2017
samj1912
Glanced over your latest commits :)
2017-03-07 06645, 2017
samj1912
Looks good
2017-03-07 06656, 2017
Nyanko-sensei joined the channel
2017-03-07 06659, 2017
antlarr
cool :)
2017-03-07 06601, 2017
samj1912
Will review it once I am back home
2017-03-07 06615, 2017
antlarr
I'm now reading zas' comments
2017-03-07 06656, 2017
D4RK-PH0ENiX has quit
2017-03-07 06605, 2017
adhawkins joined the channel
2017-03-07 06605, 2017
adhawkins has quit
2017-03-07 06605, 2017
adhawkins joined the channel
2017-03-07 06634, 2017
antlarr
zas: can you give me an example of a release with multiple front images?
2017-03-07 06639, 2017
abhishekg5 joined the channel
2017-03-07 06613, 2017
adhawkins has quit
2017-03-07 06635, 2017
adhawkins joined the channel
2017-03-07 06649, 2017
Nyanko-sensei has quit
2017-03-07 06617, 2017
D4RK-PH0ENiX joined the channel
2017-03-07 06613, 2017
lazka joined the channel
2017-03-07 06638, 2017
amanmehta has quit
2017-03-07 06607, 2017
antlarr
samj1912, zas, Freso: when dragging & dropping an image on the cover art box, I think it's more natural to replace the front cover art image with the dropped image, but it seems zas thinks it's better to append the image thus having multiple front images. Since I think both options have arguments for and against, I'll add an option so the user can select to "replace front images on drop" or "append front images on drop". Would you
2017-03-07 06607, 2017
antlarr
prefer to have that option in the Options dialog (user interface section) or in the new cover art box's context menu?
2017-03-07 06648, 2017
amanmehta joined the channel
2017-03-07 06650, 2017
agentsim has quit
2017-03-07 06610, 2017
Freso
I think Picard has too many options as it is. I also don't use Picard's "local ca", so I have never used the drag and drop, so no comment on that. (zas' approach does make sense though, to not inadvertently remove data/cover art—I assume it's possible to remove individual images in the interface?)
2017-03-07 06624, 2017
agentsim joined the channel
2017-03-07 06648, 2017
agentsim has quit
2017-03-07 06602, 2017
antlarr
Freso: I don't think so, at least, I don't know of any way to remove an image in picard
2017-03-07 06647, 2017
nitinprakash96_ has quit
2017-03-07 06630, 2017
antlarr
Btw, in the branch where I'm adding the context menu, I already have a "Keep original cover art" option, and adding "Remove front cover art" / "Remove all cover art" options would be trivial to add
2017-03-07 06648, 2017
antlarr
IMHO I think that the Cover Art Box should only show/manipulate/work with front cover art
2017-03-07 06654, 2017
hibiscuskazeneko has quit
2017-03-07 06658, 2017
antlarr
Freso: Btw, just to be sure I understood you, what do you exactly mean with "I don't use Picard's local ca" ?
2017-03-07 06624, 2017
Freso
antlarr: I don't use local cover art with Picard, only CAA.
2017-03-07 06605, 2017
antlarr
But CAA is downloaded and saved to the local files, right?
2017-03-07 06650, 2017
antlarr
You mean that you don't change the cover art of your files with local images, right?
2017-03-07 06604, 2017
Freso
Yes.
2017-03-07 06631, 2017
Freso
antlarr: Picard has a "Local files" CA provider. I don't use that.
2017-03-07 06601, 2017
antlarr
ah, so the "Local files" CA provider is what loads "cover/front.jpg" images in the same directory?
I don't have a proposal. Just pointing out that right-clicks are not very discoverable. Not sure what we could do instead
2017-03-07 06645, 2017
alastairp
perhaps a dropdown menu somewhere near the image
2017-03-07 06657, 2017
alastairp
or a checkbox which appears under the image if you drag something on top of it
2017-03-07 06632, 2017
antlarr
the mouse cursor already changes to an "accept drop" cursor when you drag something over the widget
2017-03-07 06641, 2017
alastairp
looking again at the image that you linked to - what's the meaning of original and new cover art? if you already have an image, and you drag another one on, and you select the "append front cover" option, will it save both images to the image?
2017-03-07 06651, 2017
alastairp
that doesn't make sense with the words original and new
2017-03-07 06654, 2017
antlarr
no
2017-03-07 06627, 2017
alastairp
mouse cursor is still undiscoverable - you still have to know that you can drag there to try it
2017-03-07 06636, 2017
antlarr
that's because the file had one image and after looking up the album, the cover art will be replaced by a new one
2017-03-07 06647, 2017
antlarr
any image
2017-03-07 06649, 2017
alastairp
but I'm being picky... it's been like this for a long time. no need to make drastic changes
2017-03-07 06659, 2017
antlarr
hehe
2017-03-07 06612, 2017
antlarr
you can drag any image from your local disk or from a web page
2017-03-07 06629, 2017
antlarr
alastairp: if you have one regular file with one front image, set the behaviour to append and then drop another image to the cover art box you get this: http://i.imgur.com/pCL6ds2.png
2017-03-07 06641, 2017
antlarr
so it's clear that previously you had one image and now you have two front images
2017-03-07 06626, 2017
alastairp
right
2017-03-07 06648, 2017
alastairp
seems like perhaps it's necessary to have a more advanced cover art editor which has more space than this sidebar
2017-03-07 06654, 2017
alastairp
I don't know if that exists
2017-03-07 06604, 2017
alastairp
anyway, I don't have much time to talk about this now, sorry
2017-03-07 06624, 2017
antlarr
I think samj1912 is working on a refactoring of the cover art info dialog
2017-03-07 06615, 2017
samj1912
Yeah
2017-03-07 06601, 2017
samj1912
antlarr I personally have no qualms about if since the drag n drop feature is hidden anyways
2017-03-07 06608, 2017
samj1912
It isn't documented anywhere
2017-03-07 06622, 2017
samj1912
Nor is it indicated that it can be used that way
2017-03-07 06656, 2017
samj1912
I personally would prefer not spending much time on it, we are going to be having something more robust with 2.0 anyways
2017-03-07 06629, 2017
alastairp
if it's going to change in 2, I wouldn't spend any time on it
2017-03-07 06652, 2017
alastairp
anyway, not my project. -> other things
2017-03-07 06601, 2017
samj1912
Yeah, the original PR is supposed to be about showing cover art diffs
2017-03-07 06611, 2017
samj1912
This was just a good cherry on the top
2017-03-07 06629, 2017
samj1912
Also I would prefer it to not change any default behavior
2017-03-07 06606, 2017
samj1912
So can you make the default drag and drop option to append instead of replace and you can have the right click context menu
2017-03-07 06634, 2017
antlarr
ok, that's a good argument for append behaviour, indeed :)
