seems like an acquihire though, because I'm not sure how much better that would be than what they already have
2017-03-07 06629, 2017
reosarevok
heh, speaking of
2017-03-07 06654, 2017
reosarevok
Apparently play.spotify redirects to open.spotify now. I guess we decided right on that link migration then :p
2017-03-07 06607, 2017
reosarevok
(now if only it didn't tell me it can't play music, that'd be great)
2017-03-07 06643, 2017
alastairp
I wonder if it works without flash now
2017-03-07 06647, 2017
Leo_Verto
I find that spotify is either fantastically good at finding music I listen to outside of it (even if it's entirely different genres) or has hacked all my devices \o/
2017-03-07 06614, 2017
github joined the channel
2017-03-07 06614, 2017
github
[listenbrainz-server] paramsingh opened pull request #135: Make redis port a configurable option in config.py (master...add-redis-port) https://git.io/vy0Fw
Leo_Verto: mind merging that and rebooting BrainzBot, I tested it locally, its working fine
2017-03-07 06621, 2017
zas
but it does both, showing cover art diffs in cover art box and info dialog for releases
2017-03-07 06635, 2017
samj1912
remember to store the config value of the organization as metabrainz
2017-03-07 06643, 2017
Mineo
I created picard-1000, I'm 100% certain that that pull request (without the info dialog change) was not what I had in mind
2017-03-07 06613, 2017
zas
Mineo: oh, you created it ? i thought antlarr did, sorry.
2017-03-07 06616, 2017
Leo_Verto
samj1912, I hate to say it but tests and documentation :P
2017-03-07 06624, 2017
samj1912
ah :P
2017-03-07 06628, 2017
samj1912
I knew this was coming :P
2017-03-07 06632, 2017
samj1912
gimme 20 :P
2017-03-07 06637, 2017
samj1912
documentation is there?
2017-03-07 06655, 2017
Leo_Verto
well, not the new command and it uses issue instead of pull request
2017-03-07 06656, 2017
samj1912
oh you mean the commands
2017-03-07 06603, 2017
samj1912
yo
2017-03-07 06604, 2017
samj1912
gotcha
2017-03-07 06608, 2017
zas
samj1912: no thought about lru stuff, antlarr's implementation is very simple and works, i don't know if @lrucache decorator works for us, but if it does we can move to it later.
2017-03-07 06613, 2017
Leo_Verto
yeah, I think CatQuest had a point when he said the plugins aren't very well documented (and tested for that matter) and I feel we shouldn't continue that trend :P
2017-03-07 06628, 2017
samj1912
added documentation
2017-03-07 06633, 2017
samj1912
need a bit for tests
2017-03-07 06654, 2017
Leo_Verto
\o/
2017-03-07 06637, 2017
kyan joined the channel
2017-03-07 06649, 2017
zas
Mineo: the question is whether picard-1000 is solved or not through this PR, i think it does, or at least make picard-1000 obsolete. If you prefer we can create another ticket, just tell.
2017-03-07 06623, 2017
samj1912
Leo_Verto: didnt we add a dummy cache for botbot?
2017-03-07 06625, 2017
samj1912
for testing?
2017-03-07 06649, 2017
Leo_Verto
yep, should be in the jira tests
2017-03-07 06614, 2017
Leo_Verto
I suppose we could offload some of that into it's a common library
2017-03-07 06650, 2017
abhishekg5 has quit
2017-03-07 06645, 2017
abhishekg5 joined the channel
2017-03-07 06659, 2017
hibiscuskazeneko joined the channel
2017-03-07 06630, 2017
samj1912
Leo_Verto: added :)
2017-03-07 06641, 2017
samj1912
plugin complete :P
2017-03-07 06645, 2017
Leo_Verto
!m samj1912
2017-03-07 06645, 2017
BrainzBot
You're doing good work, samj1912!
2017-03-07 06646, 2017
samj1912
now can we have it? :P
2017-03-07 06638, 2017
Leo_Verto
well, I just remembered I can't login to nomo from this computer but yes, I'll activate it as soon as I can
2017-03-07 06657, 2017
samj1912
Leo_Verto: ill merge it?
2017-03-07 06610, 2017
Leo_Verto
sure
2017-03-07 06647, 2017
samj1912
I love quick dirty python scripting :P
2017-03-07 06601, 2017
samj1912
especially for useful stuff like this
2017-03-07 06636, 2017
Leo_Verto
yeah
2017-03-07 06607, 2017
ruaok
iliekcomputers: woo, thanks. I'll look when I get home.
2017-03-07 06627, 2017
saifulbkhan_ has quit
2017-03-07 06643, 2017
Leo_Verto
samj1912, should be enabled now
2017-03-07 06654, 2017
samj1912
lets try it out
2017-03-07 06648, 2017
samj1912
BrainzBot: gh:P=picard
2017-03-07 06648, 2017
BrainzBot
I will remember "gh:P" for you samj1912.
2017-03-07 06648, 2017
BrainzBot
Successfully stored the repo picard as P for Github lookups
2017-03-07 06601, 2017
samj1912
ugh
2017-03-07 06601, 2017
Leo_Verto
welp
2017-03-07 06606, 2017
samj1912
conflicts with brain plugin
2017-03-07 06608, 2017
Leo_Verto
unintended consequences \o/
2017-03-07 06633, 2017
samj1912
lets try if its works though gh:P#642
2017-03-07 06643, 2017
Leo_Verto
yeah, that's a good argument for using a different prefix for the brain plugin :P
2017-03-07 06608, 2017
samj1912
hmmm
2017-03-07 06610, 2017
samj1912
not working
2017-03-07 06618, 2017
samj1912
Leo_Verto: mind disabling the brain plugin for a while?
2017-03-07 06637, 2017
Leo_Verto
sure
2017-03-07 06611, 2017
Leo_Verto
BrainzBot; gsoc?
2017-03-07 06614, 2017
Leo_Verto
yep, disabled
2017-03-07 06623, 2017
SothoTalKer
BrainzBot. GSOCß
2017-03-07 06625, 2017
SothoTalKer
xd
2017-03-07 06637, 2017
SothoTalKer
i hate capslock
2017-03-07 06640, 2017
samj1912
@BrainzBot: gh:P=picard
2017-03-07 06650, 2017
samj1912
BrainzBot: gh:P=picard
2017-03-07 06650, 2017
BrainzBot
I will remember "gh:P" for you samj1912.
2017-03-07 06650, 2017
BrainzBot
Successfully stored the repo picard as P for Github lookups
