0:17 AM
JonnyJD has quit
2017-03-08 06700, 2017
0:20 AM
D4RK-PH0ENiX has quit
2017-03-08 06745, 2017
0:35 AM
bitmap
sentry seems to be working
2017-03-08 06729, 2017
0:37 AM
bitmap had to trigger an error himself since nobody else has in the past hour
2017-03-08 06716, 2017
0:39 AM
D4RK-PH0ENiX joined the channel
2017-03-08 06728, 2017
0:54 AM
Mineo has quit
2017-03-08 06757, 2017
1:03 AM
kyan joined the channel
2017-03-08 06701, 2017
1:35 AM
hibiscuskazeneko joined the channel
2017-03-08 06713, 2017
1:41 AM
kyan has quit
2017-03-08 06732, 2017
1:41 AM
Nyanko-sensei joined the channel
2017-03-08 06748, 2017
1:42 AM
Nyanko-sensei has quit
2017-03-08 06756, 2017
1:43 AM
Nyanko-sensei joined the channel
2017-03-08 06757, 2017
1:43 AM
D4RK-PH0ENiX has quit
2017-03-08 06724, 2017
1:49 AM
kyan joined the channel
2017-03-08 06739, 2017
1:49 AM
amanmehta has quit
2017-03-08 06706, 2017
2:06 AM
G0re joined the channel
2017-03-08 06727, 2017
2:06 AM
Gore|home has quit
2017-03-08 06723, 2017
2:51 AM
Nyanko-sensei has quit
2017-03-08 06750, 2017
2:51 AM
D4RK-PH0ENiX joined the channel
2017-03-08 06708, 2017
3:37 AM
abhishekg5 has quit
2017-03-08 06736, 2017
3:58 AM
samj1912 joined the channel
2017-03-08 06744, 2017
4:13 AM
Slurpee has quit
2017-03-08 06732, 2017
6:04 AM
samj1912
Hi antlarr
2017-03-08 06740, 2017
6:04 AM
samj1912
Either way works for me
2017-03-08 06711, 2017
6:05 AM
samj1912
Up early?
2017-03-08 06742, 2017
6:37 AM
Protab joined the channel
2017-03-08 06742, 2017
6:37 AM
Rotab has quit
2017-03-08 06736, 2017
6:44 AM
Protab is now known as Rotab
2017-03-08 06718, 2017
6:55 AM
JonnyJD joined the channel
2017-03-08 06723, 2017
6:58 AM
antlarr
samj1912: yep :)
2017-03-08 06709, 2017
7:06 AM
antlarr
does mineo ever come to irc?
2017-03-08 06707, 2017
7:08 AM
samj1912
antlarr: yes he does
2017-03-08 06717, 2017
7:08 AM
samj1912
generally in the evening though
2017-03-08 06722, 2017
7:08 AM
antlarr
ah ok
2017-03-08 06749, 2017
7:08 AM
antlarr
2017-03-08 06744, 2017
7:19 AM
samj1912
hmm, ui decisions like that are exactly why I didn't want to touch album level diffs :P
2017-03-08 06733, 2017
7:20 AM
antlarr
sigh
2017-03-08 06751, 2017
7:20 AM
samj1912
how I had implemented is iterate over all tracks and look for cover arts which are common acorss all
2017-03-08 06753, 2017
7:20 AM
antlarr
I'm already regretting, yes
2017-03-08 06758, 2017
7:20 AM
samj1912
and show that in album :P
2017-03-08 06722, 2017
7:21 AM
samj1912
that's why I had the whole hash thing going on
2017-03-08 06712, 2017
7:22 AM
samj1912
I had implemented it using an all and current_coverart == coverart for covert in coverart_list
2017-03-08 06741, 2017
7:22 AM
samj1912
what I like about your implementation is the stack of CA images
2017-03-08 06758, 2017
7:23 AM
antlarr
:)
2017-03-08 06703, 2017
7:26 AM
samj1912
2017-03-08 06742, 2017
7:26 AM
samj1912
on why I personally have the view that CA images should be track level
2017-03-08 06755, 2017
7:26 AM
samj1912
and on the album level, only the common images should be shown
2017-03-08 06709, 2017
7:27 AM
samj1912
instead of a concatenation of all CA
2017-03-08 06746, 2017
7:28 AM
antlarr
Maybe show common images and then a "broken cover" when there are different images in each track?
2017-03-08 06704, 2017
7:29 AM
antlarr
(or some kind of simbol in a corner)
2017-03-08 06712, 2017
7:29 AM
agemcipe joined the channel
2017-03-08 06717, 2017
7:30 AM
samj1912
maybe the default Disc shadow with a red tint?
2017-03-08 06734, 2017
7:30 AM
antlarr
something like that, yes
2017-03-08 06759, 2017
7:30 AM
samj1912
hmm, well Mineo has a valid point with the behaviour about the diffs
2017-03-08 06710, 2017
7:31 AM
antlarr
yes, I agree with that
2017-03-08 06707, 2017
7:32 AM
samj1912
antlarr: are you implementing slot/signal for updating album metadata?
2017-03-08 06717, 2017
7:32 AM
antlarr
yes, I'll do that
2017-03-08 06745, 2017
7:34 AM
samj1912
if yes, you might consider looking into PICARD-905
2017-03-08 06745, 2017
7:34 AM
BrainzBot
2017-03-08 06754, 2017
7:34 AM
samj1912
antlarr: ^
2017-03-08 06702, 2017
7:35 AM
samj1912
in a seperate PR ofc :P
2017-03-08 06739, 2017
7:35 AM
samj1912
basically album level tag diffs
2017-03-08 06749, 2017
7:35 AM
samj1912
currently they are calculated on each selection update :\
2017-03-08 06752, 2017
7:37 AM
JonnyJD has quit
2017-03-08 06745, 2017
7:44 AM
antlarr
samj1912: just like images!
2017-03-08 06755, 2017
7:44 AM
samj1912
antlarr: yup :P
2017-03-08 06726, 2017
7:45 AM
antlarr
but my PR wasn't accepted yet because of this, while it currently works that way ...
2017-03-08 06730, 2017
7:45 AM
samj1912
lots of wasted processing :P
2017-03-08 06742, 2017
7:45 AM
samj1912
I know, I know :P
2017-03-08 06756, 2017
7:45 AM
samj1912
the overhead while handling images > text
2017-03-08 06702, 2017
7:46 AM
antlarr
I guess so
2017-03-08 06722, 2017
7:46 AM
samj1912
the PR has already grown to a very large size :P
2017-03-08 06736, 2017
7:46 AM
antlarr
I KNOW
2017-03-08 06750, 2017
7:46 AM
samj1912
:P
2017-03-08 06755, 2017
7:46 AM
antlarr
(not shouting, just emphasizing it :) )
2017-03-08 06704, 2017
7:48 AM
samj1912
atleast its not moving in the wrong direction
2017-03-08 06755, 2017
7:49 AM
samj1912
I feel its been improved a lot since you first started
2017-03-08 06714, 2017
7:50 AM
samj1912
and the PR does add some nice functionality Id like to have in 1.4.1
2017-03-08 06711, 2017
7:51 AM
antlarr
btw, I started it 20 days ago :)
2017-03-08 06740, 2017
7:54 AM
samj1912
the larger the PR the more the time it takes to be merged :P
2017-03-08 06757, 2017
8:10 AM
antlarr
hehe
2017-03-08 06715, 2017
8:11 AM
antlarr
and the more it takes to be merged, the larger it gets :D
2017-03-08 06720, 2017
8:13 AM
amanmehta joined the channel
2017-03-08 06726, 2017
8:13 AM
samj1912
lol :P
2017-03-08 06703, 2017
8:14 AM
samj1912
its a vicious cycle ;)
2017-03-08 06708, 2017
8:17 AM
hibiscuskazeneko has quit
2017-03-08 06703, 2017
8:19 AM
hibiscuskazeneko joined the channel
2017-03-08 06735, 2017
8:19 AM
github joined the channel
2017-03-08 06735, 2017
8:19 AM
github
[picard] samj1912 opened pull request #646: PICARD-1005: Fix drag'n'drop behaviour on blank targets (master...dropcluster)
https://git.io/vyu3v
2017-03-08 06735, 2017
8:19 AM
github has left the channel
2017-03-08 06739, 2017
8:22 AM
samj1912
zas fixed the cluster drag and drop problem
2017-03-08 06728, 2017
8:26 AM
arbenina_ joined the channel
2017-03-08 06709, 2017
8:29 AM
agemcipe has quit
2017-03-08 06724, 2017
8:30 AM
agemcipe joined the channel
2017-03-08 06708, 2017
8:49 AM
agemcipe has quit
2017-03-08 06708, 2017
9:02 AM
UmkaDK joined the channel
2017-03-08 06748, 2017
9:02 AM
CatCat has quit
2017-03-08 06728, 2017
9:07 AM
CatCat joined the channel
2017-03-08 06757, 2017
9:12 AM
adesh joined the channel
2017-03-08 06717, 2017
9:14 AM
lazka joined the channel
2017-03-08 06721, 2017
9:17 AM
samj1912
testing what gh:p#100,1000 returns
2017-03-08 06737, 2017
9:17 AM
samj1912
hmm.. gh:P#100,1000
2017-03-08 06738, 2017
9:17 AM
BrainzBot
2017-03-08 06703, 2017
9:18 AM
samj1912
BrainzBot: gh:p=picard
2017-03-08 06703, 2017
9:18 AM
BrainzBot
Successfully stored the repo picard as p for Github lookups
2017-03-08 06730, 2017
9:54 AM
hibiscuskazeneko has quit
2017-03-08 06718, 2017
10:08 AM
samj1912
!m antlarr
2017-03-08 06719, 2017
10:08 AM
BrainzBot
You're doing good work, antlarr!
2017-03-08 06735, 2017
10:10 AM
antlarr
2017-03-08 06752, 2017
10:10 AM
antlarr
it emits the signal on each change, as it "should"
2017-03-08 06733, 2017
10:11 AM
samj1912
antlarr: we can combine all of those calls, no?
2017-03-08 06735, 2017
10:11 AM
antlarr
hmm, I'll do the same trick of disabling the processing
2017-03-08 06743, 2017
10:11 AM
antlarr
as I do when an album finishes loading
2017-03-08 06745, 2017
10:11 AM
antlarr
yep
2017-03-08 06719, 2017
10:16 AM
adesh has quit
2017-03-08 06706, 2017
10:17 AM
agentsim has quit
2017-03-08 06742, 2017
10:17 AM
agentsim joined the channel
2017-03-08 06759, 2017
10:19 AM
antlarr
fixed
2017-03-08 06726, 2017
10:22 AM
agentsim has quit
2017-03-08 06740, 2017
10:22 AM
agentsim joined the channel
2017-03-08 06751, 2017
10:25 AM
Gentlecat
bitmap: awesome!
2017-03-08 06702, 2017
10:58 AM
lazka_ joined the channel
2017-03-08 06747, 2017
11:00 AM
lazka has quit
2017-03-08 06720, 2017
11:07 AM
github joined the channel
2017-03-08 06720, 2017
11:07 AM
github
[acousticbrainz-server] nupurbaghel opened pull request #228: AB-71 Make back button work in dataset editor + AB-95 Browsing a dataset messes with browsers' back button (master...backbutton)
https://git.io/vyuaR
2017-03-08 06720, 2017
11:07 AM
github has left the channel
2017-03-08 06701, 2017
11:11 AM
reosarevok
bitmap: yay errors! (wait. no. but yay)
2017-03-08 06707, 2017
11:12 AM
samj1912
zas ill merge gh:P#646?
2017-03-08 06708, 2017
11:12 AM
BrainzBot
2017-03-08 06731, 2017
11:13 AM
samj1912
tested it, works as expected, the only time IMO the target should be moved to unmatched files is when we are adding new files, and the code is already present in tagger.add_files
2017-03-08 06710, 2017
11:14 AM
loominol has quit
2017-03-08 06740, 2017
11:14 AM
zas
samj1912: i tested it, it looks ok to me, at least the behavior is more logical now. So, yes, merge it.
2017-03-08 06702, 2017
11:15 AM
samj1912
1 sec
2017-03-08 06705, 2017
11:15 AM
loominol joined the channel
2017-03-08 06708, 2017
11:15 AM
samj1912
let me add 1 line of debug
2017-03-08 06727, 2017
11:15 AM
zas
I'm testing gh:P#642 atm, a lot of new changes
2017-03-08 06727, 2017
11:15 AM
BrainzBot
2017-03-08 06726, 2017
11:16 AM
samj1912
yeah
2017-03-08 06726, 2017
11:16 AM
samj1912
a lot
2017-03-08 06728, 2017
11:16 AM
samj1912
:P
2017-03-08 06701, 2017
11:18 AM
samj1912
zas I think antlarr has to still decide about the order and behaviour of album CA image when they differ across related tracks
2017-03-08 06723, 2017
11:20 AM
agentsim has quit
2017-03-08 06756, 2017
11:20 AM
agentsim joined the channel
2017-03-08 06726, 2017
11:23 AM
github joined the channel
2017-03-08 06726, 2017
11:23 AM
github
[picard] samj1912 closed pull request #646: PICARD-1005: Fix drag'n'drop behaviour on blank targets (master...dropcluster)
https://git.io/vyu3v
2017-03-08 06726, 2017
11:23 AM
github has left the channel
2017-03-08 06733, 2017
11:24 AM
antlarr
2017-03-08 06759, 2017
11:24 AM
agentsim has quit
2017-03-08 06745, 2017
11:25 AM
samj1912
I'd prefer the red tint thing of the stack thing with an ≠ sign
2017-03-08 06751, 2017
11:25 AM
samj1912
s/of/or
