#metabrainz

antlarr: just update_metadata_images(obj) then, and we can avoid state altogether and make then into variables? they are just 3 variables right?

nop, 6 variables in the general case

(look at Album)

also, boolean variables are not passed by reference, so... how would you change that inside process_images if they're not part of a class?

and even more, The whole state-machine concept is better represented by a state class in my opinion

I would move the three methods to a common one in order to deduplicate code, but I don't think the State class should be removed

hmm, not a fan of nested functions and classes

can't think of a better way right now

zas, Mineo ^?

samj1912: is this what you wanted http://pastebin.com/Std6e7FL ?

(with respect to an ImageList class)

(just trying to save me some possible commit fixes/reverts...)

antlarr: 👍

antlarr: +1

cool, thanks :)

Notes from last Monday's meeting are now up: https://community.metabrainz.org/t/notes-from-m...

is it sir or mb-solrquerywriter that _creates_ the _store field containing the MMD XML metadata format?

alastairp: what exactly would we have to do to get jenkins working for LB?

iliekcomputers: not much. You just need to make sure that https://gist.github.com/gentlecat/f2395947eb28f... can run

like critiquebrainz, we could just have a separate docker compose file (or could we use the integration test one???), and maybe a separate Dockerfile which installs any of the test tools that we need

that script would have to be modified to run unit and integration tests

antlarr build failing with latest push

Circular dependencies?

<BANG>

🙋

A bundle of DRs on the menu today. Mmm.

samj1912: Go!

Hi

hi! :)

Nothing much to report this week, did PR reviews and just submitted my Gsoc proposal draft. Was out most of the week for vacation.

Freso go

🙋

I facilitated a Google Code-in mail and apart from that mostly kept up with IRC and forums.

I came to Sweden on Tuesday and also got my passport renewed on Tuesday. Should be able to pick up my new passport this week. 🙏🏼

I've spent a fair amount of time this week working on the slides, and my presentation in general, for my talk at Open Source Days this just-past Saturday.

\o

And then I spent this just-past Saturday at Open Source Days in Copenhagen, giving a talk.

I'm trying to get a link to the slides on Google Drive right now, but it's being slow. :|

I will add it to the Presentations WikiPage later.

fin.

CatQuest: 🙋

\o/

I asked and was told that it's ok for me to create "Fix Versions" so now I can group instrument tickets into batches. This will let me group things and set aside the "hard" ones from the "easy" ones so I can get those done faster and hopefully whittle down the list of tickets so only the actual difficult DR ones remain.

also creating "do all these in this group" groups which are decidedly smaller than the entire list helps things from feeling too overwhelming.

o if you've got a INST ticket that's _straightforward_ and important to you, you can put Fix Version as "next" on it (I reserve the right to alter it, of course :D)

(Slide 9 is "Alot of Brainz")

aha

also if Instrument families and variants interest you: https://community.metabrainz.org/t/instrument-f...

finitare!

next is.. gcilou?

Pass for me :)

damn, ok

uhm..

yvanzo?

hi

<3 Alot of Brainz

I started with grasping a variety of MeB accounts and tools.

I also made auto-edit issues archaeology and implemented MBS-8134.

MBS-8134: Allow unreviewed edits on new entries for a period of time https://tickets.metabrainz.org/browse/MBS-8134

On reosarevok's request, I coded a small enhancement with a bugfix to change artist credits in the relationship editor.

reosarevok, your turn :)

(Still up: ferbncode Gentlecat ruaok bitmap Quesito iliekcomputers; possibly: LordSputnik Leftmost Leo_Verto alastairp; who did I miss?)

Freso: you hould totes credit your gf for that a lot, it's awesome :D

alot*

reosarevok: +100

Other than that, I'm right now answering https://community.metabrainz.org/t/style-747-ev... and hoping to get some proper discussion on events up with that

That's about it I'd say, other than just editing

ferbncode: go?

hi!

CatQuest: Yeah, I agree.

nothing much..opened a quite big PR for migrating reviews off ORM. Part of CB-230.also, working on more migration :)

CB-230: Migrate away from the SQLAlchemy ORM https://tickets.metabrainz.org/browse/CB-230

I am trying something with the docker setup for the musicbrainz database. hope to get something basic done :)

Quesito: go!

Hi!

Mostly verbiage work on the MeB site last week for me. I’ll be needing some help this week, as far as other eyes reading/editing/commenting.

Mostly verbiage work on the MeB site last week for me. I’ll be needing some help this week, as far as other eyes reading/editing/commenting.

I’ve come up with a general workflow of verbiage edits for the project pages (upcoming), mostly to be time efficient for the developers involved.

More learning of the ins and outs of jira, which will also continue this week. Worked a bit with Leo_Verto on the MB user survey, in hope we get some really good feedback.

Quesito, I'm a good proofreader!

Noted Leftmost! You will be tasked! :)

oh yes, I did a bit of leo verto feedback too , forgot to mention :o

Chatted with iliekcomputers about his gsoc proposal, but I didn’t explain my idea very clearly at the time--so I quickly gathered my thoughts together and posted it to the forum.

So far that’s crickets, but I’m holding out hope for some feedback.

link plox?

And I'm continuing trying to open up my workflow to make it more transparent

fin!

wow those visulas :o

Leftmost: Go!

nupurbaghel_ (~nupurbagh@106.222.183.175) has joined #metabrainz

(Still up: Leo_Verto Gentlecat ruaok bitmap iliekcomputers; possibly: LordSputnik alastairp; who did I miss?)

reosarevok has changed the topic to: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC Getting Started: https://goo.gl/JTNkn0 | MeB meeting agenda: reviews, DR: MBS-7133 (yvanzo), DR: MBS-7108 (yvanzo); next week: DR: CB-244 (Gentlecat), Picard feat. plugin (reo)

(is that DR really next week?)

Quesito: Leftmost said he had no update. :) Leo_Verto, go!

reosarevok: Gentlecat moved it at the beginning of the meeting, so I guess?

oops!

Oh, ok

reosarevok has changed the topic to: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC Getting Started: https://goo.gl/JTNkn0 | MeB meeting agenda: reviews, DR: MBS-7133 (yvanzo), DR: MBS-7108 (yvanzo), Picard feat. plugin (reo); next week: DR: CB-244 (Gentlecat)

reosarevok: one that I added, yes. don't feel like discussing it today

Ok :)

No Leo_Verto?

Seems like it. :/

Gentlecat: Go!

rembo10_ (~rembo10@2a01:4f8:c17:5b49::2) has joined #metabrainz

Sorry

IRC crashed

I spent the last week continuing working on Botbot and took up work on the survey again (thanks CatQuest and Quesito)

__shymega__ (~shymega@shymega.vps.bitfolk.com) has joined #metabrainz

I spent the last few days doing IRL stuff after getting home again but will continue what I started this week

djinni`_ (~djinni@68.ip-149-56-14.net) has joined #metabrainz

d4rkie (~D4RK-PH0E@104.254.90.187) has joined #metabrainz

Gentlecat: go!

I finished implementing trigger generation for SIR. Just need to test them now.

🙌

Tyklol (tykling@znc.tyknet.dk) has joined #metabrainz

tested imports in listenbrainz and opened some tickets related to that

:)

esmiurium (U2FsdGVkX1@ma.sdf.org) has joined #metabrainz

and reviewed some things, as usual

bitmap: ?