note that the file IS saved, just that the File state is set to CHANGED instead of NORMAL
2017-03-24 08340, 2017
antlarr
should I commit the change I proposed there?
2017-03-24 08305, 2017
antlarr
(in any case, as you see from that description, that's not related at all to my PR)
2017-03-24 08307, 2017
samj1912
hmm, I have same images to tags checked however, just that, I dont have any CA
2017-03-24 08312, 2017
antlarr
you don't have any CA, so metadata.images is empty while orig_metadata.images contains the covers from the file tags
2017-03-24 08323, 2017
antlarr
so they are different, so it's marked as CHANGED
2017-03-24 08303, 2017
samj1912
that is fine, however, I atleast want it to be displayed as saved
2017-03-24 08319, 2017
samj1912
it might cause issues otherwise
2017-03-24 08337, 2017
antlarr
the mark doesn't mean "saved"
2017-03-24 08303, 2017
samj1912
but that is how it is interpreted by most people
2017-03-24 08306, 2017
antlarr
the mark means the file status is NORMAL, which usually happens when you load a file that is OK, or when you save it
2017-03-24 08319, 2017
samj1912
yes, I know
2017-03-24 08346, 2017
samj1912
most people associate that mark with saving finished
2017-03-24 08348, 2017
antlarr
I don't think we should force a NORMAL status after saving no matter what the metadata is
2017-03-24 08325, 2017
samj1912
hmm, I am not so sure about that :\
2017-03-24 08334, 2017
samj1912
zas: ^^ any thoughts?
2017-03-24 08350, 2017
antlarr
what about changing "if self.metadata.images != self.orig_metadata.images:" to "if self.metadata.images and self.metadata.images != self.orig_metadata.images:" in https://github.com/metabrainz/picard/commit/f99ab… ?
2017-03-24 08301, 2017
samj1912
yup
2017-03-24 08306, 2017
samj1912
that is what I was asking for
2017-03-24 08333, 2017
samj1912
since when we call metadata.copy
2017-03-24 08349, 2017
samj1912
if metadata.images is empty, it just retains the old ones
Freso: Can we add to Monday's discussion a suggestion that we add Travis support to Picard-Plugins and document how plugins can use Assert statements to perform unit tests.
2017-03-24 08318, 2017
CatQuest joined the channel
2017-03-24 08318, 2017
Freso
Sophist: Sure, go ahead and add it.
2017-03-24 08301, 2017
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC Getting Started: https://goo.gl/JTNkn0 | MeB meeting agenda: next week: DR: CB-244 (Gentlecat), Picard feat. plugin (reo), picard-plugins issue tracking & Travis (Freso, Sophist), DR: OTHER-290 (Freso)
2017-03-24 08347, 2017
suhas2go[m] joined the channel
2017-03-24 08359, 2017
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC Getting Started: https://goo.gl/JTNkn0 | MeB meeting agenda: next week: DR: CB-244 (Gentlecat), Picard feat. plugin (reo), picard-plugins issue tracking (Freso), DR: OTHER-290 (Freso), picard-plugins & Travis (Sophist)
2017-03-24 08343, 2017
arbenina_ joined the channel
2017-03-24 08306, 2017
D4RK-PH0ENiX has quit
2017-03-24 08308, 2017
github joined the channel
2017-03-24 08308, 2017
github
[picard] zas closed pull request #657: PICARD-1001, PICARD-1014, PICARD-1015, PICARD-1016, PICARD-1018: Fix album cover art corner cases (master...fix-album-cover-art-corner-cases) https://git.io/vyXg2
2017-03-24 08308, 2017
github has left the channel
2017-03-24 08305, 2017
antlarr
zas: thanks!
2017-03-24 08332, 2017
zas
antlarr: i just pressed a button, you did all the work, so thanks to you ;)
2017-03-24 08352, 2017
antlarr
hehe
2017-03-24 08307, 2017
travis-ci joined the channel
2017-03-24 08308, 2017
travis-ci
metabrainz/picard#2202 (master - 075b678 : Laurent Monin): The build passed.
