antlarr: make a PR for context menu, to keep track at least. That said it is a nice feature that complete the last CA changes, since 2.0 is far, i would not mind include it in 1.4.1, if it is simple enough and well tested (today but not later).
2017-03-24 08310, 2017
github joined the channel
2017-03-24 08310, 2017
github
[picard] antlarr opened pull request #663: Add cover art context menu and "keep original images" option (master...cover-art-context-menu) https://git.io/vSUXm
2017-03-24 08310, 2017
github has left the channel
2017-03-24 08327, 2017
zas
Fast ;)
2017-03-24 08354, 2017
antlarr
hehe, you said the magic words "I would not mind include it in 1.4.1" :D
2017-03-24 08321, 2017
zas
samj1912: can you test it right now ? I will on my side ASAP.
2017-03-24 08300, 2017
samj1912
Yup
2017-03-24 08356, 2017
ruaok
iliekcomputers: chinese man, gramatik? in an awesome graph?
antlarr, samj1912: i think we should make the option name more generic, i can imagine other ways to add a remote image than drag'n'drop. What do you think ? Since option name is hidden from normal users, i think it will just be more future-proof (imagine, for example, we add an input field to enter the URL of the remote image in addition of d'n'd)
2017-03-24 08309, 2017
ruaok
zas: did you get the new metabrainz cert?
2017-03-24 08347, 2017
zas
ruaok: it is available on gandi interface, i didn't deploy it yet
2017-03-24 08356, 2017
zas
i will this afternoon
2017-03-24 08310, 2017
ruaok
ok, great.
2017-03-24 08316, 2017
Lotheric_ is now known as Lotheric
2017-03-24 08317, 2017
zas
you renewed only *.meb.o right ?
2017-03-24 08329, 2017
rajat has quit
2017-03-24 08357, 2017
ruaok
correct
2017-03-24 08301, 2017
antlarr
zas: I think the general dialog in 2.0 should have add/remove as most dialogs have, and this option could also be used for dropped images in the info dialog
2017-03-24 08334, 2017
antlarr
so in general, you add images, and remove the ones you don't want, in order to replace them
2017-03-24 08314, 2017
zas
it makes sense, but we could also "manually" enter the URL right ? So the option isn't really specific to drag'n'drop behavior, but to load remote image behavior.
2017-03-24 08355, 2017
antlarr
but you would enter the url when choosing to "add" an image, isn't it?
2017-03-24 08317, 2017
antlarr
maybe the dialog could even have add/remove/replace buttons
2017-03-24 08327, 2017
antlarr
so it would be even more straightforward
2017-03-24 08336, 2017
zas
hmmm yes. Let's see what samj1912 thinks about this stuff.
2017-03-24 08306, 2017
antlarr
ok
2017-03-24 08323, 2017
antlarr
btw, "Use original images" ? or "Keep original images"?
2017-03-24 08328, 2017
zas
Keep is more explicit to me (but i'm far from english native.... even far from english speaking, lol)
2017-03-24 08351, 2017
reosarevok
If that means "do not remove the existing ones", then keep
2017-03-24 08310, 2017
samj1912
IMHO makes sense to generalize and future proof the option name
2017-03-24 08343, 2017
antlarr
reosarevok: thanks, I'll change that to "Keep" then
2017-03-24 08341, 2017
samj1912
antlarr zas if you have a better option name alternative that is verbose and more generalized, then that, otherwise we can just add upgrade hooks :)
2017-03-24 08328, 2017
zas
this is what i'm trying to avoid (more hooks) ;)
2017-03-24 08351, 2017
samj1912
load_remote_image_behavior sounds good to me :)
2017-03-24 08304, 2017
samj1912
load_image_behavior, sorry
2017-03-24 08319, 2017
antlarr
isn't that too generic?
2017-03-24 08302, 2017
antlarr
I mean, wouldn't setting that to "append" mean that Metadata.update should append images too in update ?
2017-03-24 08348, 2017
samj1912
hmm, well it is true that if we ever do add a text entry option to load images or a file picker, we could have a add/remove/set front image UI flow
2017-03-24 08304, 2017
samj1912
s/could/would
2017-03-24 08339, 2017
nupurbaghel has quit
2017-03-24 08309, 2017
nupurbaghel joined the channel
2017-03-24 08302, 2017
samj1912
antlarr: the PR in terms of code looks good/bug free :) made a few comments about code-style issues, but apart from that, 👍 from me
(btw, I still think that set_image has a "replace" meaning and find it strange that set_image can append the image in some case. zas, are you sure you don't prefer process_image ? )
is it the same bug as Qt dragndrop with NSURL being passed instead of file path?
2017-03-24 08341, 2017
nupurbaghel has quit
2017-03-24 08325, 2017
zas
antlarr: can you create matching ticket(s) for pr/663 ?
2017-03-24 08339, 2017
samj1912
ruaok: do we have plans for more *Brainz? :P
2017-03-24 08355, 2017
samj1912
thinking along the lines of moviebrainz.tvbrainz
2017-03-24 08359, 2017
antlarr
zas: as an improvement? or a bug for missing features to replace/add images ?
2017-03-24 08315, 2017
zas
Improvement
2017-03-24 08328, 2017
antlarr
hehe, ok
2017-03-24 08356, 2017
samj1912
zas: what are the current plans for 1.4.1?
2017-03-24 08341, 2017
lazka has quit
2017-03-24 08312, 2017
reosarevok
samj1912: ideally? yes. In practice? not any time soon, because you might have noticed BookBrainz is slow enough to get off the ground without adding more projects ;)
2017-03-24 08309, 2017
samj1912
ah yes :P
2017-03-24 08359, 2017
ruaok
we need to get our existing brainzes to critical mass before starting new ones.
2017-03-24 08310, 2017
zas
samj1912: just merge pr/663 and we're done with it, so apart minor fixes or code redundancy reduction, no more PRs, release on 1st April. A call for translators needs to be made after this PR.
2017-03-24 08347, 2017
samj1912
zas: cool :), freeze today then?
2017-03-24 08351, 2017
antlarr
zas: PICARD-1030, I think I added all references where they belong
yup :), better multi tasking and responsive ui with qt5/py3 for starters :P
2017-03-24 08301, 2017
github joined the channel
2017-03-24 08301, 2017
github
[picard] zas closed pull request #663: PICARD-1030: Add cover art context menu and "keep original images" option (master...cover-art-context-menu) https://git.io/vSUXm
2017-03-24 08301, 2017
github has left the channel
2017-03-24 08356, 2017
samj1912
I have been reading a lot about python black magic the last week - decorators/metaclasses etc :P
2017-03-24 08329, 2017
samj1912
also python design patterns to improve my code quality
2017-03-24 08314, 2017
samj1912
currently reading up on asyncio and advanced multithreading/processing
2017-03-24 08313, 2017
travis-ci joined the channel
2017-03-24 08314, 2017
travis-ci
metabrainz/picard#2208 (master - 839811b : Laurent Monin): The build passed.
2017-03-24 08314, 2017
samj1912
any recommendations? I have been using "Mastering Python" as a guide
