can you make a PR with these changes you are making?
2017-03-29 08809, 2017
Gentlecat
it would be easier to debug
2017-03-29 08859, 2017
Quesito
CatQuest: I see your notes! go ahead and utilize another column if you'd like to add more!
2017-03-29 08809, 2017
github joined the channel
2017-03-29 08809, 2017
github
[listenbrainz-server] mayhem opened pull request #158: [WIP] Trying to fix the tests for jenkins (master...fix-tests-for-jenkins) https://git.io/vS3ZM
2017-03-29 08809, 2017
github has left the channel
2017-03-29 08816, 2017
ruaok
Gentlecat: ^^
2017-03-29 08832, 2017
zas
samj1912: can you check picard website, i tagged last version just before changes for 1.4.1 links as prod, and made changes in deployement scripts accordingly
2017-03-29 08808, 2017
samj1912
zas 👍
2017-03-29 08852, 2017
ruaok
Gentlecat: so the --junit args need to only be in docker compose, not in test.sh?
ruaok: tomorrow afternoon works for invoice magic hours...let me know what time work for you
2017-03-29 08829, 2017
ruaok
3pm or 4pm should be fine.
2017-03-29 08847, 2017
Gentlecat
syntax of the compose file might be incorrect
2017-03-29 08831, 2017
ruaok
works in test.sh
2017-03-29 08833, 2017
Gentlecat
not sure if command can be split up with "\"
2017-03-29 08802, 2017
ruaok
I can try removing it and re-pushing...
2017-03-29 08805, 2017
Gentlecat
`ERROR: file not found: --cov-report`
2017-03-29 08845, 2017
ruaok
pushed.
2017-03-29 08853, 2017
ruaok
why wou;dn
2017-03-29 08859, 2017
ruaok
't it get an error locally?
2017-03-29 08842, 2017
Guest82819 joined the channel
2017-03-29 08842, 2017
Guest82819
[listenbrainz-server] mayhem closed pull request #157: LB-145: Add artist_msid to data received from api (master...api/missing-artist-msid) https://git.io/vSYAq
this back and forth isn't an effective use of your time nor mine.
2017-03-29 08838, 2017
D4RK-PH0ENiX joined the channel
2017-03-29 08841, 2017
Gentlecat
I don't know what the problems are
2017-03-29 08852, 2017
Gentlecat
or, rather, solutions
2017-03-29 08800, 2017
ruaok
I have far less of a clue than you do.
2017-03-29 08803, 2017
Gentlecat
I look at the output and help you debug it
2017-03-29 08812, 2017
ruaok
I would have to spend hours reading to catch up on this stuffl.
2017-03-29 08820, 2017
ruaok
you are at least familiar with these things.
2017-03-29 08821, 2017
Gentlecat
same
2017-03-29 08835, 2017
ruaok
for instance, "inifile:" I have no idea what that even means.
2017-03-29 08841, 2017
Gentlecat
you decided to do it differently for LB, so I'm unfamiliar with the setup
2017-03-29 08844, 2017
ruaok
what part of this complex chain this might refer to.
2017-03-29 08856, 2017
Gentlecat
it's from the output I linked
2017-03-29 08859, 2017
ruaok
ok, well I've lost my interest in doing this.
2017-03-29 08811, 2017
ruaok
just kill this shit from jenkins. I don't really care, I'll run tests by hand.
2017-03-29 08815, 2017
ruaok
thanks for helping.
2017-03-29 08822, 2017
Gentlecat
...
2017-03-29 08834, 2017
arbenina_ joined the channel
2017-03-29 08823, 2017
d4rkie has quit
2017-03-29 08804, 2017
UmkaDK_ joined the channel
2017-03-29 08832, 2017
UmkaDK has quit
2017-03-29 08847, 2017
Gentlecat
tests are not being run since it doesn't see the pytest.ini file
2017-03-29 08850, 2017
Gentlecat
don't know why
2017-03-29 08852, 2017
D4RK-PH0ENiX has quit
2017-03-29 08819, 2017
D4RK-PH0ENiX joined the channel
2017-03-29 08847, 2017
CatQuest
Quesito: nah, I just commented on eeevrytfing instead :P
2017-03-29 08824, 2017
yvanzo
reosarevok: Simplicity, those are independent. We already do have separate tables by entity type for edits, annotations, aliases, and so on.
2017-03-29 08838, 2017
yvanzo
About languages, yes, one issue is that we should not duplicate the data into attribute types whereas there already is a global list of languages.
2017-03-29 08849, 2017
yvanzo
Another point is that languages and locales should probably be handled differently in the future, that is, in another schema change.
2017-03-29 08800, 2017
yvanzo
Finally, I still wonder if we really need languages into attributes at all. I mean, languages/locales are already defined for appropriate entity types (Release & Work) and should probably not be pushed to a position of secondary information. The only benefit would be for URL language/locale (?) which would be better implemented separately.
2017-03-29 08837, 2017
reosarevok actually wonders how bitmap is dealing with language/script for releases while implementing multiple tracklists
2017-03-29 08834, 2017
iliekcomputers has quit
2017-03-29 08857, 2017
ferbncode has quit
2017-03-29 08827, 2017
rahulr has quit
2017-03-29 08812, 2017
yvanzo
We already have redundant data by having separate definition for language, script and locales (which inlude language information already and potentially script information too).
2017-03-29 08812, 2017
ferbncode_ joined the channel
2017-03-29 08848, 2017
Freso
ruaok: (re: Google list), maybe they just "forgot"? Did you write them and ask?
2017-03-29 08804, 2017
ruaok
I didn't. we may not be significant enough.
2017-03-29 08828, 2017
ruaok
i'll leave it to you to follow up. you know peeps. :)
