Wait, but i will be writing js code so the tests will be in a js framework right?
2017-04-02 09259, 2017
justharshal
LordSputnik: Were you suggesting that the logic remains same so rewriting will be much faster? If so, i agree.
2017-04-02 09203, 2017
LordSputnik
Yes, but the expected responses from the API will still be similar, even if the code isn't, so you'll have a good idea of what to test, even if you can't reuse the code
2017-04-02 09208, 2017
LordSputnik
yeah
2017-04-02 09256, 2017
LordSputnik
The existing tests are a little complicated, so you'll probably want to spend a day learning them later on
2017-04-02 09237, 2017
LordSputnik
(we probably wouldn't want them object-oriented again, since inheritance makes it harder to see what's going on in the actual tests)
2017-04-02 09259, 2017
LordSputnik
although it was an interesting and creative idea at the time from one of our GCI students
2017-04-02 09216, 2017
justharshal
Alright, i'll look into it after the proposal.
2017-04-02 09235, 2017
github joined the channel
2017-04-02 09235, 2017
github
[musicbrainz-server] yvanzo opened pull request #501: MBS-8640: Make adding work attribute auto-edit (master...mbs-8640-auto-attribute) https://git.io/vS8J1
2017-04-02 09235, 2017
github has left the channel
2017-04-02 09239, 2017
Zastai has quit
2017-04-02 09238, 2017
ZarkBit joined the channel
2017-04-02 09248, 2017
UmkaDK has quit
2017-04-02 09255, 2017
deeptibaghel has left the channel
2017-04-02 09241, 2017
UmkaDK joined the channel
2017-04-02 09223, 2017
arbenina_ joined the channel
2017-04-02 09235, 2017
UmkaDK has quit
2017-04-02 09245, 2017
UmkaDK joined the channel
2017-04-02 09205, 2017
arbenina_ has quit
2017-04-02 09220, 2017
zas
ruaok: Picard 1.4.1 release didn't bring us much more traffic, no one noticed the "bug" in the blog post. And yes, i didn't forget about those damn analytics, i'm just not that happy when "solutions" we came up with, hence a certain lack of motivation on my side.
2017-04-02 09236, 2017
arbenina_ joined the channel
2017-04-02 09208, 2017
UmkaDK has quit
2017-04-02 09220, 2017
UmkaDK joined the channel
2017-04-02 09227, 2017
Sophist-UK
zas: Perhaps we should add functionality to Picard to check for version updates when it starts (say) once per week and advise the user that an upgrade is available - or even download it and then quit and execute it.
2017-04-02 09254, 2017
zas
Yes, for notifying user, but auto-download/install may lead to various issues i'm not sure we want to handle. As usual, create a ticket and let's see if someone comes up with a working PR ;)
2017-04-02 09200, 2017
justharshal has quit
2017-04-02 09246, 2017
samj1912 has quit
2017-04-02 09243, 2017
suhas2go has quit
2017-04-02 09235, 2017
psolanki joined the channel
2017-04-02 09233, 2017
psolanki
I have rephrased my proposal. I am still trimming the language, UI and timeline but would be really grateful if you could provide feedback on idea and structure of proposal before deadline