#metabrainz

[picard-plugins] zas closed pull request #92: New paper CD case plugin (master...papercdcase) https://git.io/vSR8c

Cool, I think there is some data i could use from MB for sure

zas, we really should shift to decorators for plugin registration :p

And other plugin enhancements

samj1912: yup

Hmm, I should write all the plugin stuff down somewhere

To keep track

more venue data? \o/

sadface

iliekcomputers__: https://gist.github.com/mayhem/e04261ddb33d52f9...

:)

two spam accouunts on oslo again

iliekcomputers__: when you get back, lets chat about the JSON. :)

@sam1912: A JIRA ticket? (just kidding)

ruaok: did I mess something up?

> "work_mbids": ["fdjkaljfadkl"],

p.s. How would the plugin decorator look? Can you give an example?

that is why the data is rejected. which is good.

but why are slashes escaped in the URL?

that is a problem.

samj1912: would you have time to review / merge PICARD-1034 https://github.com/metabrainz/picard/pull/667

PICARD-1034: Picard not seeing TOPE and TOAL https://tickets.metabrainz.org/browse/PICARD-1034

Sophist-UK lgtm

I'll let zas merge it however

We are introducing new tags and I'd like to know his opinion on the matter

Is that json from the alpha importer logs? We don't really do anything to the data there. I don't know why it is escaped.

Ok.

iliekcomputers__: yes. we need to track that down and figure out why that is happening.

[picard] samj1912 closed pull request #666: PICARD-1034: Add support for TOAL id3 frame (master...picard1034) https://git.io/vSsfB

ruaok: okay. Will do tonight.

iliekcomputers__: thx

Hello everyone

So I talked to ruaok about joining forces, I will provide all the venue data you need and keep it updated in your site regularly with the fields you need

And I asked him if there was a way I could in exchange use some venues data for the venue map of my site

?

samj1912, I had been updating the packaging recipes on launchpad.net in the past. but this is all a bit outdated now. not sure if somebody already touched this for the 1.4 release

but at least it needs to be migrated to the new git repo there

outsidecontext: I dont have much experience with packaging picard debs, I can continue maintaining it if you can give me a few pointers and access right to package :)

I can set this up again so we have the packaging recipes running again. after that it is easy to update

would be good if you become a member of https://launchpad.net/~musicbrainz-developers , AFAIK only luks can approve you there

I applied for it :)

waiting for approval

I will have a few free evenings the next days, will setup the packaging then

cool :D

thanks a bunch! :D

sam1912: Now that we have qt5 merged I need to install it for python2 on windows - but apparently there is only a binary version available for Py3, and for Py2 you have to compile it yourself. So I need to find a MS C++ compiler and try to do this. My question is whether this is an issue for future maintenance versions of 1.4.x for anyone who runs Picard from source ? I presume we have done

the necessary compilations for Travis.

Sophist-UK: travis compiles just fine for the current master

that was one of the reasons we added docker

yes, I know building qt5 for py2 might be a bit of a pain

if you want to wait for a couple of weeks, I will have the py3 version up

I can wait - however we should decide whether the 1.4.x branch will run PyQt5 or not - because if it will then we will probably all need to do the compile in order to support it.

And if we decide not to use Qt5 in 1.4.x then we need to do the Git magic to split it off prior to merge of #503 and start cherry picking.

Sophist-UK: 1.4.X is going to be strictly qt4

Sophist-UK: we already have dont that?

see https://github.com/metabrainz/picard/tree/1.4.x

https://github.com/metabrainz/picard the master is already on qt5 and 2.0 dev

I do not think people use qt5 with py2 :P

its a very very rare combo :P

thus the lack of binaries and support :P

Yes - just looked. Are there any PRs which need merging into 1.4.x? #671?

I'll concentrate on installing Py3 then :-)

671?

nope, that was because of merge conflicts on the master

[picard] zas closed pull request #667: PICARD-1034: Add support for loading and saving TOAL & TOPE id3 frames (master...PICARD-1034_Add-partial-TOPE-support) https://git.io/vSZ4M

zas: we should back port these changes in 1.4.X as well?

Yes, i think so, in case we release 1.4.2 before 2.0 ;)

we should mark the PRs for 1.4.X in some way in case we are not merging em immediately :P

metabrainz/picard#2266 (master - 0ca726f : Laurent Monin): The build passed.

Change view : https://github.com/metabrainz/picard/compare/a5...

Build details : https://travis-ci.org/metabrainz/picard/builds/...

samj1912: are you planning to come to the summit at end of september ?

I would like to :D

it would be great to have you among us

it would be an amazing experience for me too :D

You can add you to https://wiki.musicbrainz.org/MusicBrainz_Summit/17 at any moment (before the summit...)

added :D

hopefully ruaok can help me with the planning :P

sam1912 / zas: what is the process for e.g. applying #667 to 1.4.x? Are authors expected to resubmit against the 1.4.x branch, will one of you cherry pick?

samj1912 / zas: Can I draw your attention to PICARD-1049 to see what you guys think?

PICARD-1049: Picard should use TXXX:WORK rather than TXXX:Work https://tickets.metabrainz.org/browse/PICARD-1049

cherry-picking to 1.4.x branches, with care about py2/py3/qt4/qt5 stuff

Sophist-UK: the arguments are valid, we will have to do something about migrating the existing Work tags to WORK though

any idea what foobar2000 uses?

hmm, they dont have it

It means Picard needs to be able to read TXXX:Work as well as TXXX:WORK

And write to TXXX:WORK only

we read all TXXX tags, we will have to decide whether to be case sensitive about them or not or treat work as a special case

Yes, but what happens if we have 2 tags in the same file, TXXX:WORK and TXXX:Work...

help with travel planning

I'm starting to think we will need a consenting adult around here. question, you're a mom. You fit that bill, yes??

question? Quesito...

Si?

I'm not an adult. ;)

crap.

maybe we should put an ad in the paper.

For an adult? Possible hard to find locally....

I've only ever seen adults with gantt charts.

how do you explain that??

Just pretending!!! ;)

fake it 'til you make it.

that should be our motto.

Right?

Tots

I would suggest that on file load we see if TXXX:CaSe matches case-independently a freetext field CASE/Case/case and if so we:

a. Rename the tax in the file to the correct case; and

b. Load it into the known tag

hmmm

So it gets fixed even if user doesn't have "Clear existing tags" checked.

still the above logic applies

how to handle the case with TXXX:Work and TXXX:WORK

when both are present

Only issue is that unless there are other changes, the need to save the file will not be highlighted in the UI.

If both are present, then:

we can append?

1. If the values are the same, we can discard one.

if they are not same

2. If the values are different then we append as you suggest.

you willing to work on that?

Yes. I'll take it.

cool :)

Sophist-UK: while you are at it, are you willing to take a look at all the id3 spec tags we dont support and add a PR to read and write into those tags disregarding filling em up with MeB data

PICARD-1048?