Because it allows easily adding new "genre tags" to the list and immediately have them working
2017-04-17 10719, 2017
reosarevok
The main benefit of using a closed, not-tags-only list IMO is linkability and mbids and rels
2017-04-17 10722, 2017
yvanzo
reosarevok, bitmap: Most inconvenient shortcoming is the editing system: attributes do not have gids.
2017-04-17 10724, 2017
reosarevok
And attributes don't offer that, so
2017-04-17 10736, 2017
reosarevok
yvanzo: they should :) But that's Q4 I guess?
2017-04-17 10746, 2017
yvanzo
yes
2017-04-17 10756, 2017
reosarevok
Anyway, definitely in favour of adding IDs in more places
2017-04-17 10705, 2017
yvanzo
although it might be possible to create temporary join tables for that
2017-04-17 10733, 2017
reosarevok
CallerNo6: in general, I'd say either make them full entities that can be linked to, say, their Wikipedia page, or leave them as tags
2017-04-17 10747, 2017
reosarevok
Any in-between solutions sound like a lot of work for little practical gain
2017-04-17 10756, 2017
bitmap
gids for work attributes?
2017-04-17 10721, 2017
CatQuest joined the channel
2017-04-17 10721, 2017
reosarevok
Well, some permanent way of calling an attribute sounds reasonable, we have them for reltypes
2017-04-17 10724, 2017
bitmap
I know the types and values already have them
2017-04-17 10729, 2017
yvanzo
yes
2017-04-17 10753, 2017
yvanzo
or at least something comparable to aliases
2017-04-17 10711, 2017
bitmap is confused which table you want gids on
2017-04-17 10751, 2017
yvanzo
GIDs are not the only possible solution.
2017-04-17 10754, 2017
Freso
All of them!!
2017-04-17 10706, 2017
Freso
GIDs!! GIDs everywhere!!!
2017-04-17 10709, 2017
CallerNo6 doesn't know things. GIDs are internal only? (as opposed to MBIDs)
2017-04-17 10715, 2017
yvanzo
bitmap: The issue is more that concurrent edits of attributes can overwrite each other.
2017-04-17 10749, 2017
bitmap
hmm
2017-04-17 10711, 2017
yvanzo
CallerNo6: MBIDs are GIDs, the reverse is not true.
2017-04-17 10736, 2017
bitmap
can't use locking?
2017-04-17 10738, 2017
CatCat approves more entities
2017-04-17 10713, 2017
CatCat
but that DR about changing all credits :/
2017-04-17 10729, 2017
CatCat
i want the feature to be able to edit all credits no matter what :O
2017-04-17 10732, 2017
yvanzo
Actually aliases don't have GIDs either and don't have this issue.
2017-04-17 10756, 2017
yvanzo
bitmap: What is probably lacking is specific edit types for editing attributes.
2017-04-17 10759, 2017
CatCat
aliases aren't like dyn.atrib. though...
2017-04-17 10719, 2017
reosarevok
yvanzo: can't all edits overwrite each other? Or you mean that they should conflict and fail?
2017-04-17 10734, 2017
reosarevok
In which case, shouldn't that be done by just storing the original value and comparing?
2017-04-17 10734, 2017
CatCat
they are user entered date.. not unlike tags in away, the ones what are "official anmes" could and maybe should) have gids..., but search hints.. not as much
2017-04-17 10747, 2017
yvanzo
reosarevok: Sorry, it is just that the last one wins.
2017-04-17 10753, 2017
reosarevok
(I see the attribute types have MBIDs)
2017-04-17 10712, 2017
reosarevok
Oh. I'd say maybe just do like with artist names and whatnot
2017-04-17 10718, 2017
reosarevok
If the data has changed, fail the edit
2017-04-17 10731, 2017
bitmap
I know either iswcs/isrcs or ipis/isnis use some 3-way-merge
2017-04-17 10733, 2017
CatCat agrees
2017-04-17 10734, 2017
reosarevok
Which I assume we do by just storing the original value in the edit and comparing on application
2017-04-17 10726, 2017
CatCat
anyway, the ticket was more about letting someone batch alter artist credits in the rel-editor :/
2017-04-17 10742, 2017
CatCat
(which would be a huge boon)
2017-04-17 10754, 2017
reosarevok
Which of the tickets? :)
2017-04-17 10700, 2017
CatCat
the last DR?
2017-04-17 10725, 2017
CatCat
wasnt that about the "change all " instances of artist credit
2017-04-17 10732, 2017
reosarevok
If you mean the 6666 one then I *quite* strongly disagree with that as an option
2017-04-17 10732, 2017
CatCat
in the rel ed
2017-04-17 10735, 2017
yvanzo
Ultimately, ISWC/ISRC/… will be attributes, right?
2017-04-17 10747, 2017
bitmap
probably
2017-04-17 10759, 2017
reosarevok
That'd just lead to even more people changing stuff wrongly because for some reason people like checking checkboxes even when it makes no sense if they're there :D
2017-04-17 10719, 2017
reosarevok
No, that was about edit artist credits when editing the artist name :)
2017-04-17 10731, 2017
anthony25 has quit
2017-04-17 10735, 2017
CatCat
that you can vbatch alter crreditas? heavens why? if for example I want to changella instances of This guy making trumpet whne i know for a fact that is hould be trombone (or subultimate credits, hoi) then Y noT??
2017-04-17 10703, 2017
reosarevok
No, batch-changing credits for relationships would be awesome, but it's unrelated to that, that's on edit artist pages
2017-04-17 10711, 2017
bitmap
anyway, it was IPIs and ISNIs that use MusicBrainz::Server::Edit::Role::ValueSet
2017-04-17 10721, 2017
CatCat
reosarevok: edit artist creds when editing artists?
2017-04-17 10723, 2017
bitmap
which merges the values using the current, old, and new values
2017-04-17 10736, 2017
CatCat
uh. i thought that was already unchecked by default because that's a better idea?
2017-04-17 10737, 2017
samj1912 joined the channel
2017-04-17 10738, 2017
yvanzo
There are specific edit types for adding/removing ISWC/ISRC too, so it won't be a nuisance to replace it with edit types for attributes.
2017-04-17 10741, 2017
bitmap
but I'm probably misunderstanding the issue, that might not apply
2017-04-17 10706, 2017
reosarevok
CatCat: it's unchecked by default. But it only does anything when you actually change the artist name
2017-04-17 10731, 2017
CatCat
uh.. of course? that's the actual only thing artist credits do :D
2017-04-17 10736, 2017
reosarevok
CatCat: so, if you just check a box without changing the artist name, you might think it'll do something, but it doesn't. That's why we want to hide it instead :)
2017-04-17 10738, 2017
CatCat
changing the name :D
2017-04-17 10744, 2017
bitmap
in general I'd like there to be less edit types, though they are useful for searching at present...
2017-04-17 10758, 2017
bitmap
since you can't search for edits that change a certain field
