this is no longer a technical discussion. this is now a teamwork discussion.
2017-04-26 11659, 2017
ruaok
it is Gentlecat's way or no way.
2017-04-26 11621, 2017
Gentlecat
can you elaborate on that?
2017-04-26 11643, 2017
Gentlecat
and I really want to hear from someone else if I'm causing problems
2017-04-26 11644, 2017
ruaok
you're not willing to meet me in the middle. it has to be all your way, or you're not going to approve the PR.
2017-04-26 11644, 2017
reosarevok
ruaok: from what I see, this looks just the same as bitmap or chirlu's comments on my PRs when I send a MBS PR - they're requesting what they think will be better for long term maintenance of the project. What's so bad about it?
2017-04-26 11607, 2017
reosarevok
All I've seen in MBS is the same as this: the PR is only approved once all the requested changes are made
2017-04-26 11628, 2017
ruaok
this is about a difference in philosophy and teamwork.
2017-04-26 11606, 2017
reosarevok
(whether *this* specific change is important, I dunno, but ensuring LB is stable ant testable seems pretty useful given how we're hoping for it to get huge)
2017-04-26 11611, 2017
Gentlecat
I actually think that we did, but the thing I'm talking about is my formal approval
2017-04-26 11613, 2017
reosarevok
(so if it's better for testing...)
2017-04-26 11626, 2017
Gentlecat
and I just can't make it, sorry
2017-04-26 11627, 2017
ruaok
the things that Gentlecat is insisting on make not functional changes to the code. it is purely stylistic and I disagree with his stylistic attidude.
2017-04-26 11650, 2017
Gentlecat
^ this, however, I disagree with
2017-04-26 11608, 2017
reosarevok
"I don't need to know how listens_time_range is implemented to understand how write works" doesn't sound stilystic, sounds like the usual each-function-does-one-thing approach
2017-04-26 11625, 2017
reosarevok
er, stylistic, fuck it. For a style leader I sure suck at writing style
2017-04-26 11622, 2017
reosarevok
(that's what I've been told to do in school, anyway, make as many small components as possible because it's easier to isolate failures and to test them in isolation)
2017-04-26 11641, 2017
reosarevok
I'm not claiming to be an expert though, so I'd rather you two just asked for the opinion of a second python coder :)
2017-04-26 11604, 2017
reosarevok
(samj1912 or bitmap or dunno who would be ideal for this)
2017-04-26 11616, 2017
reosarevok
If they don't think the changes are particularly important, merge, if they think they are consider doing them? But dunno :)
2017-04-26 11613, 2017
ZaphodBeeblebrox
pizza with tuna and corn?
2017-04-26 11614, 2017
ZaphodBeeblebrox
that sounds delicious!
2017-04-26 11604, 2017
ZaphodBeeblebrox puts his foot back in his mouth
2017-04-26 11605, 2017
ZaphodBeeblebrox
.. :/
2017-04-26 11636, 2017
reosarevok
ZaphodBeeblebrox: that doesn't sound delicious to me, but given you scandis have curry pizza with bananas, what do I know :p
2017-04-26 11646, 2017
samj1912
reosarevok I usually leave the style decisions to the people maintaining the project. For eg. Me zas Mineo and other contributors to picard have developed a style guide and stick to it. I am also very particular about the way and look of the code that is written and generally stick to pep8 except for a couple of guidelines. As for functions and classes we
2017-04-26 11646, 2017
samj1912
generally divide them up into smaller modular one as long as it possible and as long as we can maintain readability we try to reduce duplicate LoC.
2017-04-26 11603, 2017
Quesito
I have been known to part take in corn on pizza once in a awhile ZaphodBeeblebrox...although haven't gone full tuna + corn yet. ;)
2017-04-26 11610, 2017
samj1912
That is for the picard though and my personal preference
2017-04-26 11620, 2017
ZaphodBeeblebrox
tuna is delicious :d
2017-04-26 11643, 2017
samj1912
I haven't ever looked at LB code in depth to comment on that PR
2017-04-26 11656, 2017
ruaok
ah, so the code suggestion that Gentlecat made doesn't actually work and makes the code more complicated or slower.
2017-04-26 11609, 2017
reosarevok wonders if ruaok's comment is related to samj1912's or to something else
2017-04-26 11658, 2017
ruaok
not to samj1912's comment. the comment was directed at Gentlecat's comment on my PR.
2017-04-26 11642, 2017
ruaok
but, I've merged that now and will continue with my day. albeit not nearly as happily as I did before.
2017-04-26 11628, 2017
reosarevok was just wondering what the "doesn't actually work and makes the code more complicated or slower" was in reaction to - whether you tried it or what :)
2017-04-26 11653, 2017
ruaok
I tried to accept his suggestion, but the suggestion was actually technically flawed.
2017-04-26 11642, 2017
Gentlecat commented
2017-04-26 11657, 2017
reosarevok
Anyway, merging the PR is ok
2017-04-26 11626, 2017
samj1912
Oh btw ruaok, spent most of my day talking to professors, most of the related researchers already have their student slots filled. I am trying to get my department undergrad advisor to help me out. Let's see how it goes.
2017-04-26 11649, 2017
ruaok
oy, that doesn't sound good.
2017-04-26 11600, 2017
samj1912
There is one person who specializes in speech processing and sound related ML.
2017-04-26 11610, 2017
samj1912
I have a meeting with him tomorrow
2017-04-26 11615, 2017
samj1912
Hopefully he accepts
2017-04-26 11622, 2017
ruaok
ok
2017-04-26 11657, 2017
reosarevok
As far as I see, Gentlecat was giving his opinion on how it should be done, but since you have merging rights, and he didn't have a change request up (anymore at least, dunno earlier) it's not like he was trying to block the PR. It makes sense that he won't give an official approval to code he doesn't 100% approve of, though, that sounds reasonable to me?
2017-04-26 11618, 2017
reosarevok
If you just don't agree with the comments, leave a comment about why, say you're merging, and he can refactor later if he wants and make sure his option still works fine
2017-04-26 11654, 2017
samj1912
If nothing else works, I'll just work on it part time. The projects are interesting :D
2017-04-26 11617, 2017
reosarevok
Especially if you want to get something done soonish, it makes sense to make changes, but have a documented list of suggestions of possible improvements that can be done later, be it by you or by somebody else
2017-04-26 11619, 2017
ruaok
reosarevok: let's just leave it be. I am clearly not expressing myself well.
2017-04-26 11639, 2017
ruaok
reosarevok: again, it wasn't about the PR or blocking my work.
2017-04-26 11652, 2017
reosarevok
(and I think that applies even if it's just stylistic, as long as *you* aren't forced to change that yourself)
2017-04-26 11653, 2017
ruaok
it was about team-work, compromising and getting along better.
2017-04-26 11640, 2017
reosarevok
Well, "I don't think this code is ideal but I'm not blocking it either" sounds like compromise to me. He suggested things, you made some changes, didn't make others, and the PR was merged
2017-04-26 11613, 2017
reosarevok
"You have to give official approval" isn't compromising really, in the same way as "nah I'm just going to reject this PR" by him wouldn't be either
2017-04-26 11635, 2017
Gentlecat
reosarevok: that's exactly my thinking
2017-04-26 11638, 2017
reosarevok
So why not just use that as a compromise going forward?
Of course, for that to work it should work the same way in the other way - so Gentlecat shouldn't demand ruaok giving his approval to something *he* doesn't think it's ideal, etc.
2017-04-26 11608, 2017
ruaok
let's just drop it, please.
2017-04-26 11611, 2017
reosarevok
And tbh it feels like the most possible things that are mentioned in a PR, the better it is for future documentation - even if the final answer is "I didn't do it that way", at least there's a discussion and in the future you can see why it wasn't done that way. I know I've found that useful in past PRs myself at least, especially when I come back to it and
2017-04-26 11611, 2017
reosarevok
I don't remember exactly why I didn't do that
2017-04-26 11619, 2017
ruaok
this is just making more pissed off by every second.
2017-04-26 11628, 2017
Sophist-UK
Happy to give my opinion (as the receiver of style comments in Picard), but only if people want to hear it.
2017-04-26 11645, 2017
ruaok signs off IRC for the day
2017-04-26 11655, 2017
reosarevok will drop it now, but would love it if ruaok considered it once he's not pissed off :)
2017-04-26 11605, 2017
reosarevok
(and sorry for making you grumpier now! but I felt it was important)
2017-04-26 11606, 2017
Gentlecat
it seems like an important discussion to have
2017-04-26 11642, 2017
agentsim joined the channel
2017-04-26 11621, 2017
agentsim has quit
2017-04-26 11622, 2017
Sophist-UK
Apparently not - and my stylistics comment was only intended to lighten the atmosphere (which was a bit uncomfortable but perhaps necessary)
2017-04-26 11656, 2017
reosarevok
:) thanks for trying Sophist-UK
2017-04-26 11613, 2017
reosarevok
(even though I'm not into soul, so I don't think I'll love the Stylistics :D )
2017-04-26 11639, 2017
reosarevok
Maybe at a different time we'll have another discussion about this, but I guess we should let it be for now
(right now those give a lot of false positives where we do have a Wikidata link on our side, but it's not yet reciprocated)
2017-04-26 11626, 2017
reosarevok
Well, that's not the only reason, of course, it's also because yay semantic web
2017-04-26 11638, 2017
reosarevok
But this is probably the most direct benefit for editors :)
2017-04-26 11656, 2017
Freso
reosarevok: Can you take a look at https://musicbrainz.wordpress.com/wp-admin/edit-c… - the guy is promoting an MB mirror (which seems to be down now though), so I'm leaning towards approving them. What's your take?
2017-04-26 11604, 2017
reosarevok
In a sec :)
2017-04-26 11638, 2017
reosarevok
Honestly, I'd consider *not* approving it for the guy's own good
2017-04-26 11658, 2017
reosarevok
Unless he wants a lot of headphones users crushing his server every time it's up :p
2017-04-26 11644, 2017
Freso
Okay. I'll delete them now, but I'll probably approve his comments if he makes some again.
2017-04-26 11650, 2017
Freso
(The server is down now anyway.)
2017-04-26 11609, 2017
reosarevok
Sounds good to me
2017-04-26 11600, 2017
Leo_Verto has quit
2017-04-26 11635, 2017
Freso
reosarevok: Would a report for "artists that are type:Person with no gender set" make sense?
