Yes - then obj1.list and obj2.list are the same object.
2017-05-10 13048, 2017
samj1912
yup
2017-05-10 13057, 2017
Sophist-UK
Oops.
2017-05-10 13005, 2017
samj1912
yup :P
2017-05-10 13011, 2017
samj1912
and it causes unseen bugs
2017-05-10 13014, 2017
Sophist-UK
This is a great tool.
2017-05-10 13029, 2017
samj1912
yup :D
2017-05-10 13049, 2017
Sophist-UK
Presumably somewhere in the background is a long list of coding rules that it checks. I have seem something like this for Java.
2017-05-10 13023, 2017
samj1912
Sophist-UK: yup something along those lines I believe
2017-05-10 13034, 2017
samj1912
and this is free for FOSS orgs :D
2017-05-10 13045, 2017
samj1912
maybe MeB would like to implement it in all their repos
2017-05-10 13055, 2017
samj1912
zas, ruaok ^
2017-05-10 13041, 2017
Sophist-UK
If we can make it work for Picard then replicating that across all the repos will be a piece of ... um ... cake.
2017-05-10 13055, 2017
Sophist-UK
Would be nice if we could:
2017-05-10 13059, 2017
samj1912
Sophist-UK: it already is a piece of cake :P
2017-05-10 13005, 2017
samj1912
you just need to link you GH account
2017-05-10 13009, 2017
samj1912
it does the rest on its own
2017-05-10 13026, 2017
ruaok
oh joy, more code nazi tools.
2017-05-10 13042, 2017
Sophist-UK
Does it give: a. Overall stats or the project; and b. analysis of each PR as to whether it improves or makes worse the code quality?
2017-05-10 13049, 2017
samj1912
both
2017-05-10 13002, 2017
Sophist-UK
Ve haf vays of makin' you code.
2017-05-10 13019, 2017
Sophist-UK
Go for it: +1
2017-05-10 13028, 2017
ruaok
yes and that is making me not want to write code for my own project anymore.
2017-05-10 13054, 2017
Sophist-UK
samj1912: Does it have a special ruaok setting?
2017-05-10 13014, 2017
samj1912
ruaok: you can choose which rules you want it to follow
2017-05-10 13042, 2017
ruaok ticks the "none" box and chucks it out
2017-05-10 13054, 2017
samj1912
things like above which leads to bugs ( lists as initializers etc. ) will be nice to have pointed out, you can make it ignore coding style issues
2017-05-10 13052, 2017
Sophist-UK
There are some coding style issues which are important - if we wrote code like the minifyers produce it would be unreadable. I accept that a lot of style rules are a matter of opinion as to which is the "true" coding style, but style consistency between programmers also makes it easier to read.
2017-05-10 13015, 2017
Sophist-UK
+1 for turning off the most trivial style rules. +1 for making all style rules advisory rather than mandatory.
2017-05-10 13010, 2017
agentsim has quit
2017-05-10 13036, 2017
D4RK-PH0ENiX has quit
2017-05-10 13031, 2017
D4RK-PH0ENiX joined the channel
2017-05-10 13009, 2017
Sophist-UK
The good news is that there are no SQL Injection issues in Picard. :-)
yeah, they were passing right after I merged everything. though I made some undetected fixes and have to run them again
2017-05-10 13051, 2017
bitmap
also did a full import and succesfully ran upgrade.sh
2017-05-10 13039, 2017
bitmap
today I'm planning to run a full export of that DB and try importing it
2017-05-10 13047, 2017
ruaok
good. any tests on slaves just yet?
2017-05-10 13011, 2017
bitmap
not yet, that's next too :)
2017-05-10 13044, 2017
ruaok
kewl. sorry I've been so absent on this process. I just trust you top shout if you need help. :)
2017-05-10 13054, 2017
ruaok
anything else that I should be concerned with?
2017-05-10 13027, 2017
UmkaDK has quit
2017-05-10 13013, 2017
bitmap
I think not. we'll probably release without the entity attributes UI, but I guess that's not alarming
2017-05-10 13039, 2017
ruaok
nope. as long as the SQL portions go through smoothly.
2017-05-10 13049, 2017
bitmap
yup
2017-05-10 13027, 2017
ruaok
care to set a time to do the release so I can "help" or do you want to do it with yvanzo?
2017-05-10 13027, 2017
UmkaDK joined the channel
2017-05-10 13055, 2017
bitmap
oh, hmm. I made some changes to the postgres container, so it might be convenient to have some brief downtime for all projects to update it
2017-05-10 13028, 2017
ruaok
should be in the neighborhood of less than a minute, right?
2017-05-10 13031, 2017
bitmap
having yvanzo help might actually be a good learning experience for him
2017-05-10 13051, 2017
bitmap
yeah, in theory
2017-05-10 13004, 2017
ruaok
ok, I would suggest picking a time that is late afternoon EU so all three of us and maybe also zas and be present.
2017-05-10 13027, 2017
ruaok
I wonder if with docker practice will match closer to theory. :)
2017-05-10 13042, 2017
bitmap
it'll update PG to 9.5.6 and make some consul-template changes
2017-05-10 13013, 2017
ruaok
I trust the 9.5.6 change requires no upgrade, right?
2017-05-10 13051, 2017
bitmap
right, no action required
2017-05-10 13001, 2017
ruaok
k, great.
2017-05-10 13011, 2017
bitmap
it has a bugfix for broken indexes but I don't think we're affected, I'd check first
2017-05-10 13031, 2017
bitmap
(would just require re-creating those indexes)
2017-05-10 13045, 2017
bitmap
zas: about the load issues on trille(?), I think there is still some bug where if something is pushed to docker-server-configs, MBS will start compiling JS/CSS over and over again indefinitely
2017-05-10 13003, 2017
bitmap
it was happening just now on williams
2017-05-10 13034, 2017
bitmap
it has something to do with consul-template, difficult to reproduce
2017-05-10 13047, 2017
arbenina_ has quit
2017-05-10 13027, 2017
arbenina_ joined the channel
2017-05-10 13034, 2017
Gentlecat
it will be helpful to update test PG container versions for the rest of the projects to make sure everything works
2017-05-10 13055, 2017
Gentlecat
some might run different versions though, need to make that consistent
2017-05-10 13025, 2017
rembo10 has quit
2017-05-10 13008, 2017
arbenina_ has quit
2017-05-10 13023, 2017
rembo10 joined the channel
2017-05-10 13028, 2017
kyan joined the channel
2017-05-10 13044, 2017
github joined the channel
2017-05-10 13044, 2017
github
[metabrainz.org] gentlecat opened pull request #281: Documentation for CSS builds in development (master...css) https://git.io/v91lF
2017-05-10 13044, 2017
github has left the channel
2017-05-10 13032, 2017
arbenina_ joined the channel
2017-05-10 13052, 2017
Gentlecat
Quesito: ^ see if this makes it better
2017-05-10 13040, 2017
zas
bitmap: possible, i didn't check in details, but it is very likely something like that
