I think we just need to add a 'restore' method that converts the language_id property
2017-05-29 14925, 2017
bitmap
we'll skip today's release since I didn't really have time to merge anything over the past two weeks
2017-05-29 14947, 2017
bitmap
but we can get a fix for that on beta and I can run ModBot manually on beta
2017-05-29 14924, 2017
yvanzo
Ok, I can make that fix.
2017-05-29 14930, 2017
bitmap
awesome, thank you
2017-05-29 14937, 2017
github joined the channel
2017-05-29 14937, 2017
github
[musicbrainz-server] mwiencek closed pull request #513: Update and improve support for CD Baby URLs (MBS-9311, MBS-9348) (master...mbs-9311-mbs-9348-cdbaby) https://git.io/vHIJ7
2017-05-29 14937, 2017
github has left the channel
2017-05-29 14957, 2017
alastairp
bitmap:, there have been lots of people with the problem with the postgres driver
2017-05-29 14902, 2017
github joined the channel
2017-05-29 14902, 2017
github
[musicbrainz-server] mwiencek closed pull request #514: Add support for Big Cartel URLs in mail order relationships (MBS-9350) (master...mbs-9350-bigcartel) https://git.io/vHIJF
2017-05-29 14902, 2017
github has left the channel
2017-05-29 14913, 2017
bitmap
I know :(
2017-05-29 14920, 2017
alastairp
Anything we can do about a new schema release tag with the old version?
2017-05-29 14958, 2017
alastairp
I didn't have the same Raven problem that others had too, but perhaps that too?
2017-05-29 14952, 2017
bitmap
I was thinking of merging those those fixes to the schema-change-2017-q2 branch and creating a new tag based off of that
2017-05-29 14922, 2017
bitmap
we did something similar last year, had to make a -v2 tag
2017-05-29 14949, 2017
alastairp
Sounds like a good idea to me
2017-05-29 14938, 2017
bitmap
yvanzo: do you still get the renderer errors running tests? not sure why, but I don't anymore
2017-05-29 14913, 2017
yvanzo
I got it even while testing your PRs.
2017-05-29 14940, 2017
bitmap
"Couldn't connect to the renderer." right?
2017-05-29 14951, 2017
yvanzo
Well... seems to have vanished here as well...
2017-05-29 14914, 2017
bitmap
crazy
2017-05-29 14953, 2017
yvanzo
I just checked latest master, recompiled scripts, recreated test db and relaunched probe.
2017-05-29 14910, 2017
bitmap
I see an issue where it doesn't kill the renderer after the tests die
2017-05-29 14929, 2017
bitmap
but it still works even if I run them again with that renderer still running; it just connects to that one
2017-05-29 14953, 2017
yvanzo
By the way, did you remove 'tests' target for resources compiling script for good?
2017-05-29 14942, 2017
bitmap
hmm, that wasn't intentional, sorry
2017-05-29 14958, 2017
bitmap
it still works via ./node_modules/.bin/gulp tests
2017-05-29 14926, 2017
SothoTalKer
ohhh, look. there are just the 2 people i was looking for :D
While submitting this edit there where 2 other edits by me, moving the medium numbers from 2 to 1, and from 3 to 2.
2017-05-29 14916, 2017
bitmap
well, the exception you linked was for a ReorderMediums edit
2017-05-29 14919, 2017
SothoTalKer
Those failed
2017-05-29 14946, 2017
bitmap
I've seen this error before, I don't know what causes it yet
2017-05-29 14930, 2017
SothoTalKer
i guess that happens when you try to remove the first medium of a release, and the positions of the others try to automatically change. but since the removal of the first medium is a destructive edit, it needs to get voted on, so the other edits (changing medium number) fail.
2017-05-29 14902, 2017
SothoTalKer
because medium 1 still does exist.
2017-05-29 14916, 2017
bitmap
it tries to be smart and change the position of the removed medium before it removes it, but perhaps that fails
2017-05-29 14935, 2017
SothoTalKer
I think it is easy to recreate. just set up a release with 2 or more mediums and try to remove the first one. That should trigger it.
2017-05-29 14938, 2017
yvanzo
bitmap: No worry about browser tests. I just noticed the change because I was used to compile it (acc. to HACKING doc), back then my server machine was much slower than my client. I don't use them anymore either.
2017-05-29 14916, 2017
bitmap
okay 👍
2017-05-29 14933, 2017
bitmap
I only use them when I'm debugging a browser-specific issue
[musicbrainz-server] yvanzo opened pull request #517: MBS-9362: Restore work language edit data (beta...mbs-9362-beta-fix) https://git.io/vHWGb
2017-05-29 14920, 2017
github has left the channel
2017-05-29 14944, 2017
ruaok
reosarevok: lets see about getting the contract done tomorrow. ping me during the day
2017-05-29 14950, 2017
Mineo has quit
2017-05-29 14911, 2017
m0n0g0n has quit
2017-05-29 14941, 2017
lazka has quit
2017-05-29 14927, 2017
Bellami joined the channel
2017-05-29 14929, 2017
suhas2go has quit
2017-05-29 14933, 2017
D4RK-PH0ENiX has quit
2017-05-29 14901, 2017
D4RK-PH0ENiX joined the channel
2017-05-29 14947, 2017
D4RK-PH0ENiX has quit
2017-05-29 14936, 2017
D4RK-PH0ENiX joined the channel
2017-05-29 14957, 2017
SkullTech joined the channel
2017-05-29 14911, 2017
SkullTech
In the issue PW-41, the tables need to be sorted. Can someone tell me what would be the preferred way of doing this, server-side or client-side (using Javascript)?
