maybe you can add some console.log statements in there and see what's going on?
2017-06-09 16017, 2017
yvanzo
It seems to be specific to tests, but I did not find any code related to sockets in tests, might be a wrapper/lib/...
2017-06-09 16023, 2017
bitmap
t/tests.t will try to start a renderer process
2017-06-09 16054, 2017
bitmap
this was happening for me consistently before, but now I can't trigger it no matter what
2017-06-09 16052, 2017
yvanzo
If you run a Controller:: test, socket is closed properly?
2017-06-09 16047, 2017
bitmap
I tried running Controller::Account, and after the test finishes, lsof shows nothing on the socket
2017-06-09 16014, 2017
bitmap
there were no node processes before I invoked the test, and none after
2017-06-09 16020, 2017
yvanzo
Actually, it is the same here.
2017-06-09 16050, 2017
bitmap
is it certain tests, perhaps?
2017-06-09 16011, 2017
yvanzo
Yes, try User::Edit.
2017-06-09 16024, 2017
bitmap
no issues for me there
2017-06-09 16030, 2017
bitmap
on commit efba20ace00a0c0e5c9313a479016a9cc3e38300
2017-06-09 16042, 2017
bitmap
were you on the branch where User::Edit fails? maybe test failures trigger it...
2017-06-09 16051, 2017
yvanzo
No, it passes.
2017-06-09 16029, 2017
yvanzo
More weird, I cannot reproduce the bug anymore...
2017-06-09 16019, 2017
bitmap
^C will leave an orphan renderer, but it doesn't cause subsequent runs to fail either
2017-06-09 16048, 2017
yvanzo
I can even run two tests in parallel successfully.
2017-06-09 16057, 2017
bitmap
I can only think of some race condition where t/tests.t doesn't fork a new renderer because an orphaned one still exists, and then the orphan exits before the tests execute
2017-06-09 16051, 2017
alastairp
bitmap: thanks for the merge 👍
2017-06-09 16057, 2017
bitmap
though I don't know why it would exit (or exist outside of ^C)
2017-06-09 16027, 2017
yvanzo
OK, it happens again...
2017-06-09 16004, 2017
bitmap
if t/tests.t couldn't fork server.js, it should say so ("socket ... exists and is in use")
2017-06-09 16053, 2017
bitmap
ferbncode / alastairp: I pushed a new image tagged metabrainz/musicbrainz-test-database:schema-change-2017-q2 if you need it
2017-06-09 16037, 2017
alastairp
cool; with the pr merged?
2017-06-09 16050, 2017
bitmap
yeah
2017-06-09 16014, 2017
yvanzo
this time lsof shows that a node process is hanging on socket, but it does not prevent further runs to pass.
2017-06-09 16050, 2017
bitmap
sounds like what I can reproduce using ^C on the tests
2017-06-09 16023, 2017
bitmap
it doesn't particularly care how/when the renderer started
2017-06-09 16030, 2017
yvanzo
no... but it fails again B-(
2017-06-09 16032, 2017
bitmap
it should only say "Couldn't connect" if there is no node process, or there is but it doesn't have the socket open
2017-06-09 16048, 2017
yvanzo
It doesn't say that when running prove.
2017-06-09 16018, 2017
bitmap
what does it say?
2017-06-09 16004, 2017
yvanzo
Just “Couldn't connect to the renderer, at” …
2017-06-09 16038, 2017
yvanzo
arrh
2017-06-09 16046, 2017
yvanzo
I am confused :)
2017-06-09 16046, 2017
bitmap
so it does say it? huh? :)
2017-06-09 16021, 2017
yvanzo
Yes.
2017-06-09 16057, 2017
yvanzo
Even if there could be (not necessarily) another node process hanging on the socket.
2017-06-09 16015, 2017
bitmap doesn't think he has enough mental energy left to debug this today :|
2017-06-09 16031, 2017
yvanzo
So, this is a race condition, but at least I can work around it by closing socket by hand.
2017-06-09 16045, 2017
yvanzo
I will just open a ticket for now.
2017-06-09 16002, 2017
bitmap
okay, at least there is a workaround for now
2017-06-09 16006, 2017
bitmap
thanks
2017-06-09 16023, 2017
EndeavouringCat is now known as CatQuest
2017-06-09 16054, 2017
CallerNo6 joined the channel
2017-06-09 16047, 2017
Freso
CatQuest: Do you think you will have a part 3 for next week?
2017-06-09 16059, 2017
Freso
Or will the next one be a bit further out?
2017-06-09 16000, 2017
CatQuest
uhhh....
2017-06-09 16009, 2017
CatQuest
next one a bit further out?
2017-06-09 16014, 2017
CatQuest
is that ok?
2017-06-09 16016, 2017
Freso
Alright.
2017-06-09 16023, 2017
CatQuest
I mean the sceleton is there and stuff but I want to wait a little because the next one after that (regularly squeduled) will be A LOT later (given the loads of work to be done on it, and i'd rather liek to space thme out so it feels logila nd nice flow)
2017-06-09 16015, 2017
CatQuest
honestly it's a hydra. whne i open one link there i find links to alteast 2 more other instruments stuff is related to
2017-06-09 16034, 2017
CatQuest
so i'm taking a break until atleast tuesday (probably)
2017-06-09 16045, 2017
Freso
CatQuest: Alright. I was thinking it might have been nice to have "the original trilogy" somewhat "close together", but I'd also rather you rest/take a break if you need to. The posts can wait, your health can't. :)
2017-06-09 16014, 2017
CatQuest
I'm fine heath wize :P just trying to pre.empth any burnout honestly :DDDD
2017-06-09 16053, 2017
SothoTalKer
i read wealth o.o
2017-06-09 16046, 2017
CatQuest
and yea. that's also what I want, but I also wanted the next one to be.. on the horizon like. so making it flow nicely and stuff like ._.__._______. instead of ...________________.
2017-06-09 16010, 2017
CatQuest
(if you understand what I mean with dots here)
2017-06-09 16058, 2017
CatQuest
SothoTalKer: ahha I use any wealth I have on lego and music :D
(Eidsvoldsbygningen is where Norway's constitution was written/signed/agreed upon) (I am daft and not sure and it's alte and i an't be assed to look it up)
2017-06-09 16007, 2017
CatQuest
eh i wish, but it's expensive and i don't know how to get there and as well get a ticket
2017-06-09 16054, 2017
CatQuest
ahh.. it's late 😪
2017-06-09 16005, 2017
CatQuest
so night soon 🙋
2017-06-09 16011, 2017
SothoTalKer
let Freso invite you as a present for your awesome contributions to MB regarding instruments :>
2017-06-09 16022, 2017
CatQuest
👍
2017-06-09 16031, 2017
CatQuest
too bad he doenst live there anymore ¬¬
2017-06-09 16047, 2017
SothoTalKer
he should still invite you :p
2017-06-09 16054, 2017
Freso
Man, even when I lived in DK, it would be cheaper for my to go to Barcelona than to Billund (where Legoland is).
2017-06-09 16018, 2017
CatQuest
ja jøss
2017-06-09 16025, 2017
SothoTalKer
ohh i have a 50 öre coin fron norway o.o
2017-06-09 16041, 2017
CatQuest
if it says öre you seriously do not!
2017-06-09 16011, 2017
SothoTalKer
øre, just for you+
2017-06-09 16017, 2017
CatQuest
:D
2017-06-09 16056, 2017
SothoTalKer
and 10 kroner from "danmark". whereever that is
2017-06-09 16013, 2017
SothoTalKer
CatQuest anything you could recommend for me to buy with my wealth of 50 øre? :X
2017-06-09 16036, 2017
CatQuest
tja.. given that the 50 øre litterally has been out of commision for 3-4 years, not much :D
.jpg){kind=link}
