#metabrainz

alastairp: > How can I test this myself? Is the rest of the system stable/bug-free enough that I can run it, or should I wait for you to fix conflicts and rebase/merge master?

I think my merge has a merge conflict in it.

I'm just considering all the changes that have been made in the last 2 weeks

but you should be able to check out the branch, start with an empty influx DB, and then do a last.fm import.

OK, cool

yeah, its been a problem.

I'm vacillating between the pika-flask problem and the listen-counts issue.

I will probably re-do the merge in a bit to see what went wrong

I'm curious to know what was fixed in a new version of setuptools

alastairp: https://github.com/metabrainz/listenbrainz-serv...

I added a link to the github issue and a failed build in the commit

ahhhh, github doesn't show full commit messages in a nice way in pull requests

nice one for using them!

OK, I don't this to be taken in a mean way, but I just checked out, built, set up, started LB, did an import, and can now browse my listens

awesome work guys

I kind of didn't expect it to be that easy

iliekcomputers has been relentlessly fixing shit I bring up.

!m iliekcomputers

You're doing good work, iliekcomputers!

ya know

that's good enough for me

lol

(completely serious here)

:)

OK, this is all up and running. I'm going to go home and continue looking at it from there

great, thanks.

hey, so

UID=`id -u`

GID=`id -g`

docker-compose run --rm --user $UID:$GID web "$@"

will stop docker creating all these files owned as root all over your home directory

that's kind of nice

Thanks yvanzo_ :)

and it's portable (over different linuxes... not sure if mac has `id`)

alastairp: home dir? I'm confused.

when you run docker on linux, and the process inside the container creates a file, it's owned by root

(assuming you run your process in the container as root; which is the default)

ah inside the container, ok.

is that important though? I don't often care about the cleanliness of the container.

not the container

your local code checkout

if you have . mapped as a volume

if you have a volume set up, the resulting css file will be in your code checkout, but owned by root

anyway. I thought it was interesting

Mineo: if you've seen my comment on a PR for sir, I'd appreciate if you could take a look

since I'm a bit stuck on that part

[listenbrainz-server] mayhem opened pull request #203: Ditch Flask-pika for pika-pool (master...pika-pool) https://git.io/vQkEh

iliekcomputers: ^^

that works much better.

iliekcomputers: good catch. I'll keep the clauses, but change error messages so we can tell what is going on in case of errror

👍🏽

Mineo: also, if you could explain how paths were created and how/when they should be updated

Gentlecat, I'm looking at the PR at the moment

the answer to your last question is one that I'm not sure you'll like ;-)

I'm just collecting the facts :)

you basically have to read through the *Index.java files in https://github.com/metabrainz/search-server/tre... and figure out which SQL statements are used for which search field

that's for all the paths where the data eventually ends up in a field

so these might need an update during a schema change, right? which would make it easier to track down what exactly needs to be updated

might need to do that for the last one actually

the extrapaths paths are ones where the data is not stored in a search field, but in the generated XML by the wscompat module - we don't want to interact with the database in the wscompat module, so the data has to be fetched along with the rest

ruaok: weird build failure, I think a restart is worth a try

Gentlecat, and yes, those would need updates for schema changes where either the tables involved change or new data is supposed to show up in the index

or you could just merge considering one build passed and the other seemed to have failed because the db container seemed to be doing something weird

that's odd.. in one browser my profile has all the listens i imported (well most) and in the other browser same page.. none?

or wait, no

all my imports have been wiped :/

CatQuest: the db was probably reset again

yes, CatQuest, I wiped it again. I'll wipe it again before we're done, but I really appreciate you doing the import. its become a litmus test. :)

:D

in the future people with much higher listens thna me wil be importing tino listenbrainz :)

into*

how the heck did tino beocme into?

into become tine i mean.. I need a nap :o

yes.. a nap

jeesh

huh, that's cool

"the mind behind the brainz", eh? :)

I love how you call it a "drug dealer business model"

that's what we're doing, no?

Get them hooked on the free music data and then make them pay for it, I guess that's scarily accurate

awesome

:)

yeah, I also didn't know that one. and it was actually a really nice cake!

I wonder who ate it :P

they typo'ed ListenBrainz in the first line -- `ListenBrain` :(