#metabrainz

zas online yet?

too late

Is there anyone here having a QNAP nas ? I need some infos about it, and what's running on it.

iliekcomputers: thanks for the reviews. I totally forgot that you came up with helper functions.

ruaok: you're welcome :)

finished most changes. the counts_*py scripts are helpers. not sure I care to keep them

Methinks not having them would be okay

I might keep the flush one.

but I'll fix it up.

ok, changes pushed, if you want to look again.

[listenbrainz-server] mayhem closed pull request #210: Import page re-shuffle (master...import-page-layout) https://git.io/vQOm6

[listenbrainz-server] mayhem closed pull request #209: Listen counts rebased (master...listen-counts-rebased) https://git.io/vQOfF

listen counts, finally merged. damn, that took long and was painful.

Just incremental imports left and hopefully that's it for the community beta at least :)

LordSputnik: Getting a jQuery undefined when running the most up to date from master

Was this there before?

Hmm that'll be because of my change last week from require to import

I'll need to do some investigating

found it

f777e0479b93b32d7c34eec72420a756a6caf877 is the issue

yeah that makes sense

May need to use something like https://github.com/thlorenz/browserify-shim

ok, adding browserify-shim resolved the issue. Are there any other non-commonjs dependencies?

asides from jquery

everything else in package.json looks alright to me

iliekcomputers: my first full import from last.fm just finished.

now listening to more music to test incremental imports.

if that is fine, I'll approve and merge.

then wipe/deploy

iliekcomputers: we made changes to the scraper. you should bump the version to 1.7.

then I'll merge, imports are working. :)

actually, I'll jump bump the version.

ruaok: okay great, i was doing it but sure

[listenbrainz-server] mayhem closed pull request #207: LB-20 / LB-31 / LB-182: Incremental imports (master...incremental-imports) https://git.io/vQYdR

all merged.

can you please have a look at the bugs and close things that need closing?

ok

only the API docs one is left .

hmmm.

that should really be under the API, no?

but I think that should be under API and then have docstrings added.

then we can close the API docs bug too

ruaok: okay, i'll put it in api

LordSputnik: Only noticed one instance of jQuery being used btw, react-bootstrap doesn't have a dependency on it either

Nvm, it's used quite extensively with select

arthelon: Select2?

If we get rid of that, can we drop jQuery?

I believe so

I only see jQuery usage in the EntitySearch and Select2 components

ruaok: you think the get and update should be different endpoints?

naw, the same with GET/POST

okay cool

LordSputnik: Maybe we can replace select2 with this? http://jedwatson.github.io/react-select/ The largest refactor would be the select2Options that are being passed around

That's what I've started doing with the new entity editor

It has much better performance in react too

Maybe we can make a wrapper component to translate between the Select2 props and the react select props?

Then update to use react select without the wrapper gradually

Don't think it's too big of a rewrite

we can try changing all the occurences right away

Probably less work than going through every occurence, seeing what's being used, and writing out the equivalent in react-select

It's mainly for the select2Options prop, all the other props seem to be supported in react-select

Everything in select2Options should be its own prop

iliekcomputers: XMLHttpRequest cannot load https://beta-api.listenbrainz.org/user/latest-i.... Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://beta.listenbrainz.org' is therefore not allowed access.

heh.

my personal listen count, the big query listen count and system wide listen counts are all the same.

ruaok: why exactly does that error happen for the new endpoint but not for submit-listens? Not familiar with this very much

the crossdomain decorator emits the Access control header which defines the API end point and allows the web browser to make calls to it.

without it, you get the error I posted above

weird, I had added that decorator to the function https://github.com/metabrainz/listenbrainz-serv...

but that was on a different domain.

beta vs beta-api

ohhh, check it out!

win2003.verylegit.link/server1337504warez=64.zip.sh

[listenbrainz-server] paramsingh opened pull request #211: Move latest-import endpoint to api (master...incremental-import/move-to-api) https://git.io/vQOd1

woo

iliekcomputers: the code for the test or the view didn't really change, did it?

ruaok: nope no change

just moved them from one place to another and changed the url accordingly

k

[listenbrainz-server] mayhem closed pull request #211: Move latest-import endpoint to api (master...incremental-import/move-to-api) https://git.io/vQOd1

ferbncode: this might be caused by the DB code changes https://sentry.metabrainz.org/share/issue/342e3...

iliekcomputers: still getting the CORS error. :(

weird :/

XMLHttpRequest cannot load https://beta-api.listenbrainz.org/1/latest-import. Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://beta.listenbrainz.org' is therefore not allowed access. The response had HTTP status code 405.

Gentlecat: Hi

I looked at how to update avg. rating via triggers but I think it can be done through db like MB

Also, I had started working on it

Let me know what you think

iliekcomputers: https://gist.github.com/mayhem/8584daf8dc56b600...

the Access-Control headers are different between the two requests.

But Access-Control-Allow-Origin is * in both of them

psolanki: how does MB do it?

MB does it using perl only

I will have it done by tonight, you can review it and see it's workable

well, having a trigger would be better, I think

but if it's easier to do that as a part of the server code then try that

a part of server code?

like it's done in MB

I will update the PR and then we will discuss further if that's okay with you