but I think that should be under API and then have docstrings added.
2017-06-25 17641, 2017
ruaok
then we can close the API docs bug too
2017-06-25 17640, 2017
iliekcomputers
ruaok: okay, i'll put it in api
2017-06-25 17626, 2017
arthelon
LordSputnik: Only noticed one instance of jQuery being used btw, react-bootstrap doesn't have a dependency on it either
2017-06-25 17641, 2017
Sophist-UK has quit
2017-06-25 17605, 2017
Sophist-UK joined the channel
2017-06-25 17600, 2017
arthelon
Nvm, it's used quite extensively with select
2017-06-25 17610, 2017
LordSputnik
arthelon: Select2?
2017-06-25 17624, 2017
LordSputnik
If we get rid of that, can we drop jQuery?
2017-06-25 17635, 2017
arthelon
I believe so
2017-06-25 17600, 2017
arthelon
I only see jQuery usage in the EntitySearch and Select2 components
2017-06-25 17607, 2017
iliekcomputers
ruaok: you think the get and update should be different endpoints?
2017-06-25 17622, 2017
ruaok
naw, the same with GET/POST
2017-06-25 17648, 2017
iliekcomputers
okay cool
2017-06-25 17634, 2017
arthelon
LordSputnik: Maybe we can replace select2 with this? http://jedwatson.github.io/react-select/ The largest refactor would be the select2Options that are being passed around
2017-06-25 17606, 2017
LordSputnik
That's what I've started doing with the new entity editor
2017-06-25 17621, 2017
LordSputnik
It has much better performance in react too
2017-06-25 17658, 2017
LordSputnik
Maybe we can make a wrapper component to translate between the Select2 props and the react select props?
2017-06-25 17615, 2017
LordSputnik
Then update to use react select without the wrapper gradually
2017-06-25 17645, 2017
arthelon
Don't think it's too big of a rewrite
2017-06-25 17602, 2017
arthelon
we can try changing all the occurences right away
2017-06-25 17627, 2017
arthelon
Probably less work than going through every occurence, seeing what's being used, and writing out the equivalent in react-select
2017-06-25 17656, 2017
arthelon
It's mainly for the select2Options prop, all the other props seem to be supported in react-select
2017-06-25 17647, 2017
arthelon
Everything in select2Options should be its own prop
2017-06-25 17606, 2017
ruaok
iliekcomputers: XMLHttpRequest cannot load https://beta-api.listenbrainz.org/user/latest-imp…. Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://beta.listenbrainz.org' is therefore not allowed access.
2017-06-25 17608, 2017
ruaok
heh.
2017-06-25 17639, 2017
ruaok
my personal listen count, the big query listen count and system wide listen counts are all the same.
2017-06-25 17643, 2017
ruaok high fives iliekcomputers
2017-06-25 17657, 2017
iliekcomputers
ruaok: why exactly does that error happen for the new endpoint but not for submit-listens? Not familiar with this very much
[listenbrainz-server] paramsingh opened pull request #211: Move latest-import endpoint to api (master...incremental-import/move-to-api) https://git.io/vQOd1
2017-06-25 17602, 2017
github has left the channel
2017-06-25 17653, 2017
ruaok
woo
2017-06-25 17615, 2017
ruaok
iliekcomputers: the code for the test or the view didn't really change, did it?
2017-06-25 17627, 2017
iliekcomputers
ruaok: nope no change
2017-06-25 17653, 2017
iliekcomputers
just moved them from one place to another and changed the url accordingly
2017-06-25 17659, 2017
ruaok
k
2017-06-25 17632, 2017
github joined the channel
2017-06-25 17632, 2017
github
[listenbrainz-server] mayhem closed pull request #211: Move latest-import endpoint to api (master...incremental-import/move-to-api) https://git.io/vQOd1
XMLHttpRequest cannot load https://beta-api.listenbrainz.org/1/latest-import. Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://beta.listenbrainz.org' is therefore not allowed access. The response had HTTP status code 405.
2017-06-25 17605, 2017
psolanki
Gentlecat: Hi
2017-06-25 17628, 2017
psolanki
I looked at how to update avg. rating via triggers but I think it can be done through db like MB
