Gentlecat: its done, I was just working on the taghelper. Although its not required for places. Should I keep it rather for the release group work?
2017-06-26 17729, 2017
Gentlecat
keep what?
2017-06-26 17740, 2017
Gentlecat
sorry, I'm not sure what you mean
2017-06-26 17729, 2017
ferbncode
I didnot frame it correctly. Send and work on the taghelper function (for showing release group and other entity tags) for later PRs ?
2017-06-26 17735, 2017
Gentlecat
if that part is done, let's merge and try to deploy it (I can help with that)
2017-06-26 17730, 2017
ferbncode
ohh..sure, i will update the PR and remove the WIP tag then. :D
2017-06-26 17726, 2017
Gentlecat
I'd rather us merge smaller parts quickly than having huge PRs that take forever to finish and review
2017-06-26 17713, 2017
ferbncode
Gentlecat: sure, understood. (and updated PR)
2017-06-26 17728, 2017
Gentlecat
give me a sec, I'll post some comments
2017-06-26 17752, 2017
ferbncode
Gentlecat: okay, thanks :)
2017-06-26 17748, 2017
sam____ joined the channel
2017-06-26 17741, 2017
sam_____ joined the channel
2017-06-26 17757, 2017
sam_____ has quit
2017-06-26 17702, 2017
aeromarine joined the channel
2017-06-26 17739, 2017
sam____ has quit
2017-06-26 17731, 2017
github joined the channel
2017-06-26 17731, 2017
github
[critiquebrainz] ferbncode opened pull request #113: Fix missing table name in function users.tokens (master...token-name-2) https://git.io/vQ3QT
2017-06-26 17731, 2017
github has left the channel
2017-06-26 17720, 2017
github joined the channel
2017-06-26 17720, 2017
github
[critiquebrainz] gentlecat closed pull request #113: Fix missing table name in function users.tokens (master...token-name-2) https://git.io/vQ3QT
2017-06-26 17720, 2017
github has left the channel
2017-06-26 17734, 2017
aeromarine has quit
2017-06-26 17707, 2017
agentsim joined the channel
2017-06-26 17748, 2017
agentsim has quit
2017-06-26 17745, 2017
arbenina_ joined the channel
2017-06-26 17732, 2017
iliekcomputers
GSoC first evaluations open up today btw :)
2017-06-26 17700, 2017
agentsim joined the channel
2017-06-26 17706, 2017
agentsim has quit
2017-06-26 17734, 2017
Nyanko-sensei joined the channel
2017-06-26 17723, 2017
D4RK-PH0ENiX has quit
2017-06-26 17729, 2017
alastairp
ruaok: I've spent a bit of time looking at your counting PR, but it's a bit over my head
2017-06-26 17756, 2017
alastairp
I'm not sure of the best way to give feedback to you on it
2017-06-26 17740, 2017
ruaok
Import your listens. I'll watch your logs. :-)
2017-06-26 17700, 2017
alastairp
well, I mean, I did a successful import locally, and it counted fine
2017-06-26 17712, 2017
alastairp
so it appears to work...
2017-06-26 17746, 2017
alastairp
importing
2017-06-26 17703, 2017
ruaok
And it isn't mission critical... It is generating metadata, so if wrong, we can fix it.
2017-06-26 17712, 2017
alastairp
ok
2017-06-26 17730, 2017
zas
Moin
2017-06-26 17709, 2017
Freso
🙋
2017-06-26 17705, 2017
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Picard meeting (Tues, 18:00 UTC): Working document https://goo.gl/anENrc | MetaBrainz meeting agenda (now: 17 UTC!): reviews, MB User Survey (Leo_Verto/Quesito), spam review (ruaok), Picard meetings (Freso)
2017-06-26 17705, 2017
iliekcomputers
ruaok: no hiccups yet?
2017-06-26 17714, 2017
iliekcomputers
on the beta? :)
2017-06-26 17736, 2017
alastairp
hmmm
2017-06-26 17749, 2017
alastairp
listenbrainz count is still 2 less than last.fm
2017-06-26 17707, 2017
drsaunder joined the channel
2017-06-26 17717, 2017
iliekcomputers
alastairp: i'm almost certain that those are duplicates with the same timestamp
2017-06-26 17729, 2017
alastairp
yeah, it's likely
2017-06-26 17712, 2017
alastairp
I guess I should scrape my history and see if I can find them
2017-06-26 17732, 2017
alastairp
unfortunately it's difficult to catch this during the import process and report it
2017-06-26 17733, 2017
drsaunder has quit
2017-06-26 17733, 2017
Nyanko-sensei has quit
2017-06-26 17702, 2017
D4RK-PH0ENiX joined the channel
2017-06-26 17756, 2017
ruaok
iliekcomputers: looking now.
2017-06-26 17725, 2017
ruaok
alastairp: I'm with iliekcomputers on this one -- I think it is related to the fact that we're more serious about data ingestion than last.fm was early on.
2017-06-26 17752, 2017
PeterJones joined the channel
2017-06-26 17735, 2017
samj1912 has quit
2017-06-26 17723, 2017
ruaok
no errors in the influx writer.
2017-06-26 17753, 2017
ruaok
nothing I can see in the bigquery-writer
2017-06-26 17729, 2017
ruaok
zas: docker and long log files don't play well together to they?
2017-06-26 17748, 2017
zas
what do you mean ?
2017-06-26 17701, 2017
ruaok
lemmy:~->docker logs -f listenbrainz-web
2017-06-26 17703, 2017
ruaok
just hangs.
2017-06-26 17706, 2017
ruaok
worked a minute ago.
2017-06-26 17711, 2017
PeterJones has left the channel
2017-06-26 17740, 2017
drsaunder joined the channel
2017-06-26 17756, 2017
alastairp
ruaok: yeah, I agree
2017-06-26 17730, 2017
marc2k3 joined the channel
2017-06-26 17734, 2017
ruaok
still, I share your frustration that this a very opaque process. we're going to get other people complaining about this and it would be nice to have some tools that allows us to fix exact cases where things went wrong and why.
2017-06-26 17747, 2017
marc2k3
hi guys, looks like the certificate for community.metabrainz.org has expired. Firefox 54 is blocking me outright and IE11 lets me in if I ignore the warning
we *think* we fixed the bug that was affecting you.
2017-06-26 17742, 2017
agentsim joined the channel
2017-06-26 17722, 2017
zas
hmmm it happened again wtd
2017-06-26 17755, 2017
marc2k3
I don't think I can try the alpha import any more as I tested my last.fm account instead. I had 2 missing scrobbles out of 21,000 odd and after parsing my entire last.fm history myself, I did find duplicates as you've already predicted.
2017-06-26 17702, 2017
agentsim has quit
2017-06-26 17754, 2017
marc2k3
the duplicates weren't identical tracks but tracks that followed each other on an album that ended up with the same timestamp
2017-06-26 17715, 2017
alastairp
interesting. as long as the title and artist is different, I thought that the same timestamp wouldn't matter
2017-06-26 17719, 2017
ruaok
if the metadata is different, but timestamps the same then LB should accept them.
2017-06-26 17726, 2017
iliekcomputers
the deduplication we went back to (after reverting the time range one) didn't check for track name or artist name, only timestamp.
2017-06-26 17756, 2017
iliekcomputers
influx doesn't allow more than one row with the same timestamp and tags
2017-06-26 17700, 2017
iliekcomputers
afaik
2017-06-26 17709, 2017
ruaok goes to read the code
2017-06-26 17742, 2017
ruaok
yes, influx is going to eat the exact dupes, but we should not be calling dupes on that basis of timestamp alone.
2017-06-26 17753, 2017
ruaok
that might explain when CatQuest gets so many dropped
2017-06-26 17750, 2017
iliekcomputers
let's add the artist_msid and recording_msid check to it then
2017-06-26 17753, 2017
CatQuest
oh my old srobbles doenst have thme i think :/
2017-06-26 17741, 2017
CatQuest
but. I have a limited pool of maybe 2-3k songs that i've playd over and over
2017-06-26 17743, 2017
ruaok
iliekcomputers: yes, lets do that.
2017-06-26 17706, 2017
CatQuest
import finished btw.. and I still have diff of 1000~
2017-06-26 17708, 2017
ruaok
in theory once this check is in place, a new import should get more listens imported.
