#metabrainz

/

0:28 AM
calcmandan-mobil has quit

2017-07-13 19447, 2017

2:08 AM
suhas2go has quit

2017-07-13 19458, 2017

4:08 AM
SothoTalKer has quit

2017-07-13 19417, 2017

4:10 AM
Major_Lurker joined the channel

2017-07-13 19457, 2017

4:12 AM
MajorLurker has quit

2017-07-13 19401, 2017

4:20 AM
SothoTalKer joined the channel

2017-07-13 19424, 2017

4:23 AM
drsaunder has quit

2017-07-13 19408, 2017

5:09 AM
drsaunders joined the channel

2017-07-13 19433, 2017

5:11 AM
Mineo joined the channel

2017-07-13 19426, 2017

5:12 AM
saifulbkhan joined the channel

2017-07-13 19457, 2017

5:19 AM
D4RK-PH0ENiX has quit

2017-07-13 19416, 2017

5:20 AM
Slurpee has quit

2017-07-13 19427, 2017

5:20 AM
D4RK-PH0ENiX joined the channel

2017-07-13 19424, 2017

5:44 AM
drsaunders has quit

2017-07-13 19413, 2017

6:14 AM
Mineo has quit

2017-07-13 19406, 2017

6:21 AM
D4RK-PH0ENiX has quit

2017-07-13 19431, 2017

6:21 AM
D4RK-PH0ENiX joined the channel

2017-07-13 19419, 2017

6:24 AM
Quesito

Moin!

2017-07-13 19444, 2017

6:35 AM
cjnolet`office

lol. it's 2:35am here. Mornin

2017-07-13 19434, 2017

6:36 AM
zas

Moiiinnn Quesito

2017-07-13 19402, 2017

6:37 AM
Quesito

Moin cjnolet`office and zas!

2017-07-13 19401, 2017

6:39 AM
Nyanko-sensei joined the channel

2017-07-13 19423, 2017

6:40 AM
D4RK-PH0ENiX has quit

2017-07-13 19450, 2017

6:55 AM
agentsim has quit

2017-07-13 19423, 2017

6:56 AM
agentsim joined the channel

2017-07-13 19427, 2017

7:00 AM
agentsim has quit

2017-07-13 19432, 2017

7:01 AM
drsaunder joined the channel

2017-07-13 19457, 2017

7:07 AM
drsaunder has quit

2017-07-13 19436, 2017

7:08 AM
sampsyo has quit

2017-07-13 19405, 2017

7:13 AM
sampsyo joined the channel

2017-07-13 19435, 2017

7:58 AM
samj1912 joined the channel

2017-07-13 19447, 2017

8:01 AM
agentsim joined the channel

2017-07-13 19437, 2017

8:08 AM
agentsim has quit

2017-07-13 19404, 2017

8:09 AM
UmkaDK joined the channel

2017-07-13 19428, 2017

8:14 AM
samj1912

Morning o/

2017-07-13 19457, 2017

8:14 AM
zas

Morning samj1912 \o/

2017-07-13 19431, 2017

8:15 AM
samj1912

I'll make the switch to mbjson today

2017-07-13 19439, 2017

8:15 AM
samj1912

In the tagger

2017-07-13 19430, 2017

8:18 AM
zas

fantastic :)

2017-07-13 19447, 2017

8:28 AM
psolanki

Morning people

2017-07-13 19448, 2017

8:28 AM
psolanki

Is there a way to stop generating pycache folder every time docker-compose is run?

2017-07-13 19420, 2017

8:29 AM
psolanki

I tried changing environment variable but it didn't work

2017-07-13 19456, 2017

8:29 AM
alastairp

why do you not want to create it?

2017-07-13 19408, 2017

8:31 AM
psolanki

It's a problem for pytest - attribute error

2017-07-13 19409, 2017

8:31 AM
psolanki

I don't want .pyc files for my test branch

2017-07-13 19436, 2017

8:32 AM
alastairp

you could try `python -B`, but I don't know if that will prevent them from being created in all cases

2017-07-13 19410, 2017

8:33 AM
psolanki

I already tried it

2017-07-13 19423, 2017

8:33 AM
alastairp

however, this might not be a good fix - consider if this issue happens just for you or also for other people. It's a bit confusing to say "you must run things in this branch with python -B otherwise it won't work"

2017-07-13 19425, 2017

8:35 AM
alastairp

what is the branch that is causing you problems?

2017-07-13 19437, 2017

8:35 AM
alastairp

does it happen only when you have been in another branch first?

2017-07-13 19449, 2017

8:37 AM
ferbncode

alastairp: Hi :), the https://github.com/metabrainz/musicbrainz-server/… script runs well and seems to be a great way for creating the test database. We can test more cases using this way, I guess :). Example for generated sql for place > https://gist.github.com/ferbncode/31bf9cea8c4d886…

2017-07-13 19413, 2017

8:38 AM
psolanki

No.

2017-07-13 19414, 2017

8:38 AM
psolanki

I am adding and modifying some test scripts and run them individually with the command you suggested

2017-07-13 19418, 2017

8:38 AM
psolanki

"docker-compose -f docker/docker-compose.dev.yml run critiquebrainz py.test <filename>"

2017-07-13 19444, 2017

8:38 AM
CatQuest

ruaok: shall i start an import on lb while I myself go off in the sun that's appaeared today?

2017-07-13 19444, 2017

8:38 AM
alastairp

ferbncode: cool. the question now is to see how you can import those sql scripts on demand in a test

2017-07-13 19451, 2017

8:38 AM
alastairp

or if it's easier to use create_sample_data

2017-07-13 19421, 2017

8:39 AM
alastairp

(I didn't know that create_sample_data existed - it might be a better solution, although you'll still need a test database)

2017-07-13 19451, 2017

8:40 AM
CatQuest

(I readabout listenbrainz reset yesterday)

2017-07-13 19453, 2017

8:40 AM
alastairp

CatQuest: that'd be great, thanks. note that ruaok had some counting problems, so perhaps you will have (worse than normal) problems too

2017-07-13 19407, 2017

8:41 AM
alastairp

but it's always nice to have more data

2017-07-13 19415, 2017

8:41 AM
ferbncode

I tried https://github.com/ferbncode/critiquebrainz/commi… for create_sample_data (works too) but sample data does not have example release_groups like https://critiquebrainz.org/release-group/8ef859e3… (multiple artists)

2017-07-13 19451, 2017

8:41 AM
CatQuest is afraid that ruaok didn't want to ask me since I said about it being a hassle (my point that time ws that doing it for testing to secure a great working lb isn't a hassle)

2017-07-13 19425, 2017

8:42 AM
alastairp

right. another consideration is that we work with luks to improve the quality of the test data in mbdata - but that might take a few days to get some feedback from him

2017-07-13 19411, 2017

8:43 AM
CatQuest

well I'm not using the computer now becasue going out in the sun, so it might as well import int olb. even if you wipe the db in a few hours

2017-07-13 19429, 2017

8:43 AM
alastairp

psolanki: can you paste a full output of the error that you get? or put the code in its broken state in github somewhere so that someone else can test?

2017-07-13 19456, 2017

8:43 AM
CatQuest

also I can' tel you when it's done, so you'll have to check youselves https://beta.listenbrainz.org/user/CatCat vs https://www.last.fm/user/Nasasie and such

2017-07-13 19459, 2017

8:43 AM
alastairp

is this the error that Gentlecat was saying about the PR that you made? can I test it?

2017-07-13 19427, 2017

8:44 AM
alastairp

CatQuest: if you're going out and there's nothing to prevent you from running it while you're away I would say yes - thanks!

2017-07-13 19439, 2017

8:44 AM
ferbncode

alastairp: so, I would try to setup and run the sql generated and get back to you in case of anything. :)

2017-07-13 19441, 2017

8:44 AM
CatQuest starting it

2017-07-13 19451, 2017

8:44 AM
alastairp

ferbncode: cool, let me know how you go

2017-07-13 19407, 2017

8:45 AM
ferbncode

alastairp: sure, thanks :)

2017-07-13 19417, 2017

8:45 AM
alastairp

sorry about the late review... I'm mostly on top of my reviews now so it should be faster from now on

2017-07-13 19430, 2017

8:45 AM
CatQuest

not a problem. as I said, it's definitely not a hassle to do this like this. it's great to be useful to listenbrainz <3

2017-07-13 19401, 2017

8:46 AM
CatQuest

alastairp: *do* tell that to rob will you :)

2017-07-13 19412, 2017

8:46 AM
CatQuest off in the sun \o

2017-07-13 19424, 2017

8:46 AM
ferbncode

alastairp: thanks for the review, will definitely get the code and me improving :)

2017-07-13 19410, 2017

8:48 AM
psolanki

alastairp: https://gist.github.com/ps2611/ccdeda00bd634ddde7…

2017-07-13 19410, 2017

8:48 AM
psolanki

And when I change it to "from critiquebrainz.db import users as db_users",

2017-07-13 19411, 2017

8:48 AM
psolanki

It works perfectly fine

2017-07-13 19429, 2017

8:49 AM
psolanki

I discussed it with Gentlecat and he told me to remove .pyc files

2017-07-13 19430, 2017

8:49 AM
psolanki

But the problem is that they keep generating again and cause the error

2017-07-13 19429, 2017

8:50 AM
Gentlecat

that was the suggestion we had at the time, but it's obviously a temporary solution

2017-07-13 19403, 2017

8:52 AM
alastairp

so the error doesn't happen once, then when the pyc files are created it starts happening

2017-07-13 19408, 2017

8:52 AM
alastairp

until you delete them again?

2017-07-13 19412, 2017

8:55 AM
Gentlecat

and yeah, is that code on github?

2017-07-13 19401, 2017

8:56 AM
alastairp

hmm, the other thing that I just noticed is that you have a circular import

2017-07-13 19422, 2017

8:56 AM
alastairp

av_rating_test -> db.users -> db.revision -> db.review -> db.user -> db.users

2017-07-13 19451, 2017

8:56 AM
alastairp

which could very well be the problem too

2017-07-13 19416, 2017

8:58 AM
github joined the channel

2017-07-13 19416, 2017

8:58 AM
github

[musicbrainz-server] ferbncode opened pull request #528: MBS-9401: Fix sql query to fetch releases in dump-entities-sql.pl (master...fix-dump-release-groups) https://git.io/vQ9oH

2017-07-13 19416, 2017

8:58 AM
github has left the channel

2017-07-13 19450, 2017

8:58 AM
psolanki

alastairp: I tried running in /bin/bash ,delete the .pyc files and then pytest

2017-07-13 19451, 2017

8:58 AM
psolanki

But it gives the same error

2017-07-13 19422, 2017

8:59 AM
psolanki

And yes, this code is on github

2017-07-13 19406, 2017

9:01 AM
alastairp

I'm still not sure of the process where you get the error - sorry, what you said was unclear

2017-07-13 19413, 2017

9:01 AM
alastairp

do you *always* get the error?

2017-07-13 19415, 2017

9:02 AM
psolanki

Not if change "import critiquebrainz.db.users as db_users"

2017-07-13 19416, 2017

9:02 AM
psolanki

to "from critiquebrainz.db import users as db_users"

2017-07-13 19414, 2017

9:03 AM
alastairp

OK, I was unsure because you were talking about deleting the pyc files. I thought that the error did not happen directly after you deleted pyc files

2017-07-13 19416, 2017

9:03 AM
psolanki

It works like a charm, all test pass

2017-07-13 19459, 2017

9:04 AM
psolanki

I don't understand how a mere syntax change makes the difference

2017-07-13 19457, 2017

9:06 AM
alastairp

https://www.irccloud.com/pastebin/ya1MmH6F/

2017-07-13 19423, 2017

9:07 AM
alastairp

I just recreated the error in a dummy structure - this is completely outside of critiquebrainz

2017-07-13 19435, 2017

9:07 AM
alastairp

I now think that the error is because of a circular import

2017-07-13 19453, 2017

9:07 AM
alastairp

see that you import the `users` module twice? once in the test file, and one in `user`?

2017-07-13 19423, 2017

9:08 AM
alastairp

because of the way python works, it definitely makes sense that it would work with the other type of import

2017-07-13 19412, 2017

9:09 AM
alastairp

note that it's not _just_ a syntax change. because of the way python packages work it's actually doing something different with the other import statement

2017-07-13 19405, 2017

9:10 AM
alastairp

can you link us to the branch on github where you see the error? (it's easier for you to tell us where it is, rather than us go and look for it)

2017-07-13 19446, 2017

9:12 AM
psolanki

https://github.com/metabrainz/critiquebrainz/pull…

2017-07-13 19413, 2017

9:19 AM
psolanki

What if we want to import a certain class.

2017-07-13 19414, 2017

9:19 AM
psolanki

Have a look at this error - https://gist.github.com/ps2611/2cd178400ba5f919be…

2017-07-13 19429, 2017

9:23 AM
D4RK-PH0ENiX joined the channel

2017-07-13 19413, 2017

9:27 AM
Nyanko-sensei has quit

2017-07-13 19409, 2017

9:29 AM
alastairp

right

2017-07-13 19425, 2017

9:29 AM
alastairp

that is because of the import on line 9

2017-07-13 19451, 2017

9:29 AM
alastairp

when python is reading a file and gets to an import it jumps to that other file

2017-07-13 19456, 2017

9:29 AM
alastairp

so you start reading user.py

2017-07-13 19405, 2017

9:30 AM
alastairp

then go through a bunch of other files

2017-07-13 19426, 2017

9:30 AM
alastairp

when you get to line 8 in review.py, the User class in user.py doesn't exist yet

2017-07-13 19430, 2017

9:31 AM
alastairp

because the python interpreter only got to line 2 in user.py before importing users.py

2017-07-13 19440, 2017

9:45 AM
iliekcomputers

ruaok: last.fm shows 71602 scrobbles here https://www.last.fm/user/mayhemchaos/library

2017-07-13 19458, 2017

9:45 AM
iliekcomputers

*71062

2017-07-13 19408, 2017

9:46 AM
iliekcomputers

and 71319 scrobbles here https://www.last.fm/user/mayhemchaos

2017-07-13 19426, 2017

9:47 AM
iliekcomputers

it sends us 71062 on the api

2017-07-13 19440, 2017

9:48 AM
ruaok

am I the only person with this problem?

2017-07-13 19441, 2017

9:48 AM
alastairp

the number says one thing, and you get a different number of them from the API?

2017-07-13 19442, 2017

9:48 AM
alastairp

awesome

2017-07-13 19456, 2017

9:48 AM
ruaok

yeah, that's going to be hell for us to answer to. :(

2017-07-13 19416, 2017

9:49 AM
iliekcomputers

:(

2017-07-13 19451, 2017

9:50 AM
iliekcomputers

CatQuest is doing an import, in the meanwhile I checked myself and the number of pages and scrobbles matches up for CatQuest

2017-07-13 19457, 2017

9:50 AM
ruaok

alastairp: did your number match?

2017-07-13 19411, 2017

9:51 AM
alastairp

I didn't even check. let me do that now

2017-07-13 19420, 2017

9:51 AM
ruaok

I need to check catquest's import into my test account and see how that turned out.

2017-07-13 19438, 2017

9:51 AM
alastairp

oh wow, exactly the same

2017-07-13 19406, 2017

9:52 AM
alastairp

but mark (?) found 2 with the same timestamp/name

2017-07-13 19414, 2017

9:52 AM
alastairp

not sure what you fixed :)

2017-07-13 19423, 2017

9:52 AM
iliekcomputers

alastairp: they didn't have the same name

2017-07-13 19427, 2017

9:52 AM
alastairp

ah

2017-07-13 19458, 2017

9:53 AM
iliekcomputers

https://chatlogs.metabrainz.org/brainzbot/metabra…

2017-07-13 19400, 2017

9:54 AM
iliekcomputers

https://pastebin.com/raKqkw0D

2017-07-13 19419, 2017

9:54 AM
alastairp

OK, so this is the magic fix that we did yesterday

2017-07-13 19422, 2017

9:54 AM
alastairp

great!

2017-07-13 19457, 2017

9:57 AM
iliekcomputers

https://github.com/metabrainz/listenbrainz-server… if you want to review :)

2017-07-13 19430, 2017

10:18 AM
lazka joined the channel

2017-07-13 19450, 2017

10:26 AM
ruaok

the review is merged, so it is ready for your review, alastairp. :)

2017-07-13 19402, 2017

10:27 AM
alastairp

:( so mean

2017-07-13 19411, 2017

10:27 AM
alastairp

I was thinking exactly that

2017-07-13 19416, 2017

10:27 AM
ruaok

awww <3