CatQuest: nope, those arent a label, DistroKid is a tool to distribute the digital music to various platforms, but it sets a pseudo-label for that (i guess real labels using it are properly set), that's usually musicians themselves. So it would be [no label] instead i think
2017-07-16 19744, 2017
zas
samj1912: one blocker, fix for track numbering is only in beta mbs right ?
2017-07-16 19700, 2017
samj1912
yes
2017-07-16 19723, 2017
samj1912
bitmap: said he'd make a release monday
2017-07-16 19741, 2017
zas
ok, then we'll merge after the release
2017-07-16 19747, 2017
samj1912
okay
2017-07-16 19708, 2017
drsaunders joined the channel
2017-07-16 19710, 2017
drsaunders has quit
2017-07-16 19757, 2017
cjnolet_ joined the channel
2017-07-16 19704, 2017
cjnolet has quit
2017-07-16 19720, 2017
CatQuest
should still be [no label] *as* whatever-the-distrokid-thing-says when we get artist credits
but other than that, the track number thing is the only one that we should definitely wait for
2017-07-16 19723, 2017
ephemer0l has quit
2017-07-16 19721, 2017
samj1912
Mineo: I added a check for if not track format cases like these
2017-07-16 19734, 2017
samj1912
I removed them later as you said they were not needed
2017-07-16 19708, 2017
samj1912
s/format/for
2017-07-16 19744, 2017
ephemer0l_ joined the channel
2017-07-16 19746, 2017
samj1912
Mineo: can you still reproduce it with the latest commit?
2017-07-16 19720, 2017
Mineo
no, but I can tell you why it happens: previously, when parse_recording was called at https://github.com/metabrainz/picard/pull/760/fil… it returned None if the recording data had no title, but parse_recording was also what called `append_child` on `recording_node_el`. now, `append` on `recording_list` is called in `_on_lookup_finished`. I think it would make way more sense
2017-07-16 19720, 2017
Mineo
to filter the Nones returned by `parse_recording` in `_on_lookup_finished` instead of having `compare_to_track` handle that
2017-07-16 19745, 2017
Mineo
if we start handling cases like this deep down in compare_to_track or what have you we're going down the rabbit hole of essentially having to patch every single function that receives parsed data to handle nones or invalid data
2017-07-16 19734, 2017
UmkaDK has quit
2017-07-16 19750, 2017
SothoTalker_ has quit
2017-07-16 19734, 2017
Slurpee joined the channel
2017-07-16 19734, 2017
Slurpee has quit
2017-07-16 19734, 2017
Slurpee joined the channel
2017-07-16 19748, 2017
SothoTalKer joined the channel
2017-07-16 19753, 2017
samj1912
Mineo: fixed
2017-07-16 19759, 2017
samj1912
thanks for catching that
2017-07-16 19702, 2017
Rotab has quit
2017-07-16 19744, 2017
Slurpee has quit
2017-07-16 19741, 2017
Mineo
you're welcome
2017-07-16 19701, 2017
Mineo
I seem to have a knack for breaking things as soon as I touch them :(
