#metabrainz

Mineo any blocker to merging gh:P#760?

Migrate picard to json API: https://github.com/metabrainz/picard/pull/760

CatQuest: nope, those arent a label, DistroKid is a tool to distribute the digital music to various platforms, but it sets a pseudo-label for that (i guess real labels using it are properly set), that's usually musicians themselves. So it would be [no label] instead i think

samj1912: one blocker, fix for track numbering is only in beta mbs right ?

yes

bitmap: said he'd make a release monday

ok, then we'll merge after the release

okay

should still be [no label] *as* whatever-the-distrokid-thing-says when we get artist credits

samj1912, I can still reproduce https://github.com/metabrainz/picard/pull/760#d... (I've narrow it down to this track: https://musicbrainz.org/release/772ae1d4-4fa8-4... )

but other than that, the track number thing is the only one that we should definitely wait for

Mineo: I added a check for if not track format cases like these

I removed them later as you said they were not needed

s/format/for

Mineo: can you still reproduce it with the latest commit?

no, but I can tell you why it happens: previously, when parse_recording was called at https://github.com/metabrainz/picard/pull/760/f... it returned None if the recording data had no title, but parse_recording was also what called `append_child` on `recording_node_el`. now, `append` on `recording_list` is called in `_on_lookup_finished`. I think it would make way more sense

to filter the Nones returned by `parse_recording` in `_on_lookup_finished` instead of having `compare_to_track` handle that

if we start handling cases like this deep down in compare_to_track or what have you we're going down the rabbit hole of essentially having to patch every single function that receives parsed data to handle nones or invalid data

Mineo: fixed

thanks for catching that

you're welcome

I seem to have a knack for breaking things as soon as I touch them :(

an amazing quality to have when reviewing code :P

2.2M listens in beta.lb.org not broken yet.

plz to do an import??

iliekcomputers: https://github.com/metabrainz/listenbrainz-serv... is now ready

CallerNo6: https://listenbrainz.readthedocs.io/en/latest/d... docs build fine now.

It just needed to believe in itself?

yes, a little positive affirmation and and some soothing thoughts from jack handy. then bam!

Quesito: https://twitter.com/nightrose/status/8866702535...

And loujine of course