great, thanks. that's probably our fault and we can fix it then
2017-07-17 19837, 2017
alastairp
I'll let ruaok chime in when he's had more coffee
2017-07-17 19855, 2017
alastairp
we can configure the rate limiting values, perhaps it's more strict on beta than non-beta
2017-07-17 19820, 2017
pprkut
I don't necessarily a problem with the 429 response itself, but how the status widget deals with them
2017-07-17 19837, 2017
pprkut
*don't think it's
2017-07-17 19840, 2017
alastairp
iliekcomputers: perhaps if the error is 429 1) we shouldn't show "an error occurred", and 2) we should anticipate the rate limiting and slow down before we get the error
2017-07-17 19847, 2017
alastairp
pprkut: ^ I was getting to that next :)
2017-07-17 19851, 2017
pprkut
:)
2017-07-17 19838, 2017
pprkut
also, if there's still requests being made, the widget shouldn't really show "Import finished!" either
2017-07-17 19802, 2017
ruaok
Was that an alpha import? Or last.fm import?
2017-07-17 19808, 2017
pprkut
last.fm
2017-07-17 19820, 2017
ruaok
K
2017-07-17 19845, 2017
ruaok
429 means the scraper is making requests of beta.lb too fast.
2017-07-17 19853, 2017
ruaok
It shouldn't happen.
2017-07-17 19825, 2017
alastairp
ruaok: do you have different limits on beta?
2017-07-17 19837, 2017
alastairp
(though yeah, the importer should back off, right?)
2017-07-17 19856, 2017
pprkut
according to chromium's console it was making roughly 40-50 requests / second
2017-07-17 19856, 2017
ruaok
let me look at the limits. either way the scraper should not have problems...
2017-07-17 19806, 2017
ruaok
pprkut: ah yes, then there is a problem.
2017-07-17 19815, 2017
ruaok
there is one fix that I haven't deployed. let me try and do that now.
this shouldn't be pageDone(), it should be submitListens(), pageDone increases the count of the number of pages done which is why the import message flashes, i think
2017-07-17 19818, 2017
iliekcomputers
*import finished message
2017-07-17 19856, 2017
pprkut
should I wait?
2017-07-17 19844, 2017
SothoTalker_ joined the channel
2017-07-17 19848, 2017
SothoTalKer has quit
2017-07-17 19848, 2017
ruaok
pprkut: yeah, what iliekcomputers is interesting.
2017-07-17 19826, 2017
alastairp
11:39 AM <pprkut> also, if there's still requests being made, the widget shouldn't really show "Import finished!" either
2017-07-17 19837, 2017
alastairp
iliekcomputers: I'll open a ticket for that... ?
2017-07-17 19841, 2017
alastairp
or have you already fixed it?
2017-07-17 19827, 2017
ruaok
iliekcomputers may be onto the fix.
2017-07-17 19842, 2017
iliekcomputers
fixing, one line change really
2017-07-17 19842, 2017
ruaok
want me to make the change and deploy it, iliekcomputers?
2017-07-17 19847, 2017
ruaok
ok
2017-07-17 19820, 2017
ruaok
the api-docs PR has been updated too, iliekcomputers.
2017-07-17 19837, 2017
ruaok
wording was in fact confusing. :)
2017-07-17 19806, 2017
iliekcomputers
awesome :)
2017-07-17 19855, 2017
github joined the channel
2017-07-17 19855, 2017
github
[listenbrainz-server] paramsingh opened pull request #229: Change pageDone to submitListens (master...page-done-submit-listens) https://git.io/vQbBm
2017-07-17 19855, 2017
github has left the channel
2017-07-17 19800, 2017
ruaok
ok, will look.
2017-07-17 19808, 2017
ruaok
lets see if we can both of these merged right now, shall we?
2017-07-17 19838, 2017
iliekcomputers
okay
2017-07-17 19849, 2017
ruaok
formatting is crap on my URLs, but good enough for right now
2017-07-17 19810, 2017
github joined the channel
2017-07-17 19810, 2017
github
[listenbrainz-server] mayhem closed pull request #220: API docs (master...api-docs) https://git.io/vQw2H
the business that was sold to Warner is the business that uses our data. we should hang tight until the acquisition is complete, then we'll hit warner.
2017-07-17 19825, 2017
ruaok cackles and evil laugh
2017-07-17 19829, 2017
ruaok
-d
2017-07-17 19814, 2017
iliekcomputers
ahahah nice
2017-07-17 19803, 2017
ferbncode
Freso: I might not be able to make it to the meeting tonight.
2017-07-17 19803, 2017
ferbncode
(travelling back to college, so not sure about the network in train.)
