[critiquebrainz] gentlecat closed pull request #132: Remove 'popularity' where its not used in correct form (master...remove-popularity) https://git.io/vQxtT
2017-07-20 20137, 2017
github has left the channel
2017-07-20 20120, 2017
github joined the channel
2017-07-20 20120, 2017
github
[critiquebrainz] gentlecat closed pull request #133: Consolidate votes in a dict in db.review.get_by_id() function (master...votes-dict) https://git.io/vQxYi
2017-07-20 20120, 2017
github has left the channel
2017-07-20 20121, 2017
samj1912 joined the channel
2017-07-20 20100, 2017
Major_Lurker has quit
2017-07-20 20114, 2017
Major_Lurker joined the channel
2017-07-20 20126, 2017
d4rkie joined the channel
2017-07-20 20101, 2017
D4RK-PH0ENiX has quit
2017-07-20 20141, 2017
github joined the channel
2017-07-20 20141, 2017
github
[critiquebrainz] ferbncode opened pull request #134: [WIP]: CB-231: Add tests for musicbrainz database (master...testdb) https://git.io/v7vYN
And, I would like to discuss the details of the next step. Thanks
2017-07-20 20122, 2017
Gentlecat
sure!
2017-07-20 20114, 2017
Gentlecat
what would you like to discuss?
2017-07-20 20154, 2017
psolanki
About the actual rating stars to be used.
2017-07-20 20155, 2017
psolanki
I have looked at how its done in MB.
2017-07-20 20154, 2017
Gentlecat
yes
2017-07-20 20122, 2017
psolanki
Exactly like that or do you have any better suggestions?
2017-07-20 20144, 2017
Gentlecat
I can't help much with that
2017-07-20 20109, 2017
Gentlecat
you should do some research into what ways of implementing the UI for that are used these days
2017-07-20 20134, 2017
Gentlecat
if you find something, feel free to send us a link and we can share opinions before you implement something
2017-07-20 20131, 2017
psolanki
Alright. I will tell what I come up with.
2017-07-20 20149, 2017
lazka joined the channel
2017-07-20 20108, 2017
alastairp
Gentlecat: in CB, you have all config in config.py and then overwrite them specifically in custom_config. is that intentional - anything in custom_config will also exist in config as a default?
2017-07-20 20128, 2017
Gentlecat
yes, that's intentional
2017-07-20 20147, 2017
Gentlecat
they are in somewhat prioritized order
2017-07-20 20109, 2017
Gentlecat
you'd typically have custom_config in development environment
2017-07-20 20126, 2017
Gentlecat
not sure what you mean by "exist in config as a default"
2017-07-20 20104, 2017
Gentlecat
as in there are default values for each option, yes
2017-07-20 20104, 2017
alastairp
I mean all lines in custom_config are also in config
2017-07-20 20126, 2017
Gentlecat
you mean default_config?
2017-07-20 20140, 2017
alastairp
oh yes, it's called default_config
2017-07-20 20144, 2017
alastairp
that's the one
2017-07-20 20122, 2017
Gentlecat
default_config is mostly adjusted for development environment as well
2017-07-20 20159, 2017
alastairp
I see that custom_config is optional
2017-07-20 20111, 2017
Gentlecat
yes
2017-07-20 20126, 2017
Gentlecat
that file is not in production for example
2017-07-20 20128, 2017
alastairp
does that mean CB will work if I just built the docker images and ran it, without making a default_config?
2017-07-20 20131, 2017
alastairp
right
2017-07-20 20140, 2017
alastairp
production uses consul_config
2017-07-20 20145, 2017
alastairp
dev uses default_config
2017-07-20 20146, 2017
Gentlecat
yeah, though some thing probably won't work
2017-07-20 20101, 2017
alastairp
test sends config_path through the argument to init_app
ruaok: the only thing is that I want the compared value in the tests to be a fixed string, rather than constructed from method calls
2017-07-20 20135, 2017
ruaok
I dont think your request is clear from reading the comments.
2017-07-20 20153, 2017
alastairp
> It makes sense to use a plain string here as the first argument - var user_name = "some\\\\name etc"; because we know exactly what it should be after escaping.
2017-07-20 20104, 2017
ruaok
> ah, I just saw that the weird name has slashes and a space in it, never mind
2017-07-20 20121, 2017
alastairp
oh, right. the never mind was to my second point, not the whole one
2017-07-20 20124, 2017
alastairp
yeah, that could be unclear
2017-07-20 20127, 2017
ruaok
thx
2017-07-20 20141, 2017
agentsim joined the channel
2017-07-20 20144, 2017
github joined the channel
2017-07-20 20144, 2017
github
[listenbrainz-server] mayhem closed pull request #234: LB-191: Report errors on the API in json (master...json-errors) https://git.io/v7e3I
[picard] samj1912 opened pull request #765: Add WSRequest class to simplify WS code and add retries on temp failures (master...ws+) https://git.io/v7fqu
2017-07-20 20132, 2017
github has left the channel
2017-07-20 20153, 2017
drsaunders has quit
2017-07-20 20119, 2017
comradekingu has quit
2017-07-20 20151, 2017
samj1912
zas: refactored a lot of code
2017-07-20 20115, 2017
samj1912
did not implement the advanced retry features since I wanted to have a discussion about the implementation
2017-07-20 20133, 2017
samj1912
Sophist-UK: brought up some points later on gh:P#403
