#metabrainz

/

      • ohrstrom joined the channel
      • 2017-07-26 20753, 2017

      • drsaunders has quit
      • 2017-07-26 20756, 2017

      • github joined the channel
      • 2017-07-26 20756, 2017

      • github
        [picard] samj1912 opened pull request #776: Fix null type errors while parsing API response (master...null) https://git.io/v73vg
      • 2017-07-26 20756, 2017

      • github has left the channel
      • 2017-07-26 20719, 2017

      • armalcolite joined the channel
      • 2017-07-26 20718, 2017

      • samj1912
        zas: appveyor is doing something weird
      • 2017-07-26 20718, 2017

      • zas
        yes, it tries to test branch for pr ...
      • 2017-07-26 20721, 2017

      • zas
        check config
      • 2017-07-26 20704, 2017

      • samj1912
        that started happening after it was made a required check
      • 2017-07-26 20706, 2017

      • ohrstrom has quit
      • 2017-07-26 20723, 2017

      • samj1912
        zas: I cant fix it from config
      • 2017-07-26 20745, 2017

      • D4RK-PH0ENiX joined the channel
      • 2017-07-26 20748, 2017

      • d4rkie has quit
      • 2017-07-26 20753, 2017

      • drsaunders joined the channel
      • 2017-07-26 20721, 2017

      • D4RK-PH0ENiX has quit
      • 2017-07-26 20749, 2017

      • Leftmost joined the channel
      • 2017-07-26 20732, 2017

      • D4RK-PH0ENiX joined the channel
      • 2017-07-26 20704, 2017

      • D4RK-PH0ENiX has quit
      • 2017-07-26 20733, 2017

      • D4RK-PH0ENiX joined the channel
      • 2017-07-26 20730, 2017

      • Gentlecat
        psolanki: what stage are you at with the UI?
      • 2017-07-26 20717, 2017

      • ohrstrom joined the channel
      • 2017-07-26 20728, 2017

      • drsaunders has quit
      • 2017-07-26 20707, 2017

      • Wizzup has quit
      • 2017-07-26 20722, 2017

      • Lotheric joined the channel
      • 2017-07-26 20711, 2017

      • Wizzup joined the channel
      • 2017-07-26 20724, 2017

      • github joined the channel
      • 2017-07-26 20724, 2017

      • github
        [picard] zas closed pull request #776: Fix null type errors while parsing API response (master...null) https://git.io/v73vg
      • 2017-07-26 20724, 2017

      • github has left the channel
      • 2017-07-26 20758, 2017

      • travis-ci joined the channel
      • 2017-07-26 20759, 2017

      • travis-ci
        metabrainz/picard#2809 (master - a9665f6 : Laurent Monin): The build passed.
      • 2017-07-26 20759, 2017

      • travis-ci
      • 2017-07-26 20759, 2017

      • travis-ci
      • 2017-07-26 20759, 2017

      • travis-ci has left the channel
      • 2017-07-26 20703, 2017

      • black-perl_ has quit
      • 2017-07-26 20744, 2017

      • arbenina_ has quit
      • 2017-07-26 20725, 2017

      • ruaok
        9,701,978
      • 2017-07-26 20733, 2017

      • ruaok
        dragging ourselves to the finish line.
      • 2017-07-26 20752, 2017

      • Slurpee joined the channel
      • 2017-07-26 20752, 2017

      • Slurpee has quit
      • 2017-07-26 20752, 2017

      • Slurpee joined the channel
      • 2017-07-26 20746, 2017

      • colbydray joined the channel
      • 2017-07-26 20705, 2017

      • alastairp
        how many users?
      • 2017-07-26 20718, 2017

      • samj1912
        zas: how did you fix the appveyor thing?
      • 2017-07-26 20736, 2017

      • iliekcomputers
        alastairp: 135
      • 2017-07-26 20735, 2017

      • saifulbkhan joined the channel
      • 2017-07-26 20730, 2017

      • reosarevok facepalms
      • 2017-07-26 20709, 2017

      • reosarevok
        Another email by someone thinking the "authority control" link to MB on a Wikipedia page means we run the page and they need to ask permission from the "authorities" to change stuff :p
      • 2017-07-26 20703, 2017

      • zas
        samj1912: i removed the required attribute for appveyor "branch" (and kept "pr")
      • 2017-07-26 20742, 2017

      • zas
        ruaok, reosarevok: it seems to confirm we don't lack stupid people on Earth ;)
      • 2017-07-26 20722, 2017

      • ruaok
        there is only one thing more abundant than hydrogen in the universe: stupidity.
      • 2017-07-26 20701, 2017

      • psolanki
        Gentlecat: rendered the rating display and necessary changes in form
      • 2017-07-26 20702, 2017

      • psolanki
        Styling part is to be done
      • 2017-07-26 20703, 2017

      • psolanki
        will make a PR soon
      • 2017-07-26 20737, 2017

      • Gentlecat
        ok, I'll be waiting
      • 2017-07-26 20751, 2017

      • UmkaDK has quit
      • 2017-07-26 20752, 2017

      • arbenina_ joined the channel
      • 2017-07-26 20753, 2017

      • ruaok
        zas: we currently have two musicbrainz.org SSL certs. mb.org and *.mb.org. mb.org is up for renewal soon. I believe we're not using that one. confirm?
      • 2017-07-26 20722, 2017

      • UmkaDK joined the channel
      • 2017-07-26 20745, 2017

      • zas
        let me check
      • 2017-07-26 20756, 2017

      • zas
        confirmed, we don't use mb.org one, only the wildcard one
      • 2017-07-26 20709, 2017

      • ruaok
        oki
      • 2017-07-26 20714, 2017

      • ruaok
        9,845,364!
      • 2017-07-26 20716, 2017

      • ruaok
        so close.
      • 2017-07-26 20717, 2017

      • MajorLurker has quit
      • 2017-07-26 20717, 2017

      • iliekcomputers
        :)
      • 2017-07-26 20757, 2017

      • drsaunders joined the channel
      • 2017-07-26 20702, 2017

      • agentsim joined the channel
      • 2017-07-26 20750, 2017

      • samj1912
        zas: so, I have completed most of the network related refactoring required, I was wondering what direction to take to improve UI responsiveness and I/O. The main problem is that the tips in Qt dont exactly apply to pyqt because it is not able to multithread in essence because of GIL in cpython.
      • 2017-07-26 20703, 2017

      • samj1912
        Mineo, Sophist-UK feel free to pitch in ^
      • 2017-07-26 20749, 2017

      • colbydray has quit
      • 2017-07-26 20708, 2017

      • zas
      • 2017-07-26 20755, 2017

      • zas
      • 2017-07-26 20708, 2017

      • zas
        Short version: it sucks ;)
      • 2017-07-26 20729, 2017

      • samj1912
        bitmap: you implemented the threading in picard right? any thoughts?
      • 2017-07-26 20743, 2017

      • drsaunders has quit
      • 2017-07-26 20746, 2017

      • ruaok
        I once told guido the exact same thing and that I had visualized the GIL in my burning man art project.
      • 2017-07-26 20758, 2017

      • ruaok
        he looked at me quite odd, which was normal for him when talking to me. :)
      • 2017-07-26 20730, 2017

      • samj1912
        BDFL works in mysterious ways :P
      • 2017-07-26 20751, 2017

      • ruaok
        :)
      • 2017-07-26 20712, 2017

      • samj1912
        I would love to meet him some day :P
      • 2017-07-26 20719, 2017

      • samj1912
        kind of a fan boy :P
      • 2017-07-26 20720, 2017

      • ruaok
        iliekcomputers: got a minute?
      • 2017-07-26 20747, 2017

      • ruaok
        go to open source conferences -- he attends quite a few that have python tracks
      • 2017-07-26 20756, 2017

      • samj1912
        ruaok: I would love to :P, maybe some day :p
      • 2017-07-26 20706, 2017

      • zas
        Ok, how does it affect Picard ?
      • 2017-07-26 20714, 2017

      • Gentlecat
        samj1912: look up pycon talks by Dave Beazley
      • 2017-07-26 20728, 2017

      • zas
      • 2017-07-26 20736, 2017

      • samj1912
        well, I think lazka said something about mutagen not occupying much cpu time, but that doesn't correspond with what we see in picard
      • 2017-07-26 20753, 2017

      • samj1912
        the ui becomes generally unresponsive while loading files
      • 2017-07-26 20758, 2017

      • samj1912
        and while saving a ton of them
      • 2017-07-26 20737, 2017

      • samj1912
        this might be because of how we have implemented the threading code and the fact that the UI thread runs on the same thread as loading thread
      • 2017-07-26 20748, 2017

      • samj1912
        however that does not explain the slow down on saving
      • 2017-07-26 20749, 2017

      • github joined the channel
      • 2017-07-26 20750, 2017

      • github
        [listenbrainz-server] mayhem closed pull request #236: Make the API blueprint use a url prefix when registering (master...api/prefix-var) https://git.io/v7fxi
      • 2017-07-26 20750, 2017

      • github has left the channel
      • 2017-07-26 20719, 2017

      • ruaok
        alastairp: your last import stamp says you haven't imported into listenbrainz yet. is that the case or is that a bug?
      • 2017-07-26 20703, 2017

      • samj1912
        zas: ?
      • 2017-07-26 20728, 2017

      • bitmap
        samj1912: didn't Sophist-UK do a lot of investigation into that? I don't really remember how it's implemented anymore
      • 2017-07-26 20739, 2017

      • iliekcomputers
        ruaok: Sup?
      • 2017-07-26 20754, 2017

      • ruaok
        samj1912: do a beta.listenbrainz.org import please!
      • 2017-07-26 20754, 2017

      • alastairp
        ruaok: I should write an angry letter to someone about people spying on my data :)
      • 2017-07-26 20757, 2017

      • zas
        yes, Sophist-UK investigated it a lot, but i'm not sure about solutions proposed
      • 2017-07-26 20705, 2017

      • samj1912
        neither am I
      • 2017-07-26 20707, 2017

      • Sophist-UK
        zas, samj1912: I have not looked at "tips" in pyqt specifically. I did a lot of work on this for 1.4.0 in a PR - I would have to look up the number.
      • 2017-07-26 20713, 2017

      • ruaok
        alastairp: I know exactly where that would get filed. :)
      • 2017-07-26 20718, 2017

      • Sophist-UK
        I can talk you through what I did and why and you can retrofit it.
      • 2017-07-26 20724, 2017

      • alastairp
        and this is why I won't actually write it
      • 2017-07-26 20729, 2017

      • Sophist-UK
        But the current implementation is not correct.
      • 2017-07-26 20738, 2017

      • samj1912
        ruaok: I dont use last.fm
      • 2017-07-26 20738, 2017

      • Sophist-UK
        It uses the wrong pre-empt call.
      • 2017-07-26 20753, 2017

      • ruaok
        samj1912: k, thanks.
      • 2017-07-26 20756, 2017

      • Sophist-UK
        And we should probably be using signals anyway.
      • 2017-07-26 20718, 2017

      • samj1912
        Sophist-UK: gh:P#604
      • 2017-07-26 20719, 2017

      • BrainzBot
        PICARD-936: Improve UI responsiveness whilst busy loading, saving etc.: https://github.com/metabrainz/picard/pull/604
      • 2017-07-26 20736, 2017

      • Sophist-UK
        That's the one.
      • 2017-07-26 20746, 2017

      • samj1912
        it was very buggy when it came to handling signals
      • 2017-07-26 20755, 2017

      • samj1912
        picard wont close on ctrl+c anymore
      • 2017-07-26 20702, 2017

      • Sophist-UK
        But it was one of those problems where as you dig you find more issues and then it gets messy and in the end times out.
      • 2017-07-26 20708, 2017

      • samj1912
        yes
      • 2017-07-26 20726, 2017

      • samj1912
        and I am not sure about the random processevent calls we had
      • 2017-07-26 20754, 2017

      • samj1912
        and the priority queue you had implemented
      • 2017-07-26 20754, 2017

      • alastairp
        ruaok: imported
      • 2017-07-26 20700, 2017

      • alastairp
        exactly the same number of listens
      • 2017-07-26 20704, 2017

      • ruaok
        great.
      • 2017-07-26 20715, 2017

      • alastairp
        apparently none of my music players are scrobbling to lastfm any more
      • 2017-07-26 20719, 2017

      • alastairp
        but that's not your fault
      • 2017-07-26 20723, 2017

      • Sophist-UK
        1. ProcessEvent does not work the way thread.py thinks it will.
      • 2017-07-26 20741, 2017

      • ruaok
        I'm itching to make spotify recording work with the new endpoint hugh hacked up.
      • 2017-07-26 20742, 2017

      • Sophist-UK
        You can only call ProcessEvent when you are on the main thread.
      • 2017-07-26 20758, 2017

      • ruaok
        not sure how well it can scale or how auth works, but I am dying to dive in.
      • 2017-07-26 20704, 2017

      • Sophist-UK
        What you need to do is a micro-sleep on the worker thread to give the main thread a chance of getting a look in.
      • 2017-07-26 20727, 2017

      • samj1912
        Sophist-UK: there should be a better solution for this than introducing sleepers to pre-empt threads
      • 2017-07-26 20754, 2017

      • Sophist-UK
        On Py 3.2+ (?) - anyway for Py3 we are using - GIL is better at choosing which thread to run and in particular better if you set O/S thread priorities.
      • 2017-07-26 20708, 2017

      • Sophist-UK
        samj1912: Not as far as I am aware.
      • 2017-07-26 20717, 2017

      • chirlu has quit
      • 2017-07-26 20735, 2017

      • Sophist-UK
        You can adjust how frequently it interrupts threads to allow another one a chance to execute.
      • 2017-07-26 20751, 2017

      • Sophist-UK
        But Py3 is better.
      • 2017-07-26 20714, 2017

      • zas
        Py3.5+ will be used
      • 2017-07-26 20721, 2017

      • zas
        that's for Picard2
      • 2017-07-26 20758, 2017

      • samj1912
        Sophist-UK: there are also those recursion errors that happened when you tried all of this
      • 2017-07-26 20714, 2017

      • Sophist-UK
        In #604 I did a micro-sleep just before a worker thread terminated (which obviously has little impact) in order to prevent the next worker thread from executing instead of the main thread.
      • 2017-07-26 20719, 2017

      • Sophist-UK
        Back in a few mins - customer here.
      • 2017-07-26 20748, 2017

      • iliekcomputers
        ruaok: what was it you wanted to talk about?
      • 2017-07-26 20719, 2017

      • ruaok
        making the switch from beta to production.
      • 2017-07-26 20740, 2017

      • ruaok
        got a minute or two to work on a switchover plan?
      • 2017-07-26 20750, 2017

      • iliekcomputers
        Yeah sure
      • 2017-07-26 20751, 2017

      • chirlu joined the channel
      • 2017-07-26 20735, 2017

      • samj1912
        zas: just fyi, I worked on gnome music for a while and they use a tracker to load the mp3 files in bg, we can look into IPC instead of threads
      • 2017-07-26 20754, 2017

      • samj1912
        but that code might be a bit out of scope for this gsoc project