13:39 PM
x3YTjJV6asPhskrZ
i can work on a workaround if you want
2017-08-04 21609, 2017
13:40 PM
samj1912
you can describe the algorithm
2017-08-04 21616, 2017
13:40 PM
arbenina_ has quit
2017-08-04 21619, 2017
13:40 PM
samj1912
and show how it is better
2017-08-04 21628, 2017
13:40 PM
x3YTjJV6asPhskrZ
okay
2017-08-04 21638, 2017
13:40 PM
samj1912
although that would be very qualitative
2017-08-04 21612, 2017
13:41 PM
x3YTjJV6asPhskrZ
tell you what, ill copy this code and play around with it in python
2017-08-04 21619, 2017
13:41 PM
samj1912
cool
2017-08-04 21622, 2017
13:41 PM
x3YTjJV6asPhskrZ
and if i find something i show you
2017-08-04 21639, 2017
13:41 PM
samj1912
you might also need some data from the WS to play around with
2017-08-04 21653, 2017
13:41 PM
x3YTjJV6asPhskrZ
yes please :3
2017-08-04 21657, 2017
13:41 PM
samj1912
well :P
2017-08-04 21600, 2017
13:42 PM
samj1912
you can query it
2017-08-04 21616, 2017
13:42 PM
x3YTjJV6asPhskrZ
okay sure...how do i do that?
2017-08-04 21621, 2017
13:42 PM
samj1912
2017-08-04 21625, 2017
13:42 PM
samj1912
all yours :D
2017-08-04 21647, 2017
13:42 PM
samj1912
2017-08-04 21600, 2017
13:43 PM
samj1912
a list of really dense(metadata wise) release groups :)
2017-08-04 21609, 2017
13:43 PM
x3YTjJV6asPhskrZ
ahh okay
2017-08-04 21615, 2017
13:43 PM
samj1912
anything else I can help you with?
2017-08-04 21627, 2017
13:43 PM
x3YTjJV6asPhskrZ
nah thats it for now, thanks!
2017-08-04 21644, 2017
13:43 PM
samj1912
also, as for tagging singles, I did suggest you look at beets
2017-08-04 21653, 2017
13:43 PM
x3YTjJV6asPhskrZ
yeah
2017-08-04 21610, 2017
13:44 PM
samj1912
picard is not a mass tagger :P
2017-08-04 21622, 2017
13:44 PM
x3YTjJV6asPhskrZ
hehe i see that now :)
2017-08-04 21622, 2017
13:44 PM
samj1912
its more of a customize your media library how you need it tagger
2017-08-04 21655, 2017
13:46 PM
Slurpee joined the channel
2017-08-04 21618, 2017
13:54 PM
x3YTjJV6asPhskrZ
hey could i use python-musicbrainz3 for the lookup?
2017-08-04 21630, 2017
13:54 PM
x3YTjJV6asPhskrZ
or well version 2
2017-08-04 21625, 2017
13:55 PM
x3YTjJV6asPhskrZ
oh wait its deprecated
2017-08-04 21615, 2017
14:03 PM
x3YTjJV6asPhskrZ
hey samj1912 can i use python-musicbrainzngs?
2017-08-04 21639, 2017
14:03 PM
samj1912
yup
2017-08-04 21658, 2017
14:03 PM
x3YTjJV6asPhskrZ
noice
2017-08-04 21658, 2017
14:04 PM
x3YTjJV6asPhskrZ
okay do you have a release group that has more than one release type/
2017-08-04 21617, 2017
14:05 PM
samj1912
x3YTjJV6asPhskrZ: I posted the list above
2017-08-04 21632, 2017
14:05 PM
x3YTjJV6asPhskrZ
but theyre all just showing album
2017-08-04 21643, 2017
14:05 PM
samj1912
you need to add relations
2017-08-04 21654, 2017
14:05 PM
x3YTjJV6asPhskrZ
oh?
2017-08-04 21612, 2017
14:06 PM
samj1912
inc=releases
2017-08-04 21623, 2017
14:07 PM
samj1912
2017-08-04 21624, 2017
14:07 PM
x3YTjJV6asPhskrZ
im not sure im following
2017-08-04 21643, 2017
14:07 PM
samj1912
x3YTjJV6asPhskrZ: click the link above for example
2017-08-04 21659, 2017
14:07 PM
samj1912
2017-08-04 21629, 2017
14:09 PM
x3YTjJV6asPhskrZ
okay
2017-08-04 21638, 2017
14:10 PM
agentsim joined the channel
2017-08-04 21625, 2017
14:14 PM
x3YTjJV6asPhskrZ
okay so i have to extract the release type from each release in the release group?
2017-08-04 21651, 2017
14:14 PM
samj1912
from the medium of each releases from the releases in the release group
2017-08-04 21653, 2017
14:17 PM
x3YTjJV6asPhskrZ
remeber im using the python api
2017-08-04 21604, 2017
14:18 PM
x3YTjJV6asPhskrZ
how would i do the include releases?
2017-08-04 21602, 2017
14:24 PM
Rotab joined the channel
2017-08-04 21636, 2017
14:26 PM
ohrstrom joined the channel
2017-08-04 21625, 2017
14:29 PM
MajorLurker has quit
2017-08-04 21619, 2017
14:35 PM
saifulbkhan has quit
2017-08-04 21653, 2017
14:35 PM
saifulbkhan joined the channel
2017-08-04 21608, 2017
14:36 PM
saifulbkhan has quit
2017-08-04 21628, 2017
14:36 PM
ohrstrom has quit
2017-08-04 21637, 2017
14:41 PM
x3YTjJV6asPhskrZ
hey samj1912 where do i get this dict? config.setting["release_type_scores"]
2017-08-04 21648, 2017
14:49 PM
drsaunders joined the channel
2017-08-04 21622, 2017
15:00 PM
arbenina_ joined the channel
2017-08-04 21621, 2017
15:04 PM
x3YTjJV6asPhskrZ
*sigh*
2017-08-04 21635, 2017
15:05 PM
samj1912
x3YTjJV6asPhskrZ: its dynamically generated from you picard config
2017-08-04 21600, 2017
15:06 PM
x3YTjJV6asPhskrZ
so how do i call that from the test script
2017-08-04 21610, 2017
15:06 PM
samj1912
do you want the default values?
2017-08-04 21615, 2017
15:06 PM
x3YTjJV6asPhskrZ
yes please
2017-08-04 21659, 2017
15:06 PM
samj1912
[('Single', 0.5), ('Compilation', 0.5), ('Spokenword', 0.5), ('Remix', 0.5), ('Mixtape/Street', 0.5), ('Album', 0.5), ('Live', 0.5), ('Demo', 0.5), ('Audiobook', 0.5), ('Other', 0.5), ('Interview', 0.5), ('DJ-mix', 0.5), ('Broadcast', 0.5), ('Soundtrack', 0.5), ('EP', 0.5)]
2017-08-04 21622, 2017
15:07 PM
samj1912
basically for singles you would want singles at 1
2017-08-04 21626, 2017
15:07 PM
samj1912
and everything else at 0
2017-08-04 21657, 2017
15:07 PM
x3YTjJV6asPhskrZ
and what if i want albums without compilations (since compilations have albums as a primary type)
2017-08-04 21612, 2017
15:08 PM
samj1912
just make albums 1, compilations 0
2017-08-04 21625, 2017
15:08 PM
x3YTjJV6asPhskrZ
and thats not working, hence the bug
2017-08-04 21647, 2017
15:08 PM
samj1912
not working as in?
2017-08-04 21600, 2017
15:09 PM
x3YTjJV6asPhskrZ
im still getting compilations
2017-08-04 21655, 2017
15:09 PM
samj1912
2017-08-04 21630, 2017
15:10 PM
x3YTjJV6asPhskrZ
which im looking at as we speak
2017-08-04 21608, 2017
15:11 PM
x3YTjJV6asPhskrZ
i think it should take the secondary types into account
2017-08-04 21621, 2017
15:11 PM
x3YTjJV6asPhskrZ
and the role of the primary type should be minimized
2017-08-04 21618, 2017
15:13 PM
samj1912
how do you want to do that?
2017-08-04 21630, 2017
15:13 PM
samj1912
secondary-types might be absent in a lot of cases
2017-08-04 21655, 2017
15:13 PM
x3YTjJV6asPhskrZ
how bout we add primary type and secondary types to a single list
2017-08-04 21604, 2017
15:14 PM
x3YTjJV6asPhskrZ
and then determine the score based on that list
2017-08-04 21624, 2017
15:14 PM
x3YTjJV6asPhskrZ
gimmie a sec
2017-08-04 21649, 2017
15:14 PM
x3YTjJV6asPhskrZ
do you have a release id with both primary and secondary types set?
2017-08-04 21638, 2017
15:15 PM
reosarevok
2017-08-04 21658, 2017
15:16 PM
samj1912
2017-08-04 21648, 2017
15:17 PM
drsaunders has quit
2017-08-04 21634, 2017
15:18 PM
x3YTjJV6asPhskrZ
this is a release right, not a release group
2017-08-04 21644, 2017
15:18 PM
samj1912
yes
2017-08-04 21626, 2017
15:19 PM
x3YTjJV6asPhskrZ has quit
2017-08-04 21637, 2017
15:20 PM
x3YTjJV6asPhskrZ joined the channel
2017-08-04 21649, 2017
15:21 PM
x3YTjJV6asPhskrZ
back
2017-08-04 21651, 2017
15:21 PM
x3YTjJV6asPhskrZ
gimmie a sec
2017-08-04 21638, 2017
15:22 PM
arbenina_ has quit
2017-08-04 21643, 2017
15:22 PM
github joined the channel
2017-08-04 21643, 2017
15:22 PM
github
[critiquebrainz] gentlecat opened pull request #141: Upgrade requirements (master...req-update)
https://git.io/v7VRM
2017-08-04 21643, 2017
15:22 PM
github has left the channel
2017-08-04 21619, 2017
15:25 PM
x3YTjJV6asPhskrZ
okay so since this is a release i cant do the release-group include
2017-08-04 21650, 2017
15:25 PM
x3YTjJV6asPhskrZ
which means that this algorithm only looks at release groups when determining the weights
2017-08-04 21617, 2017
15:26 PM
samj1912
x3YTjJV6asPhskrZ: huh?
2017-08-04 21648, 2017
15:26 PM
x3YTjJV6asPhskrZ
the weighting algorithm in the metadata.py only looks on release groups, not releases
2017-08-04 21648, 2017
15:26 PM
samj1912
default picard query for releases include release-groups
2017-08-04 21610, 2017
15:27 PM
samj1912
we query releases, which have an inc=release-groups with them
2017-08-04 21615, 2017
15:27 PM
samj1912
for every query
2017-08-04 21650, 2017
15:27 PM
samj1912
2017-08-04 21611, 2017
15:29 PM
x3YTjJV6asPhskrZ
so every release has a release group?
2017-08-04 21623, 2017
15:29 PM
samj1912
yes
2017-08-04 21641, 2017
15:31 PM
x3YTjJV6asPhskrZ
maybe we should look at the type rather than the primary type
2017-08-04 21647, 2017
15:31 PM
x3YTjJV6asPhskrZ
why are they both there anyways?
2017-08-04 21647, 2017
15:32 PM
x3YTjJV6asPhskrZ
i think this can be solved easily by changing the primary type to type!
2017-08-04 21601, 2017
15:33 PM
x3YTjJV6asPhskrZ
i want to test it. how do i compile the picard source code?
2017-08-04 21616, 2017
15:33 PM
samj1912
x3YTjJV6asPhskrZ: 1 little problem
2017-08-04 21620, 2017
15:33 PM
x3YTjJV6asPhskrZ
hmm?
2017-08-04 21623, 2017
15:33 PM
samj1912
I think you are looking at the xml output
2017-08-04 21625, 2017
15:33 PM
samj1912
2017-08-04 21636, 2017
15:33 PM
samj1912
json output only has primary-type and seconary-type
2017-08-04 21639, 2017
15:33 PM
samj1912
no "type"
2017-08-04 21644, 2017
15:33 PM
x3YTjJV6asPhskrZ
ahh okay
2017-08-04 21658, 2017
15:33 PM
samj1912
bitmap: ^^
2017-08-04 21604, 2017
15:34 PM
samj1912
any reason for this?
2017-08-04 21613, 2017
15:34 PM
samj1912
and can we get "type" included in the output?
2017-08-04 21633, 2017
15:34 PM
samj1912
x3YTjJV6asPhskrZ: which picard version are you on?
2017-08-04 21639, 2017
15:34 PM
x3YTjJV6asPhskrZ
1.4.0
2017-08-04 21645, 2017
15:34 PM
x3YTjJV6asPhskrZ
okay so when picard itself polls for the release, which format does it use? json or xml?
2017-08-04 21655, 2017
15:34 PM
samj1912
2.x uses json
2017-08-04 21658, 2017
15:34 PM
samj1912
1.4.x uses xml
2017-08-04 21610, 2017
15:35 PM
x3YTjJV6asPhskrZ
okay
2017-08-04 21630, 2017
15:35 PM
samj1912
2017-08-04 21630, 2017
15:35 PM
x3YTjJV6asPhskrZ
we could solve this by including a check for both type and primary type
2017-08-04 21654, 2017
15:35 PM
samj1912
ill fix the above for json output
2017-08-04 21600, 2017
15:36 PM
samj1912
but it should be fixed for the xml one
2017-08-04 21623, 2017
15:36 PM
x3YTjJV6asPhskrZ
okay
2017-08-04 21635, 2017
15:36 PM
x3YTjJV6asPhskrZ
so which version is on the main github page?
2017-08-04 21644, 2017
15:36 PM
x3YTjJV6asPhskrZ
1.4 or 2.0
2017-08-04 21654, 2017
15:36 PM
samj1912
the master is at 2.0
2017-08-04 21601, 2017
15:37 PM
x3YTjJV6asPhskrZ
ohh
2017-08-04 21605, 2017
15:37 PM
samj1912
the current stable is 1.4.2
2017-08-04 21630, 2017
15:37 PM
x3YTjJV6asPhskrZ
i cant make a pull request for the current stable can i? only for the dev?
2017-08-04 21646, 2017
15:37 PM
samj1912
you can
2017-08-04 21653, 2017
15:37 PM
samj1912
its available at the 1.4.x branch
2017-08-04 21605, 2017
15:38 PM
x3YTjJV6asPhskrZ
ahh okay
2017-08-04 21627, 2017
15:38 PM
ohrstrom joined the channel
2017-08-04 21643, 2017
15:38 PM
x3YTjJV6asPhskrZ
so to clarify, xml has type while json only has primary-type
2017-08-04 21601, 2017
15:39 PM
x3YTjJV6asPhskrZ
and 2.0 uses json while 1.4 uses xml
2017-08-04 21614, 2017
15:39 PM
samj1912
yes
2017-08-04 21620, 2017
15:39 PM
x3YTjJV6asPhskrZ
okay
2017-08-04 21601, 2017
15:40 PM
x3YTjJV6asPhskrZ
then its a simple matter of checking for all three variables, primary type secondary type and type, and then creating a merge request for both branches once they check out
2017-08-04 21615, 2017
15:40 PM
x3YTjJV6asPhskrZ
now its just to find the right order
2017-08-04 21649, 2017
15:40 PM
samj1912
I want to know how the type, secondary type and primary type is populated though
2017-08-04 21652, 2017
15:40 PM
samj1912
reosarevok: any idea?
2017-08-04 21602, 2017
15:41 PM
samj1912
bitmap: yvanzo ^^
2017-08-04 21622, 2017
15:41 PM
CallerNo6
'type' is derived from primary and secondary. it's a legacy field.
