CallerNo6 wonders how much longer he can resist learning "just enough" perl
2017-08-04 21638, 2017
x3YTjJV6asPhskrZ
okay so ill go in the order of availability, secondary, then primary, then type, then if all else fails, set the score to 0
2017-08-04 21611, 2017
CallerNo6
if there's no primary/secondary, then there will be not 'type'
2017-08-04 21641, 2017
CallerNo6
er, "no 'type' "
2017-08-04 21649, 2017
x3YTjJV6asPhskrZ
okay
2017-08-04 21604, 2017
x3YTjJV6asPhskrZ
so i dont need the type check at all right?
2017-08-04 21623, 2017
x3YTjJV6asPhskrZ
okay if only the primary type is available, do you want me to set it to the score of the primary type? or leave it with the default # something to do with other?)
2017-08-04 21623, 2017
x3YTjJV6asPhskrZ
guys?
2017-08-04 21609, 2017
x3YTjJV6asPhskrZ
samj1912?
2017-08-04 21654, 2017
reosarevok
Actually, fuck. I have meat in the oven. Guess no game today.
2017-08-04 21609, 2017
reosarevok
At least I remembered before leaving...
2017-08-04 21609, 2017
x3YTjJV6asPhskrZ
okay ur back
2017-08-04 21610, 2017
reosarevok
You don't need the type check at all
2017-08-04 21617, 2017
x3YTjJV6asPhskrZ
yeah
2017-08-04 21643, 2017
x3YTjJV6asPhskrZ
if there is only a primary type, should i leave the default algo? or just set the score to the primary type?
2017-08-04 21644, 2017
reosarevok
If only primary type is available then use that - that means it's just an album/EP/single with no other categorisation
2017-08-04 21657, 2017
x3YTjJV6asPhskrZ
okay
2017-08-04 21614, 2017
x3YTjJV6asPhskrZ
well i think the default algo draws the settings from other but im not sure
2017-08-04 21628, 2017
reosarevok doesn't know Picard's code, just saying what I'd expect :)
2017-08-04 21638, 2017
x3YTjJV6asPhskrZ
hehe
2017-08-04 21640, 2017
reosarevok
If it has both a primary and many secondary types, it's a bit trickier
2017-08-04 21650, 2017
x3YTjJV6asPhskrZ
i already worked out that issue
2017-08-04 21658, 2017
reosarevok
I mean, I'd expect a soundtrack + compilation to show both looking for soundtracks and looking for compilations
2017-08-04 21612, 2017
x3YTjJV6asPhskrZ
wait huh?
2017-08-04 21615, 2017
reosarevok
But at the same time, not to show at all if you have one of the two set to 0
2017-08-04 21643, 2017
x3YTjJV6asPhskrZ
if the primary type was album and the secondary was compilation
2017-08-04 21646, 2017
reosarevok
I think actually my first check would be "does this match any of the types set to 0? if so, discard"
2017-08-04 21658, 2017
reosarevok
Secondary can be many types, so you can have Album + Compilation + Soundtrack
2017-08-04 21610, 2017
x3YTjJV6asPhskrZ
yeah hold on a sec
2017-08-04 21629, 2017
x3YTjJV6asPhskrZ
if the primary type was album and the secondary was alot of other stuff, and you set album to 0, wouldnt you care about the other stuff?
2017-08-04 21614, 2017
reosarevok
I guess it depends on how you understand album. Album is not supposed to mean the same as studio album, but I guess some people might try to set album to 0 to say "no studio albums"
2017-08-04 21629, 2017
x3YTjJV6asPhskrZ
yeah
2017-08-04 21609, 2017
x3YTjJV6asPhskrZ
right now i dont include the primary type at all in the calculations if secondaries are available
2017-08-04 21612, 2017
x3YTjJV6asPhskrZ
but i guess i have to
2017-08-04 21634, 2017
reosarevok
That might be fair, in most cases. Most secondaries usually apply only to albums anyway
2017-08-04 21641, 2017
reosarevok
(main exception probably "remix")
2017-08-04 21606, 2017
x3YTjJV6asPhskrZ
screw it, im incorporating the primary into the algo
2017-08-04 21638, 2017
x3YTjJV6asPhskrZ
but if you disable albums, and enable compilations for example, any compilation found will always be 0.5
2017-08-04 21645, 2017
arbenina_ joined the channel
2017-08-04 21659, 2017
x3YTjJV6asPhskrZ
okay can i get a release with alot of types?
2017-08-04 21659, 2017
x3YTjJV6asPhskrZ
hey samj1912
2017-08-04 21606, 2017
x3YTjJV6asPhskrZ
im almost done
2017-08-04 21615, 2017
x3YTjJV6asPhskrZ
i just need your opinion on something
2017-08-04 21657, 2017
ohrstrom has quit
2017-08-04 21639, 2017
CallerNo6
reosarevok, so should there be a "studio" secondary, so that the concept can be expressed in a way other than 'album + null'?
2017-08-04 21651, 2017
reosarevok
Some people have asked for that. I'm not sure
2017-08-04 21601, 2017
reosarevok
Isn't that just "the absence of 'live'"?
2017-08-04 21649, 2017
CallerNo6
well, there's a difference between [none] and null
2017-08-04 21638, 2017
CallerNo6
er, I mean, between [no barcode] and null, for instance. isn't it the same situation?
2017-08-04 21611, 2017
x3YTjJV6asPhskrZ
hey guys, if there is no type do you want me to set the score to that of other or just 0?
2017-08-04 21621, 2017
reosarevok
Possibly. It's just that I can't honestly expect editors to set "Studio" to 90% of the stuff by hand
2017-08-04 21629, 2017
CallerNo6
fair point
2017-08-04 21631, 2017
reosarevok
(even just to all the stuff they newly add)
2017-08-04 21648, 2017
x3YTjJV6asPhskrZ
guys?
2017-08-04 21601, 2017
reosarevok
x3YTjJV6asPhskrZ: if it's no type at all it should probably ignore this algo completely, but dunno
2017-08-04 21617, 2017
x3YTjJV6asPhskrZ
okay, ill set it to 0
2017-08-04 21621, 2017
x3YTjJV6asPhskrZ
and one last thing
2017-08-04 21640, 2017
CallerNo6
then picard could derive "studio album" from "album + null" and give that as an explicit option maybe?
2017-08-04 21600, 2017
x3YTjJV6asPhskrZ
if any of the matching types are set to 0, should i discard or factor the 0 into the algo?
2017-08-04 21614, 2017
reosarevok
CallerNo6: possibly?
2017-08-04 21634, 2017
CallerNo6 doesn't know why he's bugging reo with this question
2017-08-04 21649, 2017
reosarevok
x3YTjJV6asPhskrZ: not sure tbh. *I* would discard, but this might be something to ask from the Picard devs (or if you submit a PR, in the PR)
2017-08-04 21610, 2017
x3YTjJV6asPhskrZ
ill add it to the PR
2017-08-04 21617, 2017
x3YTjJV6asPhskrZ
how do i create a PR anyway?
2017-08-04 21622, 2017
x3YTjJV6asPhskrZ
it is my first time xD
2017-08-04 21652, 2017
reosarevok isn't sure how the Picard team does, so I guess that's a question for samj1912
samj1912, one final thing. if a found type is set to 0, should the whole thing be set to 0 and discarded or should that 0 be run through the algorithm?
2017-08-04 21604, 2017
samj1912
0 and run through
2017-08-04 21616, 2017
x3YTjJV6asPhskrZ
okay
2017-08-04 21650, 2017
x3YTjJV6asPhskrZ
and if no type is found, use the other type or set to zero?
2017-08-04 21617, 2017
x3YTjJV6asPhskrZ
samj1912, ?
2017-08-04 21637, 2017
samj1912
Other
2017-08-04 21643, 2017
x3YTjJV6asPhskrZ
okay
2017-08-04 21649, 2017
samj1912
Whatever value that has
2017-08-04 21655, 2017
x3YTjJV6asPhskrZ
yeah
2017-08-04 21659, 2017
samj1912
Otherwise set it to 50
2017-08-04 21606, 2017
x3YTjJV6asPhskrZ
yeah :)
2017-08-04 21608, 2017
x3YTjJV6asPhskrZ
im about ready to push now
2017-08-04 21623, 2017
x3YTjJV6asPhskrZ
i used the pull request message as the commit message. is that okay or should i change it?
