so far so good! im barely seeing any compilations with my config!
2017-08-04 21601, 2017
x3YTjJV6asPhskrZ
like BARELY any xD
2017-08-04 21646, 2017
samj1912
x3YTjJV6asPhskrZ: using the master?
2017-08-04 21658, 2017
x3YTjJV6asPhskrZ
yeah, using my branch
2017-08-04 21621, 2017
x3YTjJV6asPhskrZ
and after i set it up to ignore compilations and search for albums
2017-08-04 21634, 2017
bitmap
ruaok: it arrived yesterday, thanks!
2017-08-04 21601, 2017
samj1912
x3YTjJV6asPhskrZ: suggested some changes
2017-08-04 21608, 2017
x3YTjJV6asPhskrZ
oh?
2017-08-04 21620, 2017
samj1912
see the PR for review
2017-08-04 21650, 2017
x3YTjJV6asPhskrZ
but thats what you had before
2017-08-04 21653, 2017
x3YTjJV6asPhskrZ
and it didnt work
2017-08-04 21629, 2017
samj1912
its different
2017-08-04 21649, 2017
x3YTjJV6asPhskrZ
no it isnt thats the exact thing that was there before
2017-08-04 21612, 2017
x3YTjJV6asPhskrZ
what does this even do?
2017-08-04 21634, 2017
samj1912
x3YTjJV6asPhskrZ: re did the comment
2017-08-04 21636, 2017
samj1912
its different
2017-08-04 21648, 2017
x3YTjJV6asPhskrZ
whats the difference between getting the direct score and that thing you did with the other category?
2017-08-04 21659, 2017
samj1912
it provides a default value in case the given type does not exist in type_scores
2017-08-04 21607, 2017
samj1912
which your current code will fail at
2017-08-04 21621, 2017
x3YTjJV6asPhskrZ
oh
2017-08-04 21624, 2017
samj1912
and also it makes a default score of 0.0 in case primary release type isnt found
2017-08-04 21629, 2017
x3YTjJV6asPhskrZ
well why didnt you say so
2017-08-04 21637, 2017
x3YTjJV6asPhskrZ
but you said to set it to other
2017-08-04 21639, 2017
x3YTjJV6asPhskrZ
which i did
2017-08-04 21605, 2017
samj1912
what I wanted you to do is what I suggested in the review
2017-08-04 21619, 2017
samj1912
you interpreted it some way else
2017-08-04 21631, 2017
samj1912
which does not make sense
2017-08-04 21638, 2017
x3YTjJV6asPhskrZ
<x3YTjJV6asPhskrZ> and if no type is found, use the other type or set to zero?
2017-08-04 21638, 2017
x3YTjJV6asPhskrZ
<x3YTjJV6asPhskrZ> samj1912, ?
2017-08-04 21638, 2017
x3YTjJV6asPhskrZ
<samj1912> Other
2017-08-04 21638, 2017
x3YTjJV6asPhskrZ
<x3YTjJV6asPhskrZ> okay
2017-08-04 21638, 2017
x3YTjJV6asPhskrZ
<samj1912> Whatever value that has
2017-08-04 21657, 2017
x3YTjJV6asPhskrZ
which i did here
2017-08-04 21658, 2017
x3YTjJV6asPhskrZ
+ elif 'Other' in type_scores:
2017-08-04 21658, 2017
x3YTjJV6asPhskrZ
+ score = type_scores.get('Other')
2017-08-04 21658, 2017
x3YTjJV6asPhskrZ
else:
2017-08-04 21658, 2017
x3YTjJV6asPhskrZ
- score = 0.0
2017-08-04 21614, 2017
samj1912
I thought if you didnt find it in type_scores
2017-08-04 21622, 2017
x3YTjJV6asPhskrZ
oh
2017-08-04 21630, 2017
samj1912
anyway, just change as suggested
2017-08-04 21632, 2017
x3YTjJV6asPhskrZ
ill make the changes
2017-08-04 21634, 2017
samj1912
it should work the same
2017-08-04 21639, 2017
samj1912
if not better for you
2017-08-04 21657, 2017
x3YTjJV6asPhskrZ has quit
2017-08-04 21608, 2017
saifulbkhan joined the channel
2017-08-04 21628, 2017
UmkaDK has quit
2017-08-04 21654, 2017
ruaok
bitmap: thank FSM!
2017-08-04 21601, 2017
bitmap
🙏
2017-08-04 21603, 2017
Quesito
ruaok arrived, gracias senior!
2017-08-04 21646, 2017
reosarevok
hah
2017-08-04 21658, 2017
reosarevok
A livenation employee at support asking for help with MB
2017-08-04 21601, 2017
reosarevok
for setlist.fm
2017-08-04 21605, 2017
Muz has quit
2017-08-04 21616, 2017
reosarevok
ruaok, did they ever start supporting? :p
2017-08-04 21649, 2017
Muz joined the channel
2017-08-04 21653, 2017
reosarevok sighs. It's not even an MB problem, but their system sucking
2017-08-04 21633, 2017
reosarevok answers for now
2017-08-04 21626, 2017
reosarevok forwards original mail to Quesito too just in case
2017-08-04 21639, 2017
ZarkBit has quit
2017-08-04 21602, 2017
Quesito
it's like a hot friday night of support emails....(i'm dealing with a few this evening too...)
2017-08-04 21609, 2017
reosarevok
ruaok: mine arrived too FWIW! :)
2017-08-04 21609, 2017
ZarkBit joined the channel
2017-08-04 21634, 2017
ZarkBit_ joined the channel
2017-08-04 21625, 2017
ZarkBit has quit
2017-08-04 21631, 2017
ZarkBit_ is now known as ZarkBit
2017-08-04 21646, 2017
UmkaDK joined the channel
2017-08-04 21633, 2017
ZarkBit has quit
2017-08-04 21647, 2017
ZarkBit joined the channel
2017-08-04 21641, 2017
arbenina_ has quit
2017-08-04 21603, 2017
ohrstrom joined the channel
2017-08-04 21630, 2017
ruaok
reosarevok: Ticketmaster == livenation, so yes.
2017-08-04 21606, 2017
D4RK-PH0ENiX has quit
2017-08-04 21635, 2017
D4RK-PH0ENiX joined the channel
2017-08-04 21656, 2017
ohrstrom has quit
2017-08-04 21651, 2017
ohrstrom joined the channel
2017-08-04 21619, 2017
ohrstrom has quit
2017-08-04 21616, 2017
reosarevok
Ok then
2017-08-04 21658, 2017
x3YTjJV6asPhskrZ joined the channel
2017-08-04 21628, 2017
x3YTjJV6asPhskrZ
back, after a huge thunderstorm and subsequent internet outage
2017-08-04 21640, 2017
x3YTjJV6asPhskrZ
so samj1912, how do i do the pull request?
2017-08-04 21643, 2017
ohrstrom joined the channel
2017-08-04 21647, 2017
x3YTjJV6asPhskrZ
or...anyone?
2017-08-04 21653, 2017
x3YTjJV6asPhskrZ
i just create a new one right?
2017-08-04 21629, 2017
x3YTjJV6asPhskrZ
is it cool if i override the old pull request with the changes?
2017-08-04 21612, 2017
SothoTalker_
it should work fine
2017-08-04 21619, 2017
x3YTjJV6asPhskrZ
okay cool
2017-08-04 21617, 2017
ohrstrom has quit
2017-08-04 21650, 2017
x3YTjJV6asPhskrZ
changes made and commit overridden, please review
2017-08-04 21651, 2017
arbenina_ joined the channel
2017-08-04 21632, 2017
UmkaDK has quit
2017-08-04 21632, 2017
arbenina_ has quit
2017-08-04 21643, 2017
x3YTjJV6asPhskrZ
any word?
2017-08-04 21634, 2017
SothoTalker_
it's night for most developers, so i would not expect any reviews before tomorrow
2017-08-04 21652, 2017
github joined the channel
2017-08-04 21652, 2017
github
[critiquebrainz] ferbncode opened pull request #142: Fetch credentials for setting up redis from test_config (master...fetch-from-config) https://git.io/v7wYj
