0:04 AM
SaidS joined the channel
2017-11-30 33435, 2017
0:07 AM
Said has quit
2017-11-30 33450, 2017
0:10 AM
UmkaDK has quit
2017-11-30 33441, 2017
0:15 AM
kepstin has quit
2017-11-30 33419, 2017
0:43 AM
d4rkie joined the channel
2017-11-30 33427, 2017
0:44 AM
D4RK-PH0ENiX has quit
2017-11-30 33428, 2017
0:52 AM
SaidS has quit
2017-11-30 33422, 2017
0:57 AM
naught101 has quit
2017-11-30 33419, 2017
1:04 AM
SaidS joined the channel
2017-11-30 33406, 2017
1:23 AM
SaidS has quit
2017-11-30 33430, 2017
1:23 AM
SaidS joined the channel
2017-11-30 33450, 2017
1:26 AM
D4RK-PH0ENiX joined the channel
2017-11-30 33459, 2017
1:29 AM
d4rkie has quit
2017-11-30 33401, 2017
2:00 AM
SaidS has quit
2017-11-30 33416, 2017
2:04 AM
D4RK-PH0ENiX has quit
2017-11-30 33454, 2017
2:04 AM
D4RK-PH0ENiX joined the channel
2017-11-30 33441, 2017
2:19 AM
SaidS joined the channel
2017-11-30 33402, 2017
2:20 AM
Gazooo has quit
2017-11-30 33405, 2017
2:20 AM
naught101 joined the channel
2017-11-30 33455, 2017
2:20 AM
Gazooo joined the channel
2017-11-30 33440, 2017
2:42 AM
Major_Lurker joined the channel
2017-11-30 33447, 2017
2:57 AM
heyoni has quit
2017-11-30 33429, 2017
2:58 AM
Leftmost
LordSputnik, I looked into the </script> thing and I don't have a good path forward yet.
2017-11-30 33409, 2017
3:03 AM
Leftmost
I feel like we probably need the JSON to not be directly embedded in a script tag as it is now.
2017-11-30 33445, 2017
3:08 AM
SaidS has quit
2017-11-30 33408, 2017
3:23 AM
SaidS joined the channel
2017-11-30 33441, 2017
3:33 AM
naught101 has quit
2017-11-30 33422, 2017
3:34 AM
Leftmost
2017-11-30 33406, 2017
3:38 AM
Slurpee has quit
2017-11-30 33425, 2017
4:01 AM
naiveaiguy joined the channel
2017-11-30 33428, 2017
4:11 AM
arthelon[m]
Leftmost: I made a PR yesterday that escapes prop strings
2017-11-30 33446, 2017
4:11 AM
Leftmost
Ahh, hmm. I'll take a look.
2017-11-30 33402, 2017
4:12 AM
arthelon[m]
It's a bit more boilerplate for now but once we replace Jade templates with native string ones we can perform all the validation/escaping logic in one file.
2017-11-30 33437, 2017
4:12 AM
arthelon[m]
can't do that at the moment bc injecting JS libraries into Jade is too much work.
2017-11-30 33405, 2017
4:16 AM
Leftmost
Looks like Travis is failing, but there's no log. D:
2017-11-30 33442, 2017
4:21 AM
arthelon[m]
try signing in if you haven't already. The logs appeared once I was authenticated.
2017-11-30 33404, 2017
4:22 AM
Leftmost
Odd.
2017-11-30 33414, 2017
4:22 AM
Leftmost
Nope, I'm already signed in.
2017-11-30 33419, 2017
4:22 AM
arthelon[m]
The node 8 build failed bc of a faulty apt-get install
2017-11-30 33441, 2017
4:23 AM
Leftmost
Now it's showing. I think their site might just be having issues.
2017-11-30 33452, 2017
4:23 AM
arthelon[m]
urgh, I keep forgetting to run the linter
2017-11-30 33405, 2017
4:24 AM
arthelon[m]
this is why we need pre-commit hooks :P
2017-11-30 33413, 2017
4:24 AM
arthelon[m]
hope someone claims that GCI task soon
2017-11-30 33433, 2017
4:24 AM
arthelon[m]
I'll fix the build in a bit
2017-11-30 33410, 2017
4:25 AM
Leftmost
Cool, thanks.
2017-11-30 33419, 2017
4:25 AM
Leftmost
Ping me when you do. I'll test and merge.
2017-11-30 33436, 2017
4:28 AM
naiveaiguy has quit
2017-11-30 33421, 2017
4:39 AM
arthelon[m]
Leftmost: ping
2017-11-30 33436, 2017
4:39 AM
arthelon[m]
travis-ci build might take a while but lint errors should be resolved
2017-11-30 33453, 2017
4:39 AM
naught101 joined the channel
2017-11-30 33441, 2017
4:45 AM
Leftmost
Pulled and testing now.
2017-11-30 33428, 2017
4:47 AM
naiveaiguy joined the channel
2017-11-30 33453, 2017
4:53 AM
naiveaiguy has quit
2017-11-30 33426, 2017
5:10 AM
travis-ci joined the channel
2017-11-30 33427, 2017
5:10 AM
travis-ci
2017-11-30 33427, 2017
5:10 AM
travis-ci has left the channel
2017-11-30 33407, 2017
5:12 AM
Leftmost
arthelon[m], marged it.
2017-11-30 33425, 2017
5:12 AM
Leftmost
(Or smerged, if you prefer.)
2017-11-30 33441, 2017
5:12 AM
Leftmost
Thanks for the fix.
2017-11-30 33436, 2017
5:18 AM
naught101 has quit
2017-11-30 33420, 2017
5:33 AM
MusicbrainzB0T joined the channel
2017-11-30 33417, 2017
5:35 AM
gcilou joined the channel
2017-11-30 33423, 2017
5:35 AM
MusicbrainzB0T2 has quit
2017-11-30 33424, 2017
5:37 AM
naiveaiguy joined the channel
2017-11-30 33435, 2017
6:23 AM
SaidS has quit
2017-11-30 33459, 2017
6:27 AM
SaidS joined the channel
2017-11-30 33425, 2017
6:33 AM
MusicbrainzB0T1 joined the channel
2017-11-30 33458, 2017
6:33 AM
MusicbrainzB0T has quit
2017-11-30 33427, 2017
6:52 AM
SaidS has quit
2017-11-30 33402, 2017
6:59 AM
naiveaiguy
iliekcomputers: All 4 of the example code of API usage are done. Need some feedback regarding details to add into the documentation, but going to try on my own right now.
2017-11-30 33410, 2017
7:11 AM
SaidS joined the channel
2017-11-30 33423, 2017
7:14 AM
arthelon[m]
:D
2017-11-30 33446, 2017
7:20 AM
SaidS has quit
2017-11-30 33449, 2017
7:22 AM
SaidS joined the channel
2017-11-30 33407, 2017
7:45 AM
gcilou has quit
2017-11-30 33440, 2017
7:54 AM
UmkaDK joined the channel
2017-11-30 33448, 2017
8:04 AM
naiveaiguy
Submitted first task for review!
2017-11-30 33410, 2017
8:11 AM
SaidS has quit
2017-11-30 33442, 2017
8:13 AM
SaidS joined the channel
2017-11-30 33426, 2017
8:20 AM
Protab joined the channel
2017-11-30 33426, 2017
8:20 AM
Rotab has quit
2017-11-30 33433, 2017
8:20 AM
CatQuest
well that's annoying
2017-11-30 33439, 2017
8:20 AM
CatQuest
2017-11-30 33445, 2017
8:20 AM
CatQuest
but abandons it :/
2017-11-30 33444, 2017
8:25 AM
LordSputnik
Leftmost: I think arthelon[m] has a PR open with a fix that could use review :)
2017-11-30 33459, 2017
8:25 AM
Leftmost
LordSputnik, already merged it. :D
2017-11-30 33400, 2017
8:26 AM
LordSputnik
Oh you saw that
2017-11-30 33403, 2017
8:26 AM
LordSputnik
Haha
2017-11-30 33447, 2017
8:26 AM
Leftmost
I'd be lying if I said I actually understood how it works. I looked at the JSON and I don't know what changed. But it works.
2017-11-30 33430, 2017
8:28 AM
LordSputnik
2017-11-30 33457, 2017
8:28 AM
Leftmost
I wasn't sure about putting out some sort of announcement.
2017-11-30 33410, 2017
8:29 AM
CatQuest
are we talking about search here? cause i hope so
2017-11-30 33450, 2017
8:29 AM
Leftmost
What about search?
2017-11-30 33458, 2017
8:29 AM
CatQuest
nomatter what I search for I get the same 10 results basically
2017-11-30 33400, 2017
8:31 AM
CatQuest
or wery unrelated ones
2017-11-30 33406, 2017
8:31 AM
Leftmost
Hmm. Possibly an issue with the index.
2017-11-30 33419, 2017
8:31 AM
CatQuest
2017-11-30 33408, 2017
8:32 AM
CatQuest
som students have been saying that the search is unreliable in their feedback too
2017-11-30 33437, 2017
8:35 AM
LordSputnik
Leftmost: I tried regenerating the index, it's borked
2017-11-30 33442, 2017
8:35 AM
LordSputnik
Not sure why though
2017-11-30 33459, 2017
8:35 AM
Leftmost
LordSputnik, I wonder if the index definition is messed up somehow. I'm checking on that now.
2017-11-30 33406, 2017
8:36 AM
LordSputnik
Thanks :)
2017-11-30 33439, 2017
8:36 AM
LordSputnik
Might be good to check the commits to search too to try to identify when I broke it ;)
2017-11-30 33408, 2017
8:37 AM
LordSputnik
In other news, 20 completed BB tasks! Good work arthelon[m] and CatQuest
2017-11-30 33441, 2017
8:37 AM
CatQuest
heh this is the tird person saying that the publication to be created before the edition thing is confusing :G:
2017-11-30 33452, 2017
8:37 AM
CatQuest
LordSputnik: I havent doen much, it was mostly art
2017-11-30 33403, 2017
8:38 AM
CatQuest
I'm looking now aamof
2017-11-30 33410, 2017
8:38 AM
naiveaiguy
CatQuest: how can you see what tasks are claimed/completed?
2017-11-30 33435, 2017
8:38 AM
CatQuest
naiveaiguy: by being a mentor ;)
2017-11-30 33442, 2017
8:38 AM
naiveaiguy
oh lol
2017-11-30 33431, 2017
8:39 AM
Leftmost
CatQuest, because it is. :P
2017-11-30 33409, 2017
8:40 AM
CatQuest
2017-11-30 33426, 2017
8:40 AM
LordSputnik
Leftmost, CatQuest: to be fair though, MB is exactly the same, the "publication" just gets created automatically
2017-11-30 33449, 2017
8:40 AM
CatQuest
yes.
2017-11-30 33450, 2017
8:40 AM
Leftmost
Yeah, but that's a pretty seriously convenient thing for it to do.
2017-11-30 33459, 2017
8:40 AM
CatQuest
but afaik it's *always* been like that
2017-11-30 33405, 2017
8:41 AM
drsaunders has quit
2017-11-30 33413, 2017
8:41 AM
CatQuest
aand I've been saying this fro mthe get go
2017-11-30 33426, 2017
8:42 AM
Leftmost
Looks like the index definition is correct, so I'm not sure what's going wrong.
2017-11-30 33449, 2017
8:42 AM
Leftmost
LordSputnik, did regenerating fail?
2017-11-30 33400, 2017
8:43 AM
Leftmost
Or did it just not fix it?
2017-11-30 33401, 2017
8:53 AM
ohrstrom has quit
2017-11-30 33409, 2017
8:56 AM
naiveaiguy
2017-11-30 33431, 2017
8:56 AM
naiveaiguy
CatQuest, Freso
2017-11-30 33456, 2017
9:00 AM
LordSputnik
Leftmost: no, it succeeded
2017-11-30 33419, 2017
9:01 AM
LordSputnik
Leftmost: it could be the search endpoint being used for the search queries
2017-11-30 33413, 2017
9:02 AM
LordSputnik
We know autocomplete works pretty well so we could switch search to use that for the time being
2017-11-30 33419, 2017
9:04 AM
arthelon[m]
search on my local environment is also pretty unreliable
2017-11-30 33419, 2017
9:06 AM
Leftmost
autocomplete does edge filtering. It will probably not be great.
2017-11-30 33411, 2017
9:31 AM
Major_Lurker has quit
2017-11-30 33428, 2017
9:35 AM
Major_Lurker joined the channel
2017-11-30 33412, 2017
9:36 AM
naiveaiguy has quit
2017-11-30 33409, 2017
9:39 AM
Leftmost
Oh hell. I can't test locally because I can't get ES 5.x and 6.x COMPLETELY breaks how we index.
2017-11-30 33437, 2017
9:39 AM
_flow_ has quit
2017-11-30 33437, 2017
9:39 AM
jwf|matrix has quit
2017-11-30 33438, 2017
9:39 AM
minus has quit
2017-11-30 33417, 2017
9:42 AM
_flow_ joined the channel
2017-11-30 33427, 2017
9:42 AM
rembo10 has quit
2017-11-30 33446, 2017
9:42 AM
minus joined the channel
2017-11-30 33401, 2017
9:44 AM
TanviAnand joined the channel
2017-11-30 33429, 2017
9:44 AM
rembo10 joined the channel
2017-11-30 33456, 2017
9:45 AM
jwf|matrix joined the channel
2017-11-30 33436, 2017
9:46 AM
TanviAnand has quit
2017-11-30 33435, 2017
10:01 AM
CatQuest
arthelon[m]: hey
2017-11-30 33400, 2017
10:03 AM
ZarkBit_ joined the channel
2017-11-30 33401, 2017
10:03 AM
ZarkBit_ has quit
2017-11-30 33439, 2017
10:06 AM
CatQuest
arthelon[m]: HEY
2017-11-30 33407, 2017
10:09 AM
arthelon[m]1 joined the channel
2017-11-30 33431, 2017
10:09 AM
arthelon[m]1
oh sorry
2017-11-30 33432, 2017
10:09 AM
arthelon[m]1
just making it a heading so it can be linked