#metabrainz

/

      • SaidS joined the channel
      • 2017-11-30 33435, 2017

      • Said has quit
      • 2017-11-30 33450, 2017

      • UmkaDK has quit
      • 2017-11-30 33441, 2017

      • kepstin has quit
      • 2017-11-30 33419, 2017

      • d4rkie joined the channel
      • 2017-11-30 33427, 2017

      • D4RK-PH0ENiX has quit
      • 2017-11-30 33428, 2017

      • SaidS has quit
      • 2017-11-30 33422, 2017

      • naught101 has quit
      • 2017-11-30 33419, 2017

      • SaidS joined the channel
      • 2017-11-30 33406, 2017

      • SaidS has quit
      • 2017-11-30 33430, 2017

      • SaidS joined the channel
      • 2017-11-30 33450, 2017

      • D4RK-PH0ENiX joined the channel
      • 2017-11-30 33459, 2017

      • d4rkie has quit
      • 2017-11-30 33401, 2017

      • SaidS has quit
      • 2017-11-30 33416, 2017

      • D4RK-PH0ENiX has quit
      • 2017-11-30 33454, 2017

      • D4RK-PH0ENiX joined the channel
      • 2017-11-30 33441, 2017

      • SaidS joined the channel
      • 2017-11-30 33402, 2017

      • Gazooo has quit
      • 2017-11-30 33405, 2017

      • naught101 joined the channel
      • 2017-11-30 33455, 2017

      • Gazooo joined the channel
      • 2017-11-30 33440, 2017

      • Major_Lurker joined the channel
      • 2017-11-30 33447, 2017

      • heyoni has quit
      • 2017-11-30 33429, 2017

      • Leftmost
        LordSputnik, I looked into the </script> thing and I don't have a good path forward yet.
      • 2017-11-30 33409, 2017

      • Leftmost
        I feel like we probably need the JSON to not be directly embedded in a script tag as it is now.
      • 2017-11-30 33445, 2017

      • SaidS has quit
      • 2017-11-30 33408, 2017

      • SaidS joined the channel
      • 2017-11-30 33441, 2017

      • naught101 has quit
      • 2017-11-30 33422, 2017

      • Leftmost
      • 2017-11-30 33406, 2017

      • Slurpee has quit
      • 2017-11-30 33425, 2017

      • naiveaiguy joined the channel
      • 2017-11-30 33428, 2017

      • arthelon[m]
        Leftmost: I made a PR yesterday that escapes prop strings
      • 2017-11-30 33446, 2017

      • Leftmost
        Ahh, hmm. I'll take a look.
      • 2017-11-30 33402, 2017

      • arthelon[m]
        It's a bit more boilerplate for now but once we replace Jade templates with native string ones we can perform all the validation/escaping logic in one file.
      • 2017-11-30 33437, 2017

      • arthelon[m]
        can't do that at the moment bc injecting JS libraries into Jade is too much work.
      • 2017-11-30 33405, 2017

      • Leftmost
        Looks like Travis is failing, but there's no log. D:
      • 2017-11-30 33442, 2017

      • arthelon[m]
        try signing in if you haven't already. The logs appeared once I was authenticated.
      • 2017-11-30 33404, 2017

      • Leftmost
        Odd.
      • 2017-11-30 33414, 2017

      • Leftmost
        Nope, I'm already signed in.
      • 2017-11-30 33419, 2017

      • arthelon[m]
        The node 8 build failed bc of a faulty apt-get install
      • 2017-11-30 33441, 2017

      • Leftmost
        Now it's showing. I think their site might just be having issues.
      • 2017-11-30 33452, 2017

      • arthelon[m]
        urgh, I keep forgetting to run the linter
      • 2017-11-30 33405, 2017

      • arthelon[m]
        this is why we need pre-commit hooks :P
      • 2017-11-30 33413, 2017

      • arthelon[m]
        hope someone claims that GCI task soon
      • 2017-11-30 33433, 2017

      • arthelon[m]
        I'll fix the build in a bit
      • 2017-11-30 33410, 2017

      • Leftmost
        Cool, thanks.
      • 2017-11-30 33419, 2017

      • Leftmost
        Ping me when you do. I'll test and merge.
      • 2017-11-30 33436, 2017

      • naiveaiguy has quit
      • 2017-11-30 33421, 2017

      • arthelon[m]
        Leftmost: ping
      • 2017-11-30 33436, 2017

      • arthelon[m]
        travis-ci build might take a while but lint errors should be resolved
      • 2017-11-30 33453, 2017

      • naught101 joined the channel
      • 2017-11-30 33441, 2017

      • Leftmost
        Pulled and testing now.
      • 2017-11-30 33428, 2017

      • naiveaiguy joined the channel
      • 2017-11-30 33453, 2017

      • naiveaiguy has quit
      • 2017-11-30 33426, 2017

      • travis-ci joined the channel
      • 2017-11-30 33427, 2017

      • travis-ci
        Project bookbrainz-site build #1371: passed in 4 min 49 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2017-11-30 33427, 2017

      • travis-ci has left the channel
      • 2017-11-30 33407, 2017

      • Leftmost
        arthelon[m], marged it.
      • 2017-11-30 33425, 2017

      • Leftmost
        (Or smerged, if you prefer.)
      • 2017-11-30 33441, 2017

      • Leftmost
        Thanks for the fix.
      • 2017-11-30 33436, 2017

      • naught101 has quit
      • 2017-11-30 33420, 2017

      • MusicbrainzB0T joined the channel
      • 2017-11-30 33417, 2017

      • gcilou joined the channel
      • 2017-11-30 33423, 2017

      • MusicbrainzB0T2 has quit
      • 2017-11-30 33424, 2017

      • naiveaiguy joined the channel
      • 2017-11-30 33435, 2017

      • SaidS has quit
      • 2017-11-30 33459, 2017

      • SaidS joined the channel
      • 2017-11-30 33425, 2017

      • MusicbrainzB0T1 joined the channel
      • 2017-11-30 33458, 2017

      • MusicbrainzB0T has quit
      • 2017-11-30 33427, 2017

      • SaidS has quit
      • 2017-11-30 33402, 2017

      • naiveaiguy
        iliekcomputers: All 4 of the example code of API usage are done. Need some feedback regarding details to add into the documentation, but going to try on my own right now.
      • 2017-11-30 33410, 2017

      • SaidS joined the channel
      • 2017-11-30 33423, 2017

      • arthelon[m]
        :D
      • 2017-11-30 33446, 2017

      • SaidS has quit
      • 2017-11-30 33449, 2017

      • SaidS joined the channel
      • 2017-11-30 33407, 2017

      • gcilou has quit
      • 2017-11-30 33440, 2017

      • UmkaDK joined the channel
      • 2017-11-30 33448, 2017

      • naiveaiguy
        Submitted first task for review!
      • 2017-11-30 33410, 2017

      • SaidS has quit
      • 2017-11-30 33442, 2017

      • SaidS joined the channel
      • 2017-11-30 33426, 2017

      • Protab joined the channel
      • 2017-11-30 33426, 2017

      • Rotab has quit
      • 2017-11-30 33433, 2017

      • CatQuest
        well that's annoying
      • 2017-11-30 33439, 2017

      • CatQuest
      • 2017-11-30 33445, 2017

      • CatQuest
        but abandons it :/
      • 2017-11-30 33444, 2017

      • LordSputnik
        Leftmost: I think arthelon[m] has a PR open with a fix that could use review :)
      • 2017-11-30 33459, 2017

      • Leftmost
        LordSputnik, already merged it. :D
      • 2017-11-30 33400, 2017

      • LordSputnik
        Oh you saw that
      • 2017-11-30 33403, 2017

      • LordSputnik
        Haha
      • 2017-11-30 33447, 2017

      • Leftmost
        I'd be lying if I said I actually understood how it works. I looked at the JSON and I don't know what changed. But it works.
      • 2017-11-30 33430, 2017

      • LordSputnik
        Leftmost: if you're able to, it'd be good to get that live on bb.org - just need to stop the bookbrainz.org service, pull the changes in bookbrainz.org/bookbrainz-site folder, "npm install" and then start the service
      • 2017-11-30 33457, 2017

      • Leftmost
        I wasn't sure about putting out some sort of announcement.
      • 2017-11-30 33410, 2017

      • CatQuest
        are we talking about search here? cause i hope so
      • 2017-11-30 33450, 2017

      • Leftmost
        What about search?
      • 2017-11-30 33458, 2017

      • CatQuest
        nomatter what I search for I get the same 10 results basically
      • 2017-11-30 33400, 2017

      • CatQuest
        or wery unrelated ones
      • 2017-11-30 33406, 2017

      • Leftmost
        Hmm. Possibly an issue with the index.
      • 2017-11-30 33419, 2017

      • CatQuest
        like https://bookbrainz.org/search?q=colouring%20book doesnt actually give me tose books I added
      • 2017-11-30 33408, 2017

      • CatQuest
        som students have been saying that the search is unreliable in their feedback too
      • 2017-11-30 33437, 2017

      • LordSputnik
        Leftmost: I tried regenerating the index, it's borked
      • 2017-11-30 33442, 2017

      • LordSputnik
        Not sure why though
      • 2017-11-30 33459, 2017

      • Leftmost
        LordSputnik, I wonder if the index definition is messed up somehow. I'm checking on that now.
      • 2017-11-30 33406, 2017

      • LordSputnik
        Thanks :)
      • 2017-11-30 33439, 2017

      • LordSputnik
        Might be good to check the commits to search too to try to identify when I broke it ;)
      • 2017-11-30 33408, 2017

      • LordSputnik
        In other news, 20 completed BB tasks! Good work arthelon[m] and CatQuest
      • 2017-11-30 33441, 2017

      • CatQuest
        heh this is the tird person saying that the publication to be created before the edition thing is confusing :G:
      • 2017-11-30 33452, 2017

      • CatQuest
        LordSputnik: I havent doen much, it was mostly art
      • 2017-11-30 33403, 2017

      • CatQuest
        I'm looking now aamof
      • 2017-11-30 33410, 2017

      • naiveaiguy
        CatQuest: how can you see what tasks are claimed/completed?
      • 2017-11-30 33435, 2017

      • CatQuest
        naiveaiguy: by being a mentor ;)
      • 2017-11-30 33442, 2017

      • naiveaiguy
        oh lol
      • 2017-11-30 33431, 2017

      • Leftmost
        CatQuest, because it is. :P
      • 2017-11-30 33409, 2017

      • CatQuest
        Leftmost: since you talked with thme here do yo uwant to take this? https://codein.withgoogle.com/dashboard/task-inst…
      • 2017-11-30 33426, 2017

      • LordSputnik
        Leftmost, CatQuest: to be fair though, MB is exactly the same, the "publication" just gets created automatically
      • 2017-11-30 33449, 2017

      • CatQuest
        yes.
      • 2017-11-30 33450, 2017

      • Leftmost
        Yeah, but that's a pretty seriously convenient thing for it to do.
      • 2017-11-30 33459, 2017

      • CatQuest
        but afaik it's *always* been like that
      • 2017-11-30 33405, 2017

      • drsaunders has quit
      • 2017-11-30 33413, 2017

      • CatQuest
        aand I've been saying this fro mthe get go
      • 2017-11-30 33426, 2017

      • Leftmost
        Looks like the index definition is correct, so I'm not sure what's going wrong.
      • 2017-11-30 33449, 2017

      • Leftmost
        LordSputnik, did regenerating fail?
      • 2017-11-30 33400, 2017

      • Leftmost
        Or did it just not fix it?
      • 2017-11-30 33401, 2017

      • ohrstrom has quit
      • 2017-11-30 33409, 2017

      • naiveaiguy
        It appears this task: https://tinyurl.com/numero-uno-duplicate and this task: https://tinyurl.com/numero-dous-duplicate are the exact same
      • 2017-11-30 33431, 2017

      • naiveaiguy
        CatQuest, Freso
      • 2017-11-30 33456, 2017

      • LordSputnik
        Leftmost: no, it succeeded
      • 2017-11-30 33419, 2017

      • LordSputnik
        Leftmost: it could be the search endpoint being used for the search queries
      • 2017-11-30 33413, 2017

      • LordSputnik
        We know autocomplete works pretty well so we could switch search to use that for the time being
      • 2017-11-30 33419, 2017

      • arthelon[m]
        search on my local environment is also pretty unreliable
      • 2017-11-30 33419, 2017

      • Leftmost
        autocomplete does edge filtering. It will probably not be great.
      • 2017-11-30 33411, 2017

      • Major_Lurker has quit
      • 2017-11-30 33428, 2017

      • Major_Lurker joined the channel
      • 2017-11-30 33412, 2017

      • naiveaiguy has quit
      • 2017-11-30 33409, 2017

      • Leftmost
        Oh hell. I can't test locally because I can't get ES 5.x and 6.x COMPLETELY breaks how we index.
      • 2017-11-30 33437, 2017

      • _flow_ has quit
      • 2017-11-30 33437, 2017

      • jwf|matrix has quit
      • 2017-11-30 33438, 2017

      • minus has quit
      • 2017-11-30 33417, 2017

      • _flow_ joined the channel
      • 2017-11-30 33427, 2017

      • rembo10 has quit
      • 2017-11-30 33446, 2017

      • minus joined the channel
      • 2017-11-30 33401, 2017

      • TanviAnand joined the channel
      • 2017-11-30 33429, 2017

      • rembo10 joined the channel
      • 2017-11-30 33456, 2017

      • jwf|matrix joined the channel
      • 2017-11-30 33436, 2017

      • TanviAnand has quit
      • 2017-11-30 33435, 2017

      • CatQuest
        arthelon[m]: hey
      • 2017-11-30 33400, 2017

      • ZarkBit_ joined the channel
      • 2017-11-30 33401, 2017

      • ZarkBit_ has quit
      • 2017-11-30 33439, 2017

      • CatQuest
        arthelon[m]: HEY
      • 2017-11-30 33407, 2017

      • arthelon[m]1 joined the channel
      • 2017-11-30 33431, 2017

      • arthelon[m]1
        oh sorry
      • 2017-11-30 33432, 2017

      • arthelon[m]1
        just making it a heading so it can be linked