#metabrainz

iliekcomputers: thanks for your review! I've sent you a few queries.

anshuman73: starting some work on the CritiqueBrainz WYSIWYG editor

Hello!

TheJYKoder: Hello!

goodnight everyone!

Hi everyone! I'm from GCI, I have a quick question about adding a release - If the title of the album lists several artists (ex. The Best of [artist1], [artist2], etc.) should I be listing every single artist in the title? In this case I have 15

I'm not able to find a digital copy or any references to the release since I have a physical copy & it is only released in Dutch

is it a cd? there might be a shorter title on the spine, or on the disc itself

ah you're right, there is a shorter title on the spine. Thanks!!

Hello all!

haruute0: hello@

!

arthelon: could you take a look at my task, thanks :D

LordSputnik: added a pretty critical but simple fix https://github.com/bookbrainz/bookbrainz-site/p...

I've tested it on almost all the forms with a select input

could you double check to make sure it doesn't break anything

arthelon[m]: which page was broken previously?

gender select input on the registration-details and the select input on the profile page were the ones I noticed

yeah, seems like usage of that wrapper component is limited to those pages

LordSputnik: hey, i've made some template for the badges, could you take a look at my task? No problem if you busy, thanks :D

haruute0: Sorry for the delay. I'll have a look in a sec

arthelon: yay, thanks

haruute0: I'm not "on duty" for another 7-8 hours, at my day job at the moment ;)

anshuman73: for the WYSIWYG editor task, I know you guys had suggested using SimpleMDE, but I found this editor (https://nhnent.github.io/tui.editor/) called ToastUI. What I like about it is the side-by-side preview, rather than the eye icon that SimpleMDE has. It's also prettier, and uses github-flavoured markdown. What do you think?

anshuman73: it also has the advantage of having a 100% WYSIWYG mode

anshuman73: *and* it's more actively mantained - last commit on simplemde was in june 2016

legoktm: Sure, but GCI students won't be getting admin privileges. :)

(Re: setting CSS in wiki's admin section vs. setting CSS inline.)

naiveaiguy: I think the main concern is whether it supports the same markdown flavour that CB uses.

Other than that, I don't think any current devs have a strong preference for which specific editor to use.

Freso: k. will check.

naiveaiguy: before you proceeed to work on this, I'd just like to point out it's also a task on GCI which currently is un-cliamed

claimed*

anshuman73: i do know. im not directly starting work on it now, just researching.

while im waiting for some clarification on my previous task, i thought might as well

alright, lemme have a look at the editor you mentioned. Last year I did quite a bit of research too, never came across this one

naiveaiguy: Selecting/defining a common Markdown syntax to be used in all *Brainz projects is a task in itself.

Community forums are the main piece supporting (Discourse/Standard) MarkDown.

naiveaiguy: I checked up, CB uses the most commonly used daringfireball's guidelines, so that shold be compatible with GH standards

yvanzo: maybe daringfireball's could be a good standardisation

Reference - https://daringfireball.net/projects/markdown/sy...

anshuman73: It's not a problem with that CB is compatible with GH syntax, it's more a problem if TUI Editor uses GH syntax that is not compatible with CB.

anshuman73: Also, the daringfireball is the reference for *all* markdown specifications, the problem is that it is ambiguous in some instances and has other omissions, which various markdown implementations deal with in various ways.

Common Markdown is what Discourse is using, I believe.

*CommonMark

Freso: since CB using daringfireball, and so does GFM, ToastUI should be compatible with CB

naiveaiguy: GH doesn't using "daringfireball", GH is using a bunch of extensions in their markdown.

naiveaiguy: I still find simplemde a lot more fluid than this one, and it has a nice inbuilt functionality of auto-save, which I think can be implemented with CB's Draft functionality to produce nice autosaved review in case of an accident. However the current development standards of it makes it slightly risky, but considering it's pretty neat working even now, I'd stick with it

Freso: yes, but GFM is a superset of the daringfireball standard.

IIRC

naiveaiguy: hence Freso's concerns

if it has more features, then we might not be supporting them

anshuman73: oh duh, brain fart.

"it's more a problem if TUI Editor uses GH syntax that is not compatible with CB."

naiveaiguy: All markdown implementations are.

naiveaiguy: The problem is that it's a *superset* and if TUI uses GH's superset and CB's superset is different...

(Also plane wifi lag. 🙌)

yeah, yeah I see what you mean didn't realize it

lemme check the details on Tui's github

naiveaiguy: We just need a comparison to make sure there is no major incompatibilities.

yvanzo: yep

I think there's a ticket somewhere for choosing a markdown flavour for all projects.

Take each supported item in CB and Community and check it in GFM.

OTHER-77

OTHER-77: Unify all markup syntax to simple markdown syntax https://tickets.metabrainz.org/browse/OTHER-77

Maybe we could make a research ticket for that (it doesn't have to influence the WYSIWYG editor for now), to compare the various MD flavours and pro-et-cons?

maybe make a gci task to make a detailed report ?

Freso: +1

anshuman73: I meant task, not ticket. :p

If anyone feels like writing it up, I can look it over a bit later.

Freso: IMHO it doesn't have to be so complicated. I'd be happy to do it, but I don't think it needs too deep of an analysis.

naiveaiguy: standards are important.