-
naiveai
anshuman73: for some reason my CritiqueBrainz setup isn't working anymore :(
2017-12-31 36556, 2017
-
Kovensky has quit
2017-12-31 36509, 2017
-
Kovensky joined the channel
2017-12-31 36511, 2017
-
naiveai
i now have docker running on a vagrant machine -.-
2017-12-31 36528, 2017
-
naiveai
which seems to work. man, i am never working with macOS again.
2017-12-31 36525, 2017
-
D4RK-PH0ENiX has quit
2017-12-31 36549, 2017
-
SothoTalKer
try your best
2017-12-31 36543, 2017
-
LordSputnik
naiveai: I've reviewed your PR again - only to comments this time
2017-12-31 36558, 2017
-
LordSputnik
It's a bit late here so I'm a bit tired to do a full review
2017-12-31 36514, 2017
-
LordSputnik
arthelon[m]: are you able to have a look over it?
2017-12-31 36546, 2017
-
D4RK-PH0ENiX joined the channel
2017-12-31 36545, 2017
-
arthelon[m]
Pretty busy these next two days
2017-12-31 36556, 2017
-
arthelon[m]
I'll see if I have time tonight
2017-12-31 36527, 2017
-
UmkaDK joined the channel
2017-12-31 36523, 2017
-
naiveai
LordSputnik: cool, will fix
2017-12-31 36524, 2017
-
xps2 joined the channel
2017-12-31 36512, 2017
-
annebelleo joined the channel
2017-12-31 36531, 2017
-
melloc11 joined the channel
2017-12-31 36528, 2017
-
annebelleo has quit
2017-12-31 36547, 2017
-
xps2 has quit
2017-12-31 36549, 2017
-
notdaniel joined the channel
2017-12-31 36500, 2017
-
naiveai
LordSputnik: change suggested doesn't look to be possible
2017-12-31 36529, 2017
-
UmkaDK has quit
2017-12-31 36546, 2017
-
naiveai
Lotheric: is the double "L'" in MBS-5345 a typo, or did JIRA do something to it?
2017-12-31 36546, 2017
-
BrainzBot
2017-12-31 36500, 2017
-
annebelleo joined the channel
2017-12-31 36524, 2017
-
naiveai
and is does this count for L'something (without a space)?
2017-12-31 36513, 2017
-
naiveai
and for "L'something something", and "La something something"
2017-12-31 36521, 2017
-
naiveai
and should we also correct "l'something, "la something" into "L'Something", "La Something"
2017-12-31 36502, 2017
-
SothoTalKer
it is two different apostrophes
2017-12-31 36511, 2017
-
naiveai
ah
2017-12-31 36528, 2017
-
SothoTalKer
you see, there is the standard one '
2017-12-31 36535, 2017
-
SothoTalKer
and then there's ’
2017-12-31 36511, 2017
-
SothoTalKer
makes no real difference for display, but some people like to use the typograpic correct one
2017-12-31 36551, 2017
-
naiveai
and another thing, does "L' something" need to be fixed into "L'Something"
2017-12-31 36503, 2017
-
xps2 joined the channel
2017-12-31 36514, 2017
-
theremin has quit
2017-12-31 36556, 2017
-
Leftmost
I think that's outside the scope of guess case.
2017-12-31 36558, 2017
-
annebelleo has quit
2017-12-31 36558, 2017
-
drsaunders joined the channel
2017-12-31 36540, 2017
-
github joined the channel
2017-12-31 36540, 2017
-
github
[picard-website] haruute0 opened pull request #107: Use HTTPS for linking to external links (master...https-for-external-links)
https://git.io/vbAVT
2017-12-31 36540, 2017
-
github has left the channel
2017-12-31 36541, 2017
-
yvanzo
naiveai: yes, without a space, both apostrophes should be handled and fixing it is optional.
2017-12-31 36503, 2017
-
yvanzo
2017-12-31 36509, 2017
-
SothoTalKer
i know
2017-12-31 36525, 2017
-
yvanzo
not just “some people” :)
2017-12-31 36533, 2017
-
SothoTalKer
but there is currently no easy way to autoconvert stuff like this :p
2017-12-31 36500, 2017
-
SothoTalKer
and doing it by hand is tedious :|
2017-12-31 36514, 2017
-
naiveai
2017-12-31 36523, 2017
-
yvanzo
The issue is that the ASCII apostrophe might be more appropriate in some context, but not this one.
2017-12-31 36541, 2017
-
SothoTalKer
yvanzo? when exactly? :)
2017-12-31 36531, 2017
-
yvanzo
2017-12-31 36502, 2017
-
SothoTalKer
well, apostrophe isn't the only character
2017-12-31 36523, 2017
-
SothoTalKer
hyphen and hyphen-minus, endash, emdash
2017-12-31 36539, 2017
-
SothoTalKer
inch vs. "
2017-12-31 36559, 2017
-
SothoTalKer
and all those different quotation marks
2017-12-31 36518, 2017
-
yvanzo
But they do not necessarily appear in the current pattern.
2017-12-31 36527, 2017
-
yvanzo
naiveai: LGTM
2017-12-31 36538, 2017
-
naiveai
wohoo!
2017-12-31 36514, 2017
-
naiveai
since this is not specific to a particular type, I'm trying to find where it's best to put the tests
2017-12-31 36522, 2017
-
SothoTalKer
the ascii apostrophe is usually never the correct one :p
2017-12-31 36534, 2017
-
SothoTalKer
anyway, it is "allowed", so i am still correct ;)
2017-12-31 36504, 2017
-
yvanzo
naiveai: Oops, just missing the stard / end of string :p
2017-12-31 36526, 2017
-
SothoTalKer
well, we both are, but as I was told, only people with OCD tend to change the apostrophes :D
2017-12-31 36549, 2017
-
naiveai
yvanzo: do you mean the ^$?
2017-12-31 36517, 2017
-
yvanzo
exactly
2017-12-31 36559, 2017
-
naiveai
ah, will add. then replace the 2nd match with a capitalization
2017-12-31 36538, 2017
-
yvanzo
Because if there is more words, the capitalization rule does not necessarily apply as is.
2017-12-31 36552, 2017
-
naiveai
"L'fétos".replace(regex, (_, m1, m2) => { return m1 + m2[0].toUpperCase() + m2.slice(1) })
2017-12-31 36529, 2017
-
naiveai
(or I could use lodash _.capitalize)
2017-12-31 36508, 2017
-
yvanzo
(+1)
2017-12-31 36533, 2017
-
naiveai
nice, will implement
2017-12-31 36512, 2017
-
naiveai
yvanzo: should I put into the runPostProcess of the French mode, or is there a more appropriate place to put it (couldn't find one)
2017-12-31 36501, 2017
-
annebelleo joined the channel
2017-12-31 36549, 2017
-
dpmittal joined the channel
2017-12-31 36500, 2017
-
yvanzo
naiveai: it seems to be the most appropriate place indeed
2017-12-31 36511, 2017
-
naiveai
k, will submit when I can
2017-12-31 36536, 2017
-
naiveai
getting a weird "badly formed hash line" error when execing the tests
2017-12-31 36542, 2017
-
xps2 has quit
2017-12-31 36556, 2017
-
naiveai
yvanzo: last thing (sorry!) should this apply to J' as well? As in J'Attendrai?
2017-12-31 36554, 2017
-
naiveai
scratch that, the guidelines don't say so
2017-12-31 36502, 2017
-
drsaunde joined the channel
2017-12-31 36546, 2017
-
drsaunders has quit
2017-12-31 36505, 2017
-
naiveai
yvanzo: added the tests in the Work section, since it's most applicable there.
2017-12-31 36526, 2017
-
yvanzo
naiveai: Not for “J” which is a subject, whereas “L” is an article. The correct capitalization is “J’attendrai” because it is a verb phrase.
2017-12-31 36516, 2017
-
yvanzo
2017-12-31 36525, 2017
-
Rotab has quit
2017-12-31 36557, 2017
-
dpmittal_ joined the channel
2017-12-31 36558, 2017
-
dpmittal has quit
2017-12-31 36536, 2017
-
annebelleo has quit
2017-12-31 36553, 2017
-
drsaunders joined the channel
2017-12-31 36547, 2017
-
drsaunde has quit
2017-12-31 36513, 2017
-
d4rkie joined the channel
2017-12-31 36536, 2017
-
D4RK-PH0ENiX has quit
2017-12-31 36526, 2017
-
dpmittal_ has quit
2017-12-31 36504, 2017
-
Rotab joined the channel
2017-12-31 36503, 2017
-
drsaunde joined the channel
2017-12-31 36507, 2017
-
drsaunders has quit
2017-12-31 36507, 2017
-
Bruker has quit
2017-12-31 36533, 2017
-
Bruker joined the channel
2017-12-31 36544, 2017
-
PROTechThor joined the channel
2017-12-31 36557, 2017
-
naiveai has quit
2017-12-31 36520, 2017
-
naiveai joined the channel
2017-12-31 36510, 2017
-
Lotheric
omg, really ? someone is going to try to fix the messed up guess case for french ? :)
2017-12-31 36515, 2017
-
Lotheric
kudos
2017-12-31 36516, 2017
-
Lotheric
hehe
2017-12-31 36528, 2017
-
naiveai
Lotheric: well it wasn't really that hard, i've got a preliminary thing ready
2017-12-31 36526, 2017
-
Lotheric
maybe if it's a little better (won't be perfect as it's much harder to code than english for example) people will use it
2017-12-31 36532, 2017
-
Lotheric
french rules are weird
2017-12-31 36526, 2017
-
naiveai has quit
2017-12-31 36557, 2017
-
notdaniel has quit
2017-12-31 36504, 2017
-
naiveai joined the channel
2017-12-31 36530, 2017
-
PROTechThor has quit
2017-12-31 36530, 2017
-
PROTechThor joined the channel
2017-12-31 36519, 2017
-
PROTechThor
2017-12-31 36507, 2017
-
Bruker has quit
2017-12-31 36530, 2017
-
Bruker joined the channel
2017-12-31 36537, 2017
-
naiveai
PROTechThor: don't ask something on two channels simultenously unless it's really relevant to both. #musicbrainz is always the one for editing.
2017-12-31 36538, 2017
-
iliekcomputers
naiveai: it is no big deal really :)
2017-12-31 36559, 2017
-
naiveai
yeah, but it's just good practice
2017-12-31 36520, 2017
-
naiveai
at least I would say
2017-12-31 36529, 2017
-
Wizzup has quit
2017-12-31 36558, 2017
-
Wizzup joined the channel
2017-12-31 36530, 2017
-
xps2 joined the channel
2017-12-31 36557, 2017
-
drsaunde has quit
2017-12-31 36553, 2017
-
PROTechThor has quit
2017-12-31 36539, 2017
-
UmkaDK joined the channel
2017-12-31 36557, 2017
-
ruaok
iliekcomputers: the dump ran to completion and there are 2GB worth of xz compressed listens. :)
2017-12-31 36544, 2017
-
ruaok
I'm going to get some food, then I'll uncompress it and have a detailed look
2017-12-31 36556, 2017
-
iliekcomputers
ruaok: \o/
2017-12-31 36505, 2017
-
d4rkie has quit
2017-12-31 36505, 2017
-
drsaunders joined the channel
2017-12-31 36509, 2017
-
UmkaDK_ joined the channel
2017-12-31 36551, 2017
-
UmkaDK has quit
2017-12-31 36513, 2017
-
naiveai has quit
2017-12-31 36541, 2017
-
D4RK-PH0ENiX joined the channel
2017-12-31 36515, 2017
-
UmkaDK_ has quit
2017-12-31 36539, 2017
-
djwhitey__ joined the channel
2017-12-31 36531, 2017
-
kuno has quit
2017-12-31 36532, 2017
-
djinni` has quit
2017-12-31 36504, 2017
-
djwhitey_ has quit
2017-12-31 36504, 2017
-
CatCat has quit
2017-12-31 36504, 2017
-
eharris has quit
2017-12-31 36531, 2017
-
CatCat joined the channel
2017-12-31 36531, 2017
-
CatCat has quit
2017-12-31 36531, 2017
-
CatCat joined the channel
2017-12-31 36536, 2017
-
antlarr2 has quit
2017-12-31 36503, 2017
-
djinni` joined the channel
2017-12-31 36539, 2017
-
kuno joined the channel
