[CAA-indexer] mwiencek opened pull request #14: Refresh connections (master...refresh-connections) https://git.io/vNTqD
github has left the channel
spellew has quit
Slurpee has quit
Lotheric_ joined the channel
naiveai
bitmap: any chance you still have the link for the tiny dev dump?
reosarevok_ joined the channel
mrc0mmand_ joined the channel
D4RK-PH0ENiX has quit
IsaacZanoria joined the channel
IsaacZanoria has quit
anthony25_ joined the channel
anthony25 has quit
AfroThundr has quit
Lotheric has quit
mrc0mmand has quit
reosarevok has quit
Leftmost has quit
mrc0mmand_ is now known as mrc0mmand
reosarevok_ is now known as reosarevok
anthony25_ is now known as anthony25
AfroThundr joined the channel
Leftmost joined the channel
D4RK-PH0ENiX joined the channel
xps2 has quit
spellew joined the channel
TehTotalPwnage has quit
Rahul_india joined the channel
Rahul_india
Hey I'm from GCI, I'm adding releases to musicbrainz data
Now I'm unable to find more CDs at my home
What should I do
Freso
Rahul_india: #musicbrainz is probably a better place to ask for help with MusicBrainz editing. :)
naiveai
Rahul_india: well, you can try some other tasks out
Rahul_india: the 78 rpm task is a good one
TehTotalPwnage joined the channel
Rahul_india has quit
Ashish has quit
Nyanko-sensei has quit
spellew has quit
spellew joined the channel
spellew has quit
yvanzo: I think I've got my local MusicBrainz instance running again - but the last french test is failing (the Troie one) even with keepuppercase. is it reproducable on your end?
yvanzo: It doesn't seem to be related to my changes, since the test is failing becuase "Troie" is changing to "troie"
if I change the test to expect "troie", it passes
yvanzo: what it looks like is that French mode, for some reason, doesn't respect keepuppercase
which is very odd
yvanzo: the Jenkins build is also failing for what looks like the same reason
confirmed not related to my change because test still fails without it
yashg21 has quit
bitmap
naiveai: I don't have it anymore, but I'm generating a new one now
naiveai
bitmap: thanks!
Leo_Verto
naiveai: replied to your task, I'll review the PR later today but it looks pretty good so far :D
naiveai
Leo_Verto: :D
Leo_Verto
between you and annebelle, I'm really running out of BrainzBot tasks. I guess I'll have to turn some more of the tickets into tasks then :P
naiveai
Leo_Verto: actually, I think this is my first BrainzBot task - all credit goes to annebelle
Leo_Verto: done!
Nyanko-sensei joined the channel
D4RK-PH0ENiX has quit
MajorLurker has quit
MajorLurker joined the channel
github joined the channel
github
[critiquebrainz] IsaacZanoria opened pull request #170: CB-263: Update publication date of draft reviews on CritiqueBrainz when they get published (master...CB-263) https://git.io/vNT8V
github has left the channel
IsaacZanoria joined the channel
naiveai has quit
naiveai joined the channel
naiveai has quit
naiveai joined the channel
D4RK-PH0ENiX joined the channel
Nyanko-sensei has quit
drsaunders has quit
drsaunders joined the channel
adhawkins has quit
ephemer0l_ has quit
adhawkins joined the channel
adhawkins has quit
adhawkins joined the channel
IsaacZanoria has quit
dpmittal joined the channel
dpmittal has quit
ephemer0l_ joined the channel
xps2 joined the channel
vk27[m] has left the channel
naiveai
I'm trying to test the renderRelationship function, which returns a string of rendered HTML. Is it worth bringing in a dependency like chai-html for this?
Freso[m] has quit
namitkrarya[m] has quit
MusicbrainzB0T1 joined the channel
MusicbrainzB0T has quit
Nyanko-sensei joined the channel
D4RK-PH0ENiX has quit
heywassup[m] has quit
xps2 has quit
alphawizard[m] has quit
Leo_Verto: for the document & test task, are we allowed to modify the function in question to pass the tests?
Leo_Verto: and do we have to check things that flow type annotations can? in my case, renderRelationship(relationship) requires that relationship have `source` and `target` properties, but that can be checked using a flow type annotation
spellew joined the channel
rahul_india joined the channel
rahul_india
hello i'm from GCI
naiveai
rahul_india: yes, no need to introduce yourself again :)
rahul_india
i've a CD which has tracks in .cda format. picard is unable to detect any files on the disc
CD lookup is opening but not showing any files in it.
samj1912: it is a request type where the backend sends the whole response of a request is sent to nginx to return to the caller.
samj1912
that sentence flew over my head
ruaok
without it, if you have slower requestor, say on a mobile connection, the backends needs to wait until nginx has finished sending all the contract before the backend can handle a new request.
which ties up precious back-ends.
samj1912
ah
ruaok
but by handing the whole request to nginx and then going off to handle the next request, the back ends (expensive) are freed up quickly and the cheap front ends kick around until the request is done or times out.
Freso: there's a slight error in https://goo.gl/ughsb1, the branch name is "viewport-meta-YOUR_GCI_USERNAME" rather than "client-function-YOUR_GCI_USERNAME"
ruaok
sorta.
its hands it to nginx
the web service figures out the new URL for this, a search url, then hands it back to nginx, which then issues that request and returns it to the user. transparently.
samj1912
makes sense
yvanzo: bitmap any idea why testing PRs for mbs is taking so much time?
ruaok: with SOLR-16 fixed, I guess no output incompatibilities should be left